Commit graph

211 commits

Author SHA1 Message Date
Pablo Zmdl
a16b02293a Turn install_latest_major property into a string so we can save a version string or number
I chose a string instead of an integer so we have more freedom what to
actually save (maybe we want to include minor version digits at one point).

Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-26 10:50:55 +01:00
Pablo Zmdl
cc596c2b27 Type-cast get values to fix handling old config data
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-26 10:50:55 +01:00
Pablo Zmdl
81858c4975 Don't write the default value to disk
This matches the previous behaviour and should not be changed silently.

Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-26 10:50:55 +01:00
Pablo Zmdl
b4364366f5 Replace setMultiple() by startTransaction() and commitTransaction()
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-26 10:50:55 +01:00
Pablo Zmdl
e40ce75759 Make aio-variables code more robust and psalm-compatible
Now the input gets checked for being useful. It's user-generated data in the
end, which might be "funny" in curious ways.

psalm complained about the possibly unset second array key in the
destructuring assignment of `$key` and `$value`, which won't happen due to the
check for a present equal sign earlier, but nonetheless this way the code is
more robust.

Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-26 10:50:55 +01:00
Pablo Zmdl
78626a60d2 Type for Closure argument
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-26 10:50:55 +01:00
Pablo Zmdl
d4b016d024 Simplify some code a little bit
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-26 10:50:55 +01:00
Pablo Zmdl
903ee42815 Move handling ENV-var replacement into ConfigurationManger
It's the more appropriate place to have this code, and we had to touch
it anyways to make it assign the values to the attributes.

Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-26 10:50:55 +01:00
Pablo Zmdl
9119953b3e Remove residue code
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-26 10:50:55 +01:00
Pablo Zmdl
0939b94397 Privatize GetConfig() and WriteConfig()
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-26 10:50:55 +01:00
Pablo Zmdl
8cec4ab2bf Make nextcloud_max_time an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-26 10:50:55 +01:00
Pablo Zmdl
abd761fe2f Make nextcloud_memory_limit an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-26 10:50:55 +01:00
Pablo Zmdl
531c7c6fb6 Make nextcloud_datadir_mount an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-26 10:50:55 +01:00
Pablo Zmdl
aa94ad05e8 Make nextcloud_mount an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-26 10:50:55 +01:00
Pablo Zmdl
bc21ea9795 Make nextcloud_upload_limit an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-26 10:50:55 +01:00
Pablo Zmdl
cf60cbe9bc Make talk_port an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-26 10:50:55 +01:00
Pablo Zmdl
3f37b77255 Make apache_port an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-26 10:50:55 +01:00
Pablo Zmdl
ac7ce99f6b Make apache_ip_binding an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-26 10:50:55 +01:00
Pablo Zmdl
ab27265ed8 Make turn_domain an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-26 10:50:55 +01:00
Pablo Zmdl
41be41b70a Make aio_community_containers an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-26 10:50:55 +01:00
Pablo Zmdl
062930dbb4 Make collabora_additional_options an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-26 10:50:55 +01:00
Pablo Zmdl
283efc20e9 Make collabora_dictionaries an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-26 10:50:55 +01:00
Pablo Zmdl
cc62f83c86 Make timezone an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-26 10:50:55 +01:00
Pablo Zmdl
16cfcc28be Make borg_restore_password an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-26 10:50:55 +01:00
Pablo Zmdl
6311551252 Make borg_remote_repo an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-26 10:50:55 +01:00
Pablo Zmdl
6488498bad Make borg_backup_host_location an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-26 10:50:55 +01:00
Pablo Zmdl
8c4b05d768 Make domain an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-26 10:50:55 +01:00
Pablo Zmdl
7c60c69268 Make isFulltextsearchEnabled an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-26 10:50:54 +01:00
Pablo Zmdl
16ce71412f Make isImaginaryEnabled an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-26 10:50:54 +01:00
Pablo Zmdl
4203078701 Make isTalkRecordingEnabled an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-26 10:50:54 +01:00
Pablo Zmdl
aca1ec163d Make isTalkEnabled an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-26 10:50:54 +01:00
Pablo Zmdl
32e1f84bc9 Make isCollaboraEnabled an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-26 10:50:54 +01:00
Pablo Zmdl
958b1dd28f Make isOnlyofficeEnabled an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-26 10:50:54 +01:00
Pablo Zmdl
b6a1dc3731 Make isClamavEnabled an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-26 10:50:54 +01:00
Pablo Zmdl
5226d9ff63 Make instance_restore_attempt an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-26 10:50:54 +01:00
Pablo Zmdl
351abb8e65 Make isDockerSocketProxyEnabled an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-26 10:50:54 +01:00
Pablo Zmdl
24859fd706 Make backupMode an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-26 10:50:54 +01:00
Pablo Zmdl
462160aaa5 Make isWhiteboardEnabled an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-26 10:50:54 +01:00
Pablo Zmdl
385eba66df Make restoreExcludePreviews an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-26 10:50:54 +01:00
Pablo Zmdl
d3248746cc Make selectedRestoreTime an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-26 10:50:54 +01:00
Pablo Zmdl
206ad7995a Make install_latest_major an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-26 10:50:54 +01:00
Pablo Zmdl
cc2a6dde65 Make AIO_URL an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-26 10:50:54 +01:00
Pablo Zmdl
3b26cd7b22 Make wasStartButtonClicked an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-26 10:50:54 +01:00
Pablo Zmdl
c4c04ebcf4 Make password an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-26 10:50:54 +01:00
Pablo Zmdl
4318488937 Make AIO_TOKEN an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-26 10:50:54 +01:00
Pablo Zmdl
2d7f360706 Adapt GetAndGenerateSecret() to get() and set()
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-26 10:50:54 +01:00
Pablo Zmdl
683cfe1292 Adapt GetEnvironmentalVariableOrConfig() to get() and set()
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-26 10:50:54 +01:00
Pablo Zmdl
a1df2fd33b Cache config, introduce get() and set() helpers to guide new way to set attributes
Use cached config, use set() for single attributes, setMultiple to wrap
multiple calls to set()

Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-26 10:50:54 +01:00
Simon L.
be1199ace1
Merge pull request #7244 from nextcloud/enh/6690/follow-up
adjust `DeleteBorgBackupLocationVars` to also delete the `borg.config` file
2025-12-03 11:36:33 +01:00
Simon L.
d425bb226c
Merge pull request #7238 from nextcloud/enh/noid/refactor-backup-mode
refactor `backup-mode` handling
2025-12-03 11:35:02 +01:00