Commit graph

210 commits

Author SHA1 Message Date
Pablo Zmdl
271234c002 Type-cast get values to fix handling old config data
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-23 17:49:09 +01:00
Pablo Zmdl
fb3f8172ca Don't write the default value to disk
This matches the previous behaviour and should not be changed silently.

Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-23 17:49:09 +01:00
Pablo Zmdl
ec9b4b9b38 Replace setMultiple() by startTransaction() and commitTransaction()
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-23 17:49:09 +01:00
Pablo Zmdl
7261438180 Make aio-variables code more robust and psalm-compatible
Now the input gets checked for being useful. It's user-generated data in the
end, which might be "funny" in curious ways.

psalm complained about the possibly unset second array key in the
destructuring assignment of `$key` and `$value`, which won't happen due to the
check for a present equal sign earlier, but nonetheless this way the code is
more robust.

Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-23 17:49:09 +01:00
Pablo Zmdl
be961cedc3 Type for Closure argument
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-23 17:49:09 +01:00
Pablo Zmdl
65c253158c Simplify some code a little bit
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-23 17:49:09 +01:00
Pablo Zmdl
ebbba9744d Move handling ENV-var replacement into ConfigurationManger
It's the more appropriate place to have this code, and we had to touch
it anyways to make it assign the values to the attributes.

Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-23 17:49:09 +01:00
Pablo Zmdl
d2c07bbbf7 Remove residue code
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-23 17:47:46 +01:00
Pablo Zmdl
d88871f52e Privatize GetConfig() and WriteConfig()
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-23 17:47:46 +01:00
Pablo Zmdl
6c991873db Make nextcloud_max_time an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-23 17:47:46 +01:00
Pablo Zmdl
6ee312e7a8 Make nextcloud_memory_limit an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-23 17:47:46 +01:00
Pablo Zmdl
ea5a6d983d Make nextcloud_datadir_mount an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-23 17:47:46 +01:00
Pablo Zmdl
44d5b7cd5e Make nextcloud_mount an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-23 17:47:46 +01:00
Pablo Zmdl
bb865b7dee Make nextcloud_upload_limit an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-23 17:46:30 +01:00
Pablo Zmdl
3c5b3e5698 Make talk_port an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-23 17:46:30 +01:00
Pablo Zmdl
a7c35eda5a Make apache_port an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-23 17:46:30 +01:00
Pablo Zmdl
ead6ec088f Make apache_ip_binding an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-23 17:46:30 +01:00
Pablo Zmdl
a3a2a034c0 Make turn_domain an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-23 17:46:30 +01:00
Pablo Zmdl
772fab9577 Make aio_community_containers an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-23 17:46:30 +01:00
Pablo Zmdl
b6e429f1f3 Make collabora_additional_options an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-23 17:46:30 +01:00
Pablo Zmdl
e13c6083fe Make collabora_dictionaries an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-23 17:46:30 +01:00
Pablo Zmdl
9df3a7b231 Make timezone an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-23 17:46:30 +01:00
Pablo Zmdl
f030abcafd Make borg_restore_password an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-23 17:46:30 +01:00
Pablo Zmdl
6df0333f71 Make borg_remote_repo an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-23 17:46:30 +01:00
Pablo Zmdl
4d246add8a Make borg_backup_host_location an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-23 17:46:30 +01:00
Pablo Zmdl
7925935381 Make domain an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-23 17:46:30 +01:00
Pablo Zmdl
6767fcfc8a Make isFulltextsearchEnabled an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-23 17:46:30 +01:00
Pablo Zmdl
a58c41e750 Make isImaginaryEnabled an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-23 17:46:30 +01:00
Pablo Zmdl
52c981f49a Make isTalkRecordingEnabled an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-23 17:46:30 +01:00
Pablo Zmdl
d895e0d8e1 Make isTalkEnabled an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-23 17:46:30 +01:00
Pablo Zmdl
18e5141c15 Make isCollaboraEnabled an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-23 17:46:30 +01:00
Pablo Zmdl
2c7f32c4d4 Make isOnlyofficeEnabled an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-23 17:46:30 +01:00
Pablo Zmdl
1013cb02fd Make isClamavEnabled an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-23 17:46:30 +01:00
Pablo Zmdl
e4fe52f694 Make instance_restore_attempt an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-23 17:46:30 +01:00
Pablo Zmdl
33fb191dfc Make isDockerSocketProxyEnabled an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-23 17:46:30 +01:00
Pablo Zmdl
af76dbaeeb Make backupMode an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-23 17:46:30 +01:00
Pablo Zmdl
419eede1c0 Make isWhiteboardEnabled an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-23 17:46:30 +01:00
Pablo Zmdl
a1bb53a400 Make restoreExcludePreviews an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-23 17:46:30 +01:00
Pablo Zmdl
0c20e2b2f9 Make selectedRestoreTime an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-23 17:46:30 +01:00
Pablo Zmdl
c608009981 Make install_latest_major an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-23 17:46:30 +01:00
Pablo Zmdl
68c508f281 Make AIO_URL an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-23 17:46:30 +01:00
Pablo Zmdl
8f02821866 Make wasStartButtonClicked an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-23 17:46:30 +01:00
Pablo Zmdl
1eadbe7e7e Make password an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-23 17:46:30 +01:00
Pablo Zmdl
681ec13b8d Make AIO_TOKEN an attribute
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-23 17:46:29 +01:00
Pablo Zmdl
85654218dd Adapt GetAndGenerateSecret() to get() and set()
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-23 17:46:29 +01:00
Pablo Zmdl
9be2c36a6b Adapt GetEnvironmentalVariableOrConfig() to get() and set()
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-23 17:46:29 +01:00
Pablo Zmdl
4b011369ae Cache config, introduce get() and set() helpers to guide new way to set attributes
Use cached config, use set() for single attributes, setMultiple to wrap
multiple calls to set()

Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-01-23 17:46:29 +01:00
Simon L.
be1199ace1
Merge pull request #7244 from nextcloud/enh/6690/follow-up
adjust `DeleteBorgBackupLocationVars` to also delete the `borg.config` file
2025-12-03 11:36:33 +01:00
Simon L.
d425bb226c
Merge pull request #7238 from nextcloud/enh/noid/refactor-backup-mode
refactor `backup-mode` handling
2025-12-03 11:35:02 +01:00
Simon L.
83de526051 adjust DeleteBorgBackupLocationVars to also delete the borg.config file
Signed-off-by: Simon L. <szaimen@e.mail.de>
2025-12-02 12:42:13 +01:00