From b4a380c1b2428e96bec23c7a437cd441966e3e1f Mon Sep 17 00:00:00 2001 From: Simon L Date: Wed, 24 Jan 2024 12:14:08 +0100 Subject: [PATCH] try to fix psalm Signed-off-by: Simon L --- php/domain-validator.php | 2 +- php/src/Data/ConfigurationManager.php | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/php/domain-validator.php b/php/domain-validator.php index a1e6487b..8f4fca11 100644 --- a/php/domain-validator.php +++ b/php/domain-validator.php @@ -8,7 +8,7 @@ if (strpos($domain, '.') === false) { http_response_code(400); } elseif (strpos($domain, ':') !== false) { http_response_code(400); -} elseif (!filter_var($domain, FILTER_VALIDATE_DOMAIN, FILTER_FLAG_HOSTNAME)) { +} elseif (!filter_var($domain, FILTER_VALIDATE_DOMAIN, FILTER_FLAG_HOSTNAME) === false) { http_response_code(400); } elseif (filter_var($domain, FILTER_VALIDATE_IP)) { http_response_code(400); diff --git a/php/src/Data/ConfigurationManager.php b/php/src/Data/ConfigurationManager.php index 51780b35..3b3cba5d 100644 --- a/php/src/Data/ConfigurationManager.php +++ b/php/src/Data/ConfigurationManager.php @@ -286,7 +286,7 @@ class ConfigurationManager } // Validate domain - if (!filter_var($domain, FILTER_VALIDATE_DOMAIN, FILTER_FLAG_HOSTNAME)) { + if (filter_var($domain, FILTER_VALIDATE_DOMAIN, FILTER_FLAG_HOSTNAME) === false) { throw new InvalidSettingConfigurationException("Domain is not a valid domain!"); } @@ -305,7 +305,7 @@ class ConfigurationManager if (empty($dnsRecordIP)) { $record = dns_get_record($domain, DNS_AAAA); - if (!empty($record)) { + if (!empty($record[0]['ipv6'])) { $dnsRecordIP = $record[0]['ipv6']; } }