From 5b8de658c7e55170e703e18ba1221262bd9ee21f Mon Sep 17 00:00:00 2001 From: szaimen Date: Wed, 9 Mar 2022 11:59:44 +0100 Subject: [PATCH] improve domain check Signed-off-by: szaimen --- php/src/Data/ConfigurationManager.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/php/src/Data/ConfigurationManager.php b/php/src/Data/ConfigurationManager.php index f98cab2b..ad34da4a 100644 --- a/php/src/Data/ConfigurationManager.php +++ b/php/src/Data/ConfigurationManager.php @@ -117,8 +117,8 @@ class ConfigurationManager * @throws InvalidSettingConfigurationException */ public function SetDomain(string $domain) : void { - // Validate URL - if (!filter_var('http://' . $domain, FILTER_VALIDATE_URL)) { + // Validate domain + if (!filter_var($domain, FILTER_VALIDATE_DOMAIN, FILTER_FLAG_HOSTNAME)) { throw new InvalidSettingConfigurationException("Domain is not in a valid format!"); } @@ -160,7 +160,7 @@ class ConfigurationManager $response = str_replace("\n", "", $response); if($response !== $instanceID) { - throw new InvalidSettingConfigurationException("Domain does not point to this server."); + throw new InvalidSettingConfigurationException("Domain does not point to this server or reverse proxy not configured correctly."); } // Write domain