Apply suggestions from code review

Co-authored-by: Simon L. <szaimen@e.mail.de>
Signed-off-by: Apoorv Parle <19315187+apparle@users.noreply.github.com>
This commit is contained in:
Apoorv Parle 2024-11-04 02:44:10 -08:00 committed by GitHub
parent 4ad749a265
commit 75c2407afa
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 6 additions and 6 deletions

View file

@ -850,7 +850,7 @@ readonly class DockerActionManager {
return;
}
if($createNetwork) {
if ($createNetwork) {
$url = $this->BuildApiUrl('networks/create');
try {
$this->guzzleClient->request(
@ -876,9 +876,9 @@ readonly class DockerActionManager {
$url = $this->BuildApiUrl(
sprintf('networks/%s/connect', $network)
);
$json_payload = [ 'Container' => $id ];
$jsonPayload = [ 'Container' => $id ];
if ($alias !== '' ) {
$json_payload['EndpointConfig'] = [ 'Aliases' => [ $alias ] ];
$jsonPayload['EndpointConfig'] = ['Aliases' => [ $alias ]];
}
try {
@ -886,7 +886,7 @@ readonly class DockerActionManager {
'POST',
$url,
[
'json' => $json_payload
'json' => $jsonPayload
]
);
} catch (RequestException $e) {
@ -921,7 +921,7 @@ readonly class DockerActionManager {
if ($container->GetIdentifier() === 'nextcloud-aio-apache' || $container->GetIdentifier() === 'nextcloud-aio-domaincheck') {
$apacheAdditionalNetwork = $this->configurationManager->GetApacheAdditionalNetwork();
if ($apacheAdditionalNetwork !== '') {
$this->ConnectContainerIdToNetwork($container->GetIdentifier(), $container->GetInternalPort(), $apacheAdditionalNetwork, false, alias: $alias);
$this->ConnectContainerIdToNetwork($container->GetIdentifier(), $container->GetInternalPort(), $apacheAdditionalNetwork, false, $alias);
}
}
}