eightball/all-in-one
1
0
Fork 0
mirror of https://github.com/nextcloud/all-in-one.git synced 2025-12-19 22:16:49 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

do not catch error during pullcontainer so that it throws and logs if it cannot get the image

Browse source 
Signed-off-by: Simon L <szaimen@e.mail.de>
This commit is contained in:
Simon L 2023-10-21 15:25:28 +02:00
parent c8c6bda76e
commit 6168ea3335
1 changed files with 2 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

10
php/src/Docker/DockerActionManager.php
View file

@ -577,14 +577,8 @@ class DockerActionManager
public function PullContainer(Container $container) : void public function PullContainer(Container $container) : void
{ {
$url = $this->BuildApiUrl(sprintf('images/create?fromImage=%s', urlencode($this->BuildImageName($container)))); $url = $this->BuildApiUrl(sprintf('images/create?fromImage=%s', urlencode($this->BuildImageName($container))));
try { // do not catch any exception so that it always throws and logs the error
$this->guzzleClient->post($url); $this->guzzleClient->post($url);
} catch (RequestException $e) {
error_log('Could not get image ' . $this->BuildImageName($container) . ' from docker hub. Probably due to rate limits. ' . $e->getMessage());
// Don't exit here because it is possible that the image is already present
// and we ran into docker hub limits.
// We will exit later if not image should be available.
}
} }
private function isContainerUpdateAvailable(string $id) : string private function isContainerUpdateAvailable(string $id) : string