From 544519994ac356c5f506f48e68e624216fe98049 Mon Sep 17 00:00:00 2001 From: "Simon L." Date: Thu, 4 Apr 2024 12:45:07 +0200 Subject: [PATCH 1/2] nextcloud - adjust TALK_HOST logic Signed-off-by: Simon L --- Containers/nextcloud/entrypoint.sh | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/Containers/nextcloud/entrypoint.sh b/Containers/nextcloud/entrypoint.sh index 0adc3fdc..50991106 100644 --- a/Containers/nextcloud/entrypoint.sh +++ b/Containers/nextcloud/entrypoint.sh @@ -623,6 +623,12 @@ fi # Talk if [ "$TALK_ENABLED" = 'yes' ]; then + set -x + if [ -z "$TALK_HOST" ] || echo "$TALK_HOST" | grep -q "nextcloud-.*-talk"; then + TALK_HOST="$NC_DOMAIN" + HPB_PATH="/standalone-signaling/" + fi + set +x if ! [ -d "/var/www/html/custom_apps/spreed" ]; then php /var/www/html/occ app:install spreed elif [ "$(php /var/www/html/occ config:app:get spreed enabled)" != "yes" ]; then @@ -632,15 +638,15 @@ if [ "$TALK_ENABLED" = 'yes' ]; then fi # Based on https://github.com/nextcloud/spreed/issues/960#issuecomment-416993435 if [ -z "$(php /var/www/html/occ talk:turn:list --output="plain")" ]; then - php /var/www/html/occ talk:turn:add turn "$NC_DOMAIN:$TALK_PORT" "udp,tcp" --secret="$TURN_SECRET" + php /var/www/html/occ talk:turn:add turn "$TALK_HOST:$TALK_PORT" "udp,tcp" --secret="$TURN_SECRET" fi STUN_SERVER="$(php /var/www/html/occ talk:stun:list --output="plain")" if [ -z "$STUN_SERVER" ] || echo "$STUN_SERVER" | grep -oP '[a-zA-Z.:0-9]+' | grep -q "^stun.nextcloud.com:443$"; then - php /var/www/html/occ talk:stun:add "$NC_DOMAIN:$TALK_PORT" + php /var/www/html/occ talk:stun:add "$TALK_HOST:$TALK_PORT" php /var/www/html/occ talk:stun:delete "stun.nextcloud.com:443" fi - if ! php /var/www/html/occ talk:signaling:list --output="plain" | grep -q "https://$NC_DOMAIN/standalone-signaling/"; then - php /var/www/html/occ talk:signaling:add "https://$NC_DOMAIN/standalone-signaling/" "$SIGNALING_SECRET" --verify + if ! php /var/www/html/occ talk:signaling:list --output="plain" | grep -q "https://$TALK_HOST$HPB_PATH"; then + php /var/www/html/occ talk:signaling:add "https://$TALK_HOST$HPB_PATH" "$SIGNALING_SECRET" --verify fi else if [ "$REMOVE_DISABLED_APPS" = yes ] && [ -d "/var/www/html/custom_apps/spreed" ]; then From dc4a08ef7807ea9e9f6afbf9a05348fa677b00cf Mon Sep 17 00:00:00 2001 From: "Simon L." Date: Thu, 4 Apr 2024 14:39:24 +0200 Subject: [PATCH 2/2] fix SC Signed-off-by: Simon L --- Containers/nextcloud/entrypoint.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/Containers/nextcloud/entrypoint.sh b/Containers/nextcloud/entrypoint.sh index 50991106..be057297 100644 --- a/Containers/nextcloud/entrypoint.sh +++ b/Containers/nextcloud/entrypoint.sh @@ -638,6 +638,7 @@ if [ "$TALK_ENABLED" = 'yes' ]; then fi # Based on https://github.com/nextcloud/spreed/issues/960#issuecomment-416993435 if [ -z "$(php /var/www/html/occ talk:turn:list --output="plain")" ]; then + # shellcheck disable=SC2153 php /var/www/html/occ talk:turn:add turn "$TALK_HOST:$TALK_PORT" "udp,tcp" --secret="$TURN_SECRET" fi STUN_SERVER="$(php /var/www/html/occ talk:stun:list --output="plain")"