feat: toggle submit button based on unsaved changes

Signed-off-by: ernolf <raphael.gradenwitz@googlemail.com>
This commit is contained in:
ernolf 2024-11-11 22:28:57 +01:00
parent 816921e2e2
commit 41c29b90a2
No known key found for this signature in database
GPG key ID: 0B145139A170715C
2 changed files with 180 additions and 107 deletions

View file

@ -1,73 +1,60 @@
function makeOptionsFormSubmitVisible() { document.addEventListener("DOMContentLoaded", function () {
let optionsFormSubmit = document.getElementById("options-form-submit"); // Hide submit button initially
optionsFormSubmit.style.display = 'block'; const optionsFormSubmit = document.getElementById("options-form-submit");
}
function handleTalkVisibility() {
let talk = document.getElementById("talk");
let talkRecording = document.getElementById("talk-recording")
if (talk.checked) {
talkRecording.disabled = false
} else {
talkRecording.checked = false
talkRecording.disabled = true
}
}
function handleDockerSocketProxyWarning() {
let dockerSocketProxy = document.getElementById("docker-socket-proxy");
if (dockerSocketProxy.checked) {
alert('⚠️ Warning! Enabling this container comes with possible Security problems since you are exposing the docker socket and all its privileges to the Nextcloud container. Enable this only if you are sure what you are doing!')
}
}
document.addEventListener("DOMContentLoaded", function(event) {
// handle submit button for options form
let optionsFormSubmit = document.getElementById("options-form-submit");
optionsFormSubmit.style.display = 'none'; optionsFormSubmit.style.display = 'none';
// Clamav // Store initial states for all checkboxes
let clamav = document.getElementById("clamav"); const initialState = {};
clamav.addEventListener('change', makeOptionsFormSubmitVisible); const checkboxes = document.querySelectorAll("#options-form input[type='checkbox']");
// OnlyOffice checkboxes.forEach(checkbox => {
let onlyoffice = document.getElementById("onlyoffice"); initialState[checkbox.id] = checkbox.checked; // Use checked property to capture actual initial state
if (onlyoffice) { });
onlyoffice.addEventListener('change', makeOptionsFormSubmitVisible);
// Function to compare current states to initial states
function checkForChanges() {
let hasChanges = false;
checkboxes.forEach(checkbox => {
if (checkbox.checked !== initialState[checkbox.id]) {
hasChanges = true;
}
});
// Show or hide submit button based on changes
optionsFormSubmit.style.display = hasChanges ? 'block' : 'none';
} }
// Collabora // Event listener to trigger visibility check on each change
let collabora = document.getElementById("collabora"); checkboxes.forEach(checkbox => {
collabora.addEventListener('change', makeOptionsFormSubmitVisible); checkbox.addEventListener("change", checkForChanges);
});
// Talk // Custom behaviors for specific options
let talk = document.getElementById("talk"); function handleTalkVisibility() {
talk.addEventListener('change', makeOptionsFormSubmitVisible); const talkRecording = document.getElementById("talk-recording");
talk.addEventListener('change', handleTalkVisibility); if (document.getElementById("talk").checked) {
talkRecording.disabled = false;
// Talk-recording } else {
let talkRecording = document.getElementById("talk-recording"); talkRecording.checked = false;
talkRecording.addEventListener('change', makeOptionsFormSubmitVisible); talkRecording.disabled = true;
if (!talk.checked) { }
talkRecording.disabled = true checkForChanges(); // Check changes after toggling Talk Recording
} }
// Imaginary function handleDockerSocketProxyWarning() {
let imaginary = document.getElementById("imaginary"); if (document.getElementById("docker-socket-proxy").checked) {
imaginary.addEventListener('change', makeOptionsFormSubmitVisible); alert('⚠️ Warning! Enabling this container comes with possible Security problems since you are exposing the docker socket and all its privileges to the Nextcloud container. Enable this only if you are sure what you are doing!');
}
// Fulltextsearch
let fulltextsearch = document.getElementById("fulltextsearch");
fulltextsearch.addEventListener('change', makeOptionsFormSubmitVisible);
// Docker socket proxy
let dockerSocketProxy = document.getElementById("docker-socket-proxy");
if (dockerSocketProxy) {
dockerSocketProxy.addEventListener('change', makeOptionsFormSubmitVisible);
// dockerSocketProxy.addEventListener('change', handleDockerSocketProxyWarning);
} }
// Whiteboard // Initialize event listeners for specific behaviors
let whiteboard = document.getElementById("whiteboard"); document.getElementById("talk").addEventListener('change', handleTalkVisibility);
whiteboard.addEventListener('change', makeOptionsFormSubmitVisible); document.getElementById("docker-socket-proxy").addEventListener('change', handleDockerSocketProxyWarning);
// Initialize talk-recording visibility on page load
handleTalkVisibility(); // Ensure talk-recording is correctly initialized
// Initial call to check for changes
checkForChanges();
}); });

View file

@ -9,51 +9,137 @@
<input type="hidden" name="{{csrf.keys.name}}" value="{{csrf.name}}"> <input type="hidden" name="{{csrf.keys.name}}" value="{{csrf.name}}">
<input type="hidden" name="{{csrf.keys.value}}" value="{{csrf.value}}"> <input type="hidden" name="{{csrf.keys.value}}" value="{{csrf.value}}">
<input type="hidden" name="options-form" value="options-form"> <input type="hidden" name="options-form" value="options-form">
{% if is_clamav_enabled == true %} <p>
<p><input type="checkbox" id="clamav" name="clamav" checked="checked"><label for="clamav">ClamAV (Antivirus backend for Nextcloud, only supported on x64, needs ~1GB additional RAM)</label></p> <input
{% else %} type="checkbox"
<p><input type="checkbox" id="clamav" name="clamav"><label for="clamav">ClamAV (Antivirus backend for Nextcloud, only supported on x64, needs ~1GB additional RAM)</label></p> id="clamav"
{% endif %} name="clamav"
{% if is_collabora_enabled == true %} {% if is_clamav_enabled == true %}
<p><input type="checkbox" id="collabora" name="collabora" checked="checked"><label for="collabora">Collabora (Nextcloud Office)</label></p> checked="checked"
{% else %} data-initial-state="true"
<p><input type="checkbox" id="collabora" name="collabora"><label for="collabora">Collabora (Nextcloud Office)</label></p> {% else %}
{% endif %} data-initial-state="false"
{% if is_fulltextsearch_enabled == true %} {% endif %}
<p><input type="checkbox" id="fulltextsearch" name="fulltextsearch" checked="checked"><label for="fulltextsearch">Fulltextsearch (needs ~1GB additional RAM)</label></p> >
{% else %} <label for="clamav">ClamAV (Antivirus backend for Nextcloud, only supported on x64, needs ~1GB additional RAM)</label>
<p><input type="checkbox" id="fulltextsearch" name="fulltextsearch"><label for="fulltextsearch">Fulltextsearch (needs ~1GB additional RAM. <strong>Please note:</strong> the initial indexing can take a long time during which Nextcloud will be unavailable)</label></p> </p>
{% endif %} <p>
{% if is_imaginary_enabled == true %} <input
<p><input type="checkbox" id="imaginary" name="imaginary" checked="checked"><label for="imaginary">Imaginary (for previews of heic, heif, illustrator, pdf, svg, tiff and webp. Imaginary is currently <a href="https://github.com/nextcloud/server/issues/34262">incompatible with server-side-encryption</a>)</label></p> type="checkbox"
{% else %} id="collabora"
<p><input type="checkbox" id="imaginary" name="imaginary"><label for="imaginary">Imaginary (for previews of heic, heif, illustrator, pdf, svg, tiff and webp. Imaginary is currently <a href="https://github.com/nextcloud/server/issues/34262">incompatible with server-side-encryption</a>)</label></p> name="collabora"
{% endif %} {% if is_collabora_enabled == true %}
{% if is_talk_enabled == true %} checked="checked"
<p><input type="checkbox" id="talk" name="talk" checked="checked"><label for="talk">Nextcloud Talk (needs ports {{ talk_port }}/TCP and {{ talk_port }}/UDP open/forwarded in your firewall/router)</label></p> data-initial-state="true"
{% else %} {% else %}
<p><input type="checkbox" id="talk" name="talk"><label for="talk">Nextcloud Talk (needs ports {{ talk_port }}/TCP and {{ talk_port }}/UDP open/forwarded in your firewall/router)</label></p> data-initial-state="false"
{% endif %} {% endif %}
{% if is_talk_recording_enabled == true %} >
<p><input type="checkbox" id="talk-recording" name="talk-recording" checked="checked"><label for="talk-recording">Nextcloud Talk Recording-server (needs Nextcloud Talk being enabled and ~1GB additional RAM and ~2 additional vCPUs)</label></p> <label for="collabora">Collabora (Nextcloud Office)</label>
{% else %} </p>
<p><input type="checkbox" id="talk-recording" name="talk-recording"><label for="talk-recording">Nextcloud Talk Recording-server (needs Nextcloud Talk being enabled and ~1GB additional RAM ~2 additional vCPUs)</label></p> <p>
{% endif %} <input
{% if is_onlyoffice_enabled == true %} type="checkbox"
<p><input type="checkbox" id="onlyoffice" name="onlyoffice" checked="checked"><label for="onlyoffice">OnlyOffice</label></p> id="fulltextsearch"
{% else %} name="fulltextsearch"
{#<p><input type="checkbox" id="onlyoffice" name="onlyoffice"><label for="onlyoffice">OnlyOffice</label></p>#} {% if is_fulltextsearch_enabled == true %}
{% endif %} checked="checked"
{% if is_docker_socket_proxy_enabled == true %} data-initial-state="true"
<p><input type="checkbox" id="docker-socket-proxy" name="docker-socket-proxy" checked="checked"><label for="docker-socket-proxy">Docker Socket Proxy (needed for <a href="https://github.com/cloud-py-api/app_api#nextcloud-appapi">Nextcloud App API</a>)</label></p> {% else %}
{% else %} data-initial-state="false"
<p><input type="checkbox" id="docker-socket-proxy" name="docker-socket-proxy"><label for="docker-socket-proxy">Docker Socket Proxy (needed for <a href="https://github.com/cloud-py-api/app_api#nextcloud-appapi">Nextcloud App API</a>)</label></p> {% endif %}
{% endif %} >
{% if is_whiteboard_enabled == true %} <label for="fulltextsearch">
<p><input type="checkbox" id="whiteboard" name="whiteboard" checked="checked"><label for="whiteboard">Whiteboard</label></p> Fulltextsearch (needs ~1GB additional RAM)
{% else %} {% if is_fulltextsearch_enabled == false %}
<p><input type="checkbox" id="whiteboard" name="whiteboard"><label for="whiteboard">Whiteboard</label></p> . <strong>Please note:</strong> the initial indexing can take a long time during which Nextcloud will be unavailable
{% endif %} {% endif %}
</label>
</p>
<p>
<input
type="checkbox"
id="imaginary"
name="imaginary"
{% if is_imaginary_enabled == true %}
checked="checked"
data-initial-state="true"
{% else %}
data-initial-state="false"
{% endif %}
>
<label for="imaginary">Imaginary (for previews of heic, heif, illustrator, pdf, svg, tiff and webp. Imaginary is currently <a href="https://github.com/nextcloud/server/issues/34262">incompatible with server-side-encryption</a>)</label>
</p>
<p>
<input
type="checkbox"
id="talk"
name="talk"
{% if is_talk_enabled == true %}
checked="checked"
data-initial-state="true"
{% else %}
data-initial-state="false"
{% endif %}
>
<label for="talk">Nextcloud Talk (needs ports {{ talk_port }}/TCP and {{ talk_port }}/UDP open/forwarded in your firewall/router)</label>
</p>
<p>
<input
type="checkbox"
id="talk-recording"
name="talk-recording"
{% if is_talk_recording_enabled == true %}
checked="checked"
data-initial-state="true"
{% else %}
data-initial-state="false"
{% endif %}
>
<label for="talk-recording">Nextcloud Talk Recording-server (needs Nextcloud Talk being enabled and ~1GB additional RAM and ~2 additional vCPUs)</label>
</p>
<p>
<input
type="checkbox"
id="onlyoffice"
name="onlyoffice"
{% if is_onlyoffice_enabled == true %}
checked="checked"
data-initial-state="true"
{% else %}
data-initial-state="false"
{% endif %}
>
<label for="onlyoffice">OnlyOffice</label>
</p>
<p>
<input
type="checkbox"
id="docker-socket-proxy"
name="docker-socket-proxy"
{% if is_docker_socket_proxy_enabled == true %}
checked="checked"
data-initial-state="true"
{% else %}
data-initial-state="false"
{% endif %}
>
<label for="docker-socket-proxy">Docker Socket Proxy (needed for <a href="https://github.com/cloud-py-api/app_api#nextcloud-appapi">Nextcloud App API</a>)</label>
</p>
<p>
<input
type="checkbox"
id="whiteboard"
name="whiteboard"
{% if is_whiteboard_enabled == true %}
checked="checked"
data-initial-state="true"
{% else %}
data-initial-state="false"
{% endif %}
>
<label for="whiteboard">Whiteboard</label>
</p>
<input id="options-form-submit" type="submit" value="Save changes" /> <input id="options-form-submit" type="submit" value="Save changes" />
<script type="text/javascript" src="options-form-submit.js?v2"></script> <script type="text/javascript" src="options-form-submit.js?v2"></script>
</form> </form>