eightball/all-in-one
1
0
Fork 0
mirror of https://github.com/nextcloud/all-in-one.git synced 2025-12-19 22:16:49 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

Merge pull request #6222 from nextcloud/enh/noid/rename-function

Browse source 
aio-interface: rename `isDockerHubReachable` to `isRegistryReachable`
This commit is contained in:
Simon L. 2025-03-31 10:51:11 +02:00 • committed by GitHub
commit 266254a226
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
php/src/Controller/DockerController.php
View file

@ -41,12 +41,12 @@ readonly class DockerController {
}
}
// Check if docker hub is reachable in order to make sure that we do not try to pull an image if it is down
// Check if registry is reachable in order to make sure that we do not try to pull an image if it is down
// and try to mitigate issues that are arising due to that
if ($pullImage) {
if (!$this->dockerActionManager->isDockerHubReachable($container)) {
if (!$this->dockerActionManager->isRegistryReachable($container)) {
$pullImage = false;
error_log('Not pulling the ' . $container->GetContainerName() . ' image for the ' . $container->GetIdentifier() . ' container because docker hub does not seem to be reachable.');
error_log('Not pulling the ' . $container->GetContainerName() . ' image for the ' . $container->GetIdentifier() . ' container because the registry does not seem to be reachable.');
}
}

2
php/src/Docker/DockerActionManager.php
View file

@ -599,7 +599,7 @@ readonly class DockerActionManager {
}
public function isDockerHubReachable(Container $container): bool {
public function isRegistryReachable(Container $container): bool {
$tag = $container->GetImageTag();
if ($tag === '%AIO_CHANNEL%') {
$tag = $this->GetCurrentChannel();