From 3c4644f3cccf5ba30e0e9314c5fc00ef1f826b8c Mon Sep 17 00:00:00 2001 From: asleepyskye Date: Mon, 11 Aug 2025 21:28:22 -0400 Subject: [PATCH 01/40] chore(bot): revert temp fix (407e0ce) + update watson --- PluralKit.Bot/PluralKit.Bot.csproj | 2 +- PluralKit.Bot/Services/HttpListenerService.cs | 40 +------------------ PluralKit.Bot/packages.lock.json | 18 ++++----- PluralKit.Tests/packages.lock.json | 18 ++++----- 4 files changed, 21 insertions(+), 57 deletions(-) diff --git a/PluralKit.Bot/PluralKit.Bot.csproj b/PluralKit.Bot/PluralKit.Bot.csproj index 753d1f30..152d736a 100644 --- a/PluralKit.Bot/PluralKit.Bot.csproj +++ b/PluralKit.Bot/PluralKit.Bot.csproj @@ -24,6 +24,6 @@ - + diff --git a/PluralKit.Bot/Services/HttpListenerService.cs b/PluralKit.Bot/Services/HttpListenerService.cs index bafeae41..d2bfc4ce 100644 --- a/PluralKit.Bot/Services/HttpListenerService.cs +++ b/PluralKit.Bot/Services/HttpListenerService.cs @@ -1,4 +1,3 @@ -using System.Text; using System.Text.Json; using Serilog; @@ -58,7 +57,7 @@ public class HttpListenerService private async Task RuntimeConfigSet(HttpContextBase ctx) { var key = ctx.Request.Url.Parameters["key"]; - var value = ReadStream(ctx.Request.Data, ctx.Request.ContentLength); + var value = ctx.Request.DataAsString; await _runtimeConfig.Set(key, value); await RuntimeConfigGet(ctx); } @@ -77,7 +76,7 @@ public class HttpListenerService var shardIdString = ctx.Request.Url.Parameters["shard_id"]; if (!int.TryParse(shardIdString, out var shardId)) return; - var packet = JsonSerializer.Deserialize(ReadStream(ctx.Request.Data, ctx.Request.ContentLength), _jsonSerializerOptions); + var packet = JsonSerializer.Deserialize(ctx.Request.DataAsString, _jsonSerializerOptions); var evt = DeserializeEvent(shardId, packet.EventType!, (JsonElement)packet.Payload!); if (evt != null) { @@ -108,39 +107,4 @@ public class HttpListenerService return null; } } - - //temporary re-implementation of the ReadStream function found in WatsonWebserver.Lite, but with handling for closed connections - //https://github.com/dotnet/WatsonWebserver/issues/171 - private static string ReadStream(Stream input, long contentLength) - { - if (input == null) throw new ArgumentNullException(nameof(input)); - if (!input.CanRead) throw new InvalidOperationException("Input stream is not readable"); - if (contentLength < 1) return ""; - - byte[] buffer = new byte[65536]; - long bytesRemaining = contentLength; - - using (MemoryStream ms = new MemoryStream()) - { - int read; - - while (bytesRemaining > 0) - { - read = input.Read(buffer, 0, buffer.Length); - if (read > 0) - { - ms.Write(buffer, 0, read); - bytesRemaining -= read; - } - else - { - throw new IOException("Connection closed before reading end of stream."); - } - } - - if (ms.Length < 1) return null; - var str = Encoding.Default.GetString(ms.ToArray()); - return str; - } - } } \ No newline at end of file diff --git a/PluralKit.Bot/packages.lock.json b/PluralKit.Bot/packages.lock.json index 449923d9..25e461cf 100644 --- a/PluralKit.Bot/packages.lock.json +++ b/PluralKit.Bot/packages.lock.json @@ -16,12 +16,12 @@ }, "Watson.Lite": { "type": "Direct", - "requested": "[6.3.5, )", - "resolved": "6.3.5", - "contentHash": "YF8+se3IVenn8YlyNeb4wSJK6QMnVD0QHIOEiZ22wS4K2wkwoSDzWS+ZAjk1MaPeB+XO5gRoENUN//pOc+wI2g==", + "requested": "[6.3.12, )", + "resolved": "6.3.12", + "contentHash": "L/TfJadyOwK9bhhvOnEKXLeyDaTAn8v6hnYPVPIwQ7JlnUXDbDqsUa3qHFdFIHiuK8vMZOnDL7+k/mY10yxdYw==", "dependencies": { - "CavemanTcp": "2.0.5", - "Watson.Core": "6.3.5" + "CavemanTcp": "2.0.9", + "Watson.Core": "6.3.12" } }, "App.Metrics": { @@ -119,8 +119,8 @@ }, "CavemanTcp": { "type": "Transitive", - "resolved": "2.0.5", - "contentHash": "90wywmGpjrj26HMAkufYZwuZI8sVYB1mRwEdqugSR3kgDnPX+3l0jO86gwtFKsPvsEpsS4Dn/1EbhguzUxMU8Q==" + "resolved": "2.0.9", + "contentHash": "KgIwYhPhGkBTm+wwVAmWonkKPw4xYVnutzzlIeqOLcX1fti+8d+MEGTvbern1smf3S/UpjFjihkf6XRziTddzQ==" }, "Dapper": { "type": "Transitive", @@ -746,8 +746,8 @@ }, "Watson.Core": { "type": "Transitive", - "resolved": "6.3.5", - "contentHash": "Y5YxKOCSLe2KDmfwvI/J0qApgmmZR77LwyoufRVfKH7GLdHiE7fY0IfoNxWTG7nNv8knBfgwyOxdehRm+4HaCg==", + "resolved": "6.3.12", + "contentHash": "lCWv+7rz++z/1ceu+aBdJYw+nO7u/dgXxVYrmdUO/3ylFeEbbPQP19MYjOJbhSQY4+bmQRex79YJ1IneLZhprA==", "dependencies": { "IpMatcher": "1.0.5", "RegexMatcher": "1.0.9", diff --git a/PluralKit.Tests/packages.lock.json b/PluralKit.Tests/packages.lock.json index ce0dbc15..bffeb33d 100644 --- a/PluralKit.Tests/packages.lock.json +++ b/PluralKit.Tests/packages.lock.json @@ -130,8 +130,8 @@ }, "CavemanTcp": { "type": "Transitive", - "resolved": "2.0.5", - "contentHash": "90wywmGpjrj26HMAkufYZwuZI8sVYB1mRwEdqugSR3kgDnPX+3l0jO86gwtFKsPvsEpsS4Dn/1EbhguzUxMU8Q==" + "resolved": "2.0.9", + "contentHash": "KgIwYhPhGkBTm+wwVAmWonkKPw4xYVnutzzlIeqOLcX1fti+8d+MEGTvbern1smf3S/UpjFjihkf6XRziTddzQ==" }, "Dapper": { "type": "Transitive", @@ -912,8 +912,8 @@ }, "Watson.Core": { "type": "Transitive", - "resolved": "6.3.5", - "contentHash": "Y5YxKOCSLe2KDmfwvI/J0qApgmmZR77LwyoufRVfKH7GLdHiE7fY0IfoNxWTG7nNv8knBfgwyOxdehRm+4HaCg==", + "resolved": "6.3.12", + "contentHash": "lCWv+7rz++z/1ceu+aBdJYw+nO7u/dgXxVYrmdUO/3ylFeEbbPQP19MYjOJbhSQY4+bmQRex79YJ1IneLZhprA==", "dependencies": { "IpMatcher": "1.0.5", "RegexMatcher": "1.0.9", @@ -924,11 +924,11 @@ }, "Watson.Lite": { "type": "Transitive", - "resolved": "6.3.5", - "contentHash": "YF8+se3IVenn8YlyNeb4wSJK6QMnVD0QHIOEiZ22wS4K2wkwoSDzWS+ZAjk1MaPeB+XO5gRoENUN//pOc+wI2g==", + "resolved": "6.3.12", + "contentHash": "L/TfJadyOwK9bhhvOnEKXLeyDaTAn8v6hnYPVPIwQ7JlnUXDbDqsUa3qHFdFIHiuK8vMZOnDL7+k/mY10yxdYw==", "dependencies": { - "CavemanTcp": "2.0.5", - "Watson.Core": "6.3.5" + "CavemanTcp": "2.0.9", + "Watson.Core": "6.3.12" } }, "xunit.abstractions": { @@ -1001,7 +1001,7 @@ "Myriad": "[1.0.0, )", "PluralKit.Core": "[1.0.0, )", "Sentry": "[4.13.0, )", - "Watson.Lite": "[6.3.5, )" + "Watson.Lite": "[6.3.12, )" } }, "pluralkit.core": { From ae9d818f4b7627ada58fc93ae38bfb40e95a2df8 Mon Sep 17 00:00:00 2001 From: asleepyskye Date: Fri, 15 Aug 2025 13:40:55 -0400 Subject: [PATCH 02/40] fix(nix): add migrations --- crates/migrate/build.rs | 3 ++- flake.nix | 16 ++++++++++++++++ 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/crates/migrate/build.rs b/crates/migrate/build.rs index 80829b0d..eaaa156c 100644 --- a/crates/migrate/build.rs +++ b/crates/migrate/build.rs @@ -8,10 +8,11 @@ use std::{ fn main() -> Result<(), Box> { let out_dir = env::var("OUT_DIR")?; + let manifest_dir = env::var("CARGO_MANIFEST_DIR")?; let dest_path = Path::new(&out_dir).join("data.rs"); let mut datafile = File::create(&dest_path)?; - let prefix = "../../../../../../crates/migrate/data"; + let prefix = manifest_dir + "/data"; let ct = fs::read_dir("data/migrations")? .filter(|p| { diff --git a/flake.nix b/flake.nix index cbe6b013..8fd2ed6b 100644 --- a/flake.nix +++ b/flake.nix @@ -195,6 +195,22 @@ # TODO: add liveness check ready_log_line = "Received Ready"; }; + ### migrations ### + pluralkit-migrate-init = mkServiceInitProcess { + name = "migrate"; + }; + pluralkit-migrate = { + command = pkgs.writeShellApplication { + name = "pluralkit-migrate"; + text = '' + ${sourceDotenv} + set -x + exec target/debug/migrate + ''; + }; + depends_on.postgres.condition = "process_healthy"; + depends_on.pluralkit-migrate-init.condition = "process_completed_successfully"; + }; ### gateway ### pluralkit-gateway-init = mkServiceInitProcess { name = "gateway"; From 621889a6c25dee96fe911e7d2d381536242f9302 Mon Sep 17 00:00:00 2001 From: asleepyskye Date: Fri, 15 Aug 2025 16:48:22 -0400 Subject: [PATCH 03/40] fix(gateway): use try_send for events --- crates/gateway/src/discord/gateway.rs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/crates/gateway/src/discord/gateway.rs b/crates/gateway/src/discord/gateway.rs index 92acdeaa..6d16bfd1 100644 --- a/crates/gateway/src/discord/gateway.rs +++ b/crates/gateway/src/discord/gateway.rs @@ -227,7 +227,9 @@ pub async fn runner( } if runtime_config.exists(RUNTIME_CONFIG_KEY_EVENT_TARGET).await { - tx.send((shard.id(), event, raw_event)).await.unwrap(); + if let Err(error) = tx.try_send((shard.id(), event, raw_event)) { + tracing::error!(?error, "error sending shard event"); + } } } } From 93659f120535792ad19550b09a01d62839544ba8 Mon Sep 17 00:00:00 2001 From: alyssa Date: Tue, 19 Aug 2025 21:14:58 +0000 Subject: [PATCH 04/40] chore: relicense Myriad library to MIT, add license text --- COPYING | 619 +++++++++++++++++++++++++++++++++++++++++++++++ Myriad/COPYING | 20 ++ Myriad/README.md | 4 +- README.md | 4 +- 4 files changed, 645 insertions(+), 2 deletions(-) create mode 100644 COPYING create mode 100644 Myriad/COPYING diff --git a/COPYING b/COPYING new file mode 100644 index 00000000..ca9b0551 --- /dev/null +++ b/COPYING @@ -0,0 +1,619 @@ + GNU AFFERO GENERAL PUBLIC LICENSE + Version 3, 19 November 2007 + + Copyright (C) 2007 Free Software Foundation, Inc. + Everyone is permitted to copy and distribute verbatim copies + of this license document, but changing it is not allowed. + + Preamble + + The GNU Affero General Public License is a free, copyleft license for +software and other kinds of works, specifically designed to ensure +cooperation with the community in the case of network server software. + + The licenses for most software and other practical works are designed +to take away your freedom to share and change the works. By contrast, +our General Public Licenses are intended to guarantee your freedom to +share and change all versions of a program--to make sure it remains free +software for all its users. + + When we speak of free software, we are referring to freedom, not +price. Our General Public Licenses are designed to make sure that you +have the freedom to distribute copies of free software (and charge for +them if you wish), that you receive source code or can get it if you +want it, that you can change the software or use pieces of it in new +free programs, and that you know you can do these things. + + Developers that use our General Public Licenses protect your rights +with two steps: (1) assert copyright on the software, and (2) offer +you this License which gives you legal permission to copy, distribute +and/or modify the software. + + A secondary benefit of defending all users' freedom is that +improvements made in alternate versions of the program, if they +receive widespread use, become available for other developers to +incorporate. Many developers of free software are heartened and +encouraged by the resulting cooperation. However, in the case of +software used on network servers, this result may fail to come about. +The GNU General Public License permits making a modified version and +letting the public access it on a server without ever releasing its +source code to the public. + + The GNU Affero General Public License is designed specifically to +ensure that, in such cases, the modified source code becomes available +to the community. It requires the operator of a network server to +provide the source code of the modified version running there to the +users of that server. Therefore, public use of a modified version, on +a publicly accessible server, gives the public access to the source +code of the modified version. + + An older license, called the Affero General Public License and +published by Affero, was designed to accomplish similar goals. This is +a different license, not a version of the Affero GPL, but Affero has +released a new version of the Affero GPL which permits relicensing under +this license. + + The precise terms and conditions for copying, distribution and +modification follow. + + TERMS AND CONDITIONS + + 0. Definitions. + + "This License" refers to version 3 of the GNU Affero General Public License. + + "Copyright" also means copyright-like laws that apply to other kinds of +works, such as semiconductor masks. + + "The Program" refers to any copyrightable work licensed under this +License. Each licensee is addressed as "you". "Licensees" and +"recipients" may be individuals or organizations. + + To "modify" a work means to copy from or adapt all or part of the work +in a fashion requiring copyright permission, other than the making of an +exact copy. The resulting work is called a "modified version" of the +earlier work or a work "based on" the earlier work. + + A "covered work" means either the unmodified Program or a work based +on the Program. + + To "propagate" a work means to do anything with it that, without +permission, would make you directly or secondarily liable for +infringement under applicable copyright law, except executing it on a +computer or modifying a private copy. Propagation includes copying, +distribution (with or without modification), making available to the +public, and in some countries other activities as well. + + To "convey" a work means any kind of propagation that enables other +parties to make or receive copies. Mere interaction with a user through +a computer network, with no transfer of a copy, is not conveying. + + An interactive user interface displays "Appropriate Legal Notices" +to the extent that it includes a convenient and prominently visible +feature that (1) displays an appropriate copyright notice, and (2) +tells the user that there is no warranty for the work (except to the +extent that warranties are provided), that licensees may convey the +work under this License, and how to view a copy of this License. If +the interface presents a list of user commands or options, such as a +menu, a prominent item in the list meets this criterion. + + 1. Source Code. + + The "source code" for a work means the preferred form of the work +for making modifications to it. "Object code" means any non-source +form of a work. + + A "Standard Interface" means an interface that either is an official +standard defined by a recognized standards body, or, in the case of +interfaces specified for a particular programming language, one that +is widely used among developers working in that language. + + The "System Libraries" of an executable work include anything, other +than the work as a whole, that (a) is included in the normal form of +packaging a Major Component, but which is not part of that Major +Component, and (b) serves only to enable use of the work with that +Major Component, or to implement a Standard Interface for which an +implementation is available to the public in source code form. A +"Major Component", in this context, means a major essential component +(kernel, window system, and so on) of the specific operating system +(if any) on which the executable work runs, or a compiler used to +produce the work, or an object code interpreter used to run it. + + The "Corresponding Source" for a work in object code form means all +the source code needed to generate, install, and (for an executable +work) run the object code and to modify the work, including scripts to +control those activities. However, it does not include the work's +System Libraries, or general-purpose tools or generally available free +programs which are used unmodified in performing those activities but +which are not part of the work. For example, Corresponding Source +includes interface definition files associated with source files for +the work, and the source code for shared libraries and dynamically +linked subprograms that the work is specifically designed to require, +such as by intimate data communication or control flow between those +subprograms and other parts of the work. + + The Corresponding Source need not include anything that users +can regenerate automatically from other parts of the Corresponding +Source. + + The Corresponding Source for a work in source code form is that +same work. + + 2. Basic Permissions. + + All rights granted under this License are granted for the term of +copyright on the Program, and are irrevocable provided the stated +conditions are met. This License explicitly affirms your unlimited +permission to run the unmodified Program. The output from running a +covered work is covered by this License only if the output, given its +content, constitutes a covered work. This License acknowledges your +rights of fair use or other equivalent, as provided by copyright law. + + You may make, run and propagate covered works that you do not +convey, without conditions so long as your license otherwise remains +in force. You may convey covered works to others for the sole purpose +of having them make modifications exclusively for you, or provide you +with facilities for running those works, provided that you comply with +the terms of this License in conveying all material for which you do +not control copyright. Those thus making or running the covered works +for you must do so exclusively on your behalf, under your direction +and control, on terms that prohibit them from making any copies of +your copyrighted material outside their relationship with you. + + Conveying under any other circumstances is permitted solely under +the conditions stated below. Sublicensing is not allowed; section 10 +makes it unnecessary. + + 3. Protecting Users' Legal Rights From Anti-Circumvention Law. + + No covered work shall be deemed part of an effective technological +measure under any applicable law fulfilling obligations under article +11 of the WIPO copyright treaty adopted on 20 December 1996, or +similar laws prohibiting or restricting circumvention of such +measures. + + When you convey a covered work, you waive any legal power to forbid +circumvention of technological measures to the extent such circumvention +is effected by exercising rights under this License with respect to +the covered work, and you disclaim any intention to limit operation or +modification of the work as a means of enforcing, against the work's +users, your or third parties' legal rights to forbid circumvention of +technological measures. + + 4. Conveying Verbatim Copies. + + You may convey verbatim copies of the Program's source code as you +receive it, in any medium, provided that you conspicuously and +appropriately publish on each copy an appropriate copyright notice; +keep intact all notices stating that this License and any +non-permissive terms added in accord with section 7 apply to the code; +keep intact all notices of the absence of any warranty; and give all +recipients a copy of this License along with the Program. + + You may charge any price or no price for each copy that you convey, +and you may offer support or warranty protection for a fee. + + 5. Conveying Modified Source Versions. + + You may convey a work based on the Program, or the modifications to +produce it from the Program, in the form of source code under the +terms of section 4, provided that you also meet all of these conditions: + + a) The work must carry prominent notices stating that you modified + it, and giving a relevant date. + + b) The work must carry prominent notices stating that it is + released under this License and any conditions added under section + 7. This requirement modifies the requirement in section 4 to + "keep intact all notices". + + c) You must license the entire work, as a whole, under this + License to anyone who comes into possession of a copy. This + License will therefore apply, along with any applicable section 7 + additional terms, to the whole of the work, and all its parts, + regardless of how they are packaged. This License gives no + permission to license the work in any other way, but it does not + invalidate such permission if you have separately received it. + + d) If the work has interactive user interfaces, each must display + Appropriate Legal Notices; however, if the Program has interactive + interfaces that do not display Appropriate Legal Notices, your + work need not make them do so. + + A compilation of a covered work with other separate and independent +works, which are not by their nature extensions of the covered work, +and which are not combined with it such as to form a larger program, +in or on a volume of a storage or distribution medium, is called an +"aggregate" if the compilation and its resulting copyright are not +used to limit the access or legal rights of the compilation's users +beyond what the individual works permit. Inclusion of a covered work +in an aggregate does not cause this License to apply to the other +parts of the aggregate. + + 6. Conveying Non-Source Forms. + + You may convey a covered work in object code form under the terms +of sections 4 and 5, provided that you also convey the +machine-readable Corresponding Source under the terms of this License, +in one of these ways: + + a) Convey the object code in, or embodied in, a physical product + (including a physical distribution medium), accompanied by the + Corresponding Source fixed on a durable physical medium + customarily used for software interchange. + + b) Convey the object code in, or embodied in, a physical product + (including a physical distribution medium), accompanied by a + written offer, valid for at least three years and valid for as + long as you offer spare parts or customer support for that product + model, to give anyone who possesses the object code either (1) a + copy of the Corresponding Source for all the software in the + product that is covered by this License, on a durable physical + medium customarily used for software interchange, for a price no + more than your reasonable cost of physically performing this + conveying of source, or (2) access to copy the + Corresponding Source from a network server at no charge. + + c) Convey individual copies of the object code with a copy of the + written offer to provide the Corresponding Source. This + alternative is allowed only occasionally and noncommercially, and + only if you received the object code with such an offer, in accord + with subsection 6b. + + d) Convey the object code by offering access from a designated + place (gratis or for a charge), and offer equivalent access to the + Corresponding Source in the same way through the same place at no + further charge. You need not require recipients to copy the + Corresponding Source along with the object code. If the place to + copy the object code is a network server, the Corresponding Source + may be on a different server (operated by you or a third party) + that supports equivalent copying facilities, provided you maintain + clear directions next to the object code saying where to find the + Corresponding Source. Regardless of what server hosts the + Corresponding Source, you remain obligated to ensure that it is + available for as long as needed to satisfy these requirements. + + e) Convey the object code using peer-to-peer transmission, provided + you inform other peers where the object code and Corresponding + Source of the work are being offered to the general public at no + charge under subsection 6d. + + A separable portion of the object code, whose source code is excluded +from the Corresponding Source as a System Library, need not be +included in conveying the object code work. + + A "User Product" is either (1) a "consumer product", which means any +tangible personal property which is normally used for personal, family, +or household purposes, or (2) anything designed or sold for incorporation +into a dwelling. In determining whether a product is a consumer product, +doubtful cases shall be resolved in favor of coverage. For a particular +product received by a particular user, "normally used" refers to a +typical or common use of that class of product, regardless of the status +of the particular user or of the way in which the particular user +actually uses, or expects or is expected to use, the product. A product +is a consumer product regardless of whether the product has substantial +commercial, industrial or non-consumer uses, unless such uses represent +the only significant mode of use of the product. + + "Installation Information" for a User Product means any methods, +procedures, authorization keys, or other information required to install +and execute modified versions of a covered work in that User Product from +a modified version of its Corresponding Source. The information must +suffice to ensure that the continued functioning of the modified object +code is in no case prevented or interfered with solely because +modification has been made. + + If you convey an object code work under this section in, or with, or +specifically for use in, a User Product, and the conveying occurs as +part of a transaction in which the right of possession and use of the +User Product is transferred to the recipient in perpetuity or for a +fixed term (regardless of how the transaction is characterized), the +Corresponding Source conveyed under this section must be accompanied +by the Installation Information. But this requirement does not apply +if neither you nor any third party retains the ability to install +modified object code on the User Product (for example, the work has +been installed in ROM). + + The requirement to provide Installation Information does not include a +requirement to continue to provide support service, warranty, or updates +for a work that has been modified or installed by the recipient, or for +the User Product in which it has been modified or installed. Access to a +network may be denied when the modification itself materially and +adversely affects the operation of the network or violates the rules and +protocols for communication across the network. + + Corresponding Source conveyed, and Installation Information provided, +in accord with this section must be in a format that is publicly +documented (and with an implementation available to the public in +source code form), and must require no special password or key for +unpacking, reading or copying. + + 7. Additional Terms. + + "Additional permissions" are terms that supplement the terms of this +License by making exceptions from one or more of its conditions. +Additional permissions that are applicable to the entire Program shall +be treated as though they were included in this License, to the extent +that they are valid under applicable law. If additional permissions +apply only to part of the Program, that part may be used separately +under those permissions, but the entire Program remains governed by +this License without regard to the additional permissions. + + When you convey a copy of a covered work, you may at your option +remove any additional permissions from that copy, or from any part of +it. (Additional permissions may be written to require their own +removal in certain cases when you modify the work.) You may place +additional permissions on material, added by you to a covered work, +for which you have or can give appropriate copyright permission. + + Notwithstanding any other provision of this License, for material you +add to a covered work, you may (if authorized by the copyright holders of +that material) supplement the terms of this License with terms: + + a) Disclaiming warranty or limiting liability differently from the + terms of sections 15 and 16 of this License; or + + b) Requiring preservation of specified reasonable legal notices or + author attributions in that material or in the Appropriate Legal + Notices displayed by works containing it; or + + c) Prohibiting misrepresentation of the origin of that material, or + requiring that modified versions of such material be marked in + reasonable ways as different from the original version; or + + d) Limiting the use for publicity purposes of names of licensors or + authors of the material; or + + e) Declining to grant rights under trademark law for use of some + trade names, trademarks, or service marks; or + + f) Requiring indemnification of licensors and authors of that + material by anyone who conveys the material (or modified versions of + it) with contractual assumptions of liability to the recipient, for + any liability that these contractual assumptions directly impose on + those licensors and authors. + + All other non-permissive additional terms are considered "further +restrictions" within the meaning of section 10. If the Program as you +received it, or any part of it, contains a notice stating that it is +governed by this License along with a term that is a further +restriction, you may remove that term. If a license document contains +a further restriction but permits relicensing or conveying under this +License, you may add to a covered work material governed by the terms +of that license document, provided that the further restriction does +not survive such relicensing or conveying. + + If you add terms to a covered work in accord with this section, you +must place, in the relevant source files, a statement of the +additional terms that apply to those files, or a notice indicating +where to find the applicable terms. + + Additional terms, permissive or non-permissive, may be stated in the +form of a separately written license, or stated as exceptions; +the above requirements apply either way. + + 8. Termination. + + You may not propagate or modify a covered work except as expressly +provided under this License. Any attempt otherwise to propagate or +modify it is void, and will automatically terminate your rights under +this License (including any patent licenses granted under the third +paragraph of section 11). + + However, if you cease all violation of this License, then your +license from a particular copyright holder is reinstated (a) +provisionally, unless and until the copyright holder explicitly and +finally terminates your license, and (b) permanently, if the copyright +holder fails to notify you of the violation by some reasonable means +prior to 60 days after the cessation. + + Moreover, your license from a particular copyright holder is +reinstated permanently if the copyright holder notifies you of the +violation by some reasonable means, this is the first time you have +received notice of violation of this License (for any work) from that +copyright holder, and you cure the violation prior to 30 days after +your receipt of the notice. + + Termination of your rights under this section does not terminate the +licenses of parties who have received copies or rights from you under +this License. If your rights have been terminated and not permanently +reinstated, you do not qualify to receive new licenses for the same +material under section 10. + + 9. Acceptance Not Required for Having Copies. + + You are not required to accept this License in order to receive or +run a copy of the Program. Ancillary propagation of a covered work +occurring solely as a consequence of using peer-to-peer transmission +to receive a copy likewise does not require acceptance. However, +nothing other than this License grants you permission to propagate or +modify any covered work. These actions infringe copyright if you do +not accept this License. Therefore, by modifying or propagating a +covered work, you indicate your acceptance of this License to do so. + + 10. Automatic Licensing of Downstream Recipients. + + Each time you convey a covered work, the recipient automatically +receives a license from the original licensors, to run, modify and +propagate that work, subject to this License. You are not responsible +for enforcing compliance by third parties with this License. + + An "entity transaction" is a transaction transferring control of an +organization, or substantially all assets of one, or subdividing an +organization, or merging organizations. If propagation of a covered +work results from an entity transaction, each party to that +transaction who receives a copy of the work also receives whatever +licenses to the work the party's predecessor in interest had or could +give under the previous paragraph, plus a right to possession of the +Corresponding Source of the work from the predecessor in interest, if +the predecessor has it or can get it with reasonable efforts. + + You may not impose any further restrictions on the exercise of the +rights granted or affirmed under this License. For example, you may +not impose a license fee, royalty, or other charge for exercise of +rights granted under this License, and you may not initiate litigation +(including a cross-claim or counterclaim in a lawsuit) alleging that +any patent claim is infringed by making, using, selling, offering for +sale, or importing the Program or any portion of it. + + 11. Patents. + + A "contributor" is a copyright holder who authorizes use under this +License of the Program or a work on which the Program is based. The +work thus licensed is called the contributor's "contributor version". + + A contributor's "essential patent claims" are all patent claims +owned or controlled by the contributor, whether already acquired or +hereafter acquired, that would be infringed by some manner, permitted +by this License, of making, using, or selling its contributor version, +but do not include claims that would be infringed only as a +consequence of further modification of the contributor version. For +purposes of this definition, "control" includes the right to grant +patent sublicenses in a manner consistent with the requirements of +this License. + + Each contributor grants you a non-exclusive, worldwide, royalty-free +patent license under the contributor's essential patent claims, to +make, use, sell, offer for sale, import and otherwise run, modify and +propagate the contents of its contributor version. + + In the following three paragraphs, a "patent license" is any express +agreement or commitment, however denominated, not to enforce a patent +(such as an express permission to practice a patent or covenant not to +sue for patent infringement). To "grant" such a patent license to a +party means to make such an agreement or commitment not to enforce a +patent against the party. + + If you convey a covered work, knowingly relying on a patent license, +and the Corresponding Source of the work is not available for anyone +to copy, free of charge and under the terms of this License, through a +publicly available network server or other readily accessible means, +then you must either (1) cause the Corresponding Source to be so +available, or (2) arrange to deprive yourself of the benefit of the +patent license for this particular work, or (3) arrange, in a manner +consistent with the requirements of this License, to extend the patent +license to downstream recipients. "Knowingly relying" means you have +actual knowledge that, but for the patent license, your conveying the +covered work in a country, or your recipient's use of the covered work +in a country, would infringe one or more identifiable patents in that +country that you have reason to believe are valid. + + If, pursuant to or in connection with a single transaction or +arrangement, you convey, or propagate by procuring conveyance of, a +covered work, and grant a patent license to some of the parties +receiving the covered work authorizing them to use, propagate, modify +or convey a specific copy of the covered work, then the patent license +you grant is automatically extended to all recipients of the covered +work and works based on it. + + A patent license is "discriminatory" if it does not include within +the scope of its coverage, prohibits the exercise of, or is +conditioned on the non-exercise of one or more of the rights that are +specifically granted under this License. You may not convey a covered +work if you are a party to an arrangement with a third party that is +in the business of distributing software, under which you make payment +to the third party based on the extent of your activity of conveying +the work, and under which the third party grants, to any of the +parties who would receive the covered work from you, a discriminatory +patent license (a) in connection with copies of the covered work +conveyed by you (or copies made from those copies), or (b) primarily +for and in connection with specific products or compilations that +contain the covered work, unless you entered into that arrangement, +or that patent license was granted, prior to 28 March 2007. + + Nothing in this License shall be construed as excluding or limiting +any implied license or other defenses to infringement that may +otherwise be available to you under applicable patent law. + + 12. No Surrender of Others' Freedom. + + If conditions are imposed on you (whether by court order, agreement or +otherwise) that contradict the conditions of this License, they do not +excuse you from the conditions of this License. If you cannot convey a +covered work so as to satisfy simultaneously your obligations under this +License and any other pertinent obligations, then as a consequence you may +not convey it at all. For example, if you agree to terms that obligate you +to collect a royalty for further conveying from those to whom you convey +the Program, the only way you could satisfy both those terms and this +License would be to refrain entirely from conveying the Program. + + 13. Remote Network Interaction; Use with the GNU General Public License. + + Notwithstanding any other provision of this License, if you modify the +Program, your modified version must prominently offer all users +interacting with it remotely through a computer network (if your version +supports such interaction) an opportunity to receive the Corresponding +Source of your version by providing access to the Corresponding Source +from a network server at no charge, through some standard or customary +means of facilitating copying of software. This Corresponding Source +shall include the Corresponding Source for any work covered by version 3 +of the GNU General Public License that is incorporated pursuant to the +following paragraph. + + Notwithstanding any other provision of this License, you have +permission to link or combine any covered work with a work licensed +under version 3 of the GNU General Public License into a single +combined work, and to convey the resulting work. The terms of this +License will continue to apply to the part which is the covered work, +but the work with which it is combined will remain governed by version +3 of the GNU General Public License. + + 14. Revised Versions of this License. + + The Free Software Foundation may publish revised and/or new versions of +the GNU Affero General Public License from time to time. Such new versions +will be similar in spirit to the present version, but may differ in detail to +address new problems or concerns. + + Each version is given a distinguishing version number. If the +Program specifies that a certain numbered version of the GNU Affero General +Public License "or any later version" applies to it, you have the +option of following the terms and conditions either of that numbered +version or of any later version published by the Free Software +Foundation. If the Program does not specify a version number of the +GNU Affero General Public License, you may choose any version ever published +by the Free Software Foundation. + + If the Program specifies that a proxy can decide which future +versions of the GNU Affero General Public License can be used, that proxy's +public statement of acceptance of a version permanently authorizes you +to choose that version for the Program. + + Later license versions may give you additional or different +permissions. However, no additional obligations are imposed on any +author or copyright holder as a result of your choosing to follow a +later version. + + 15. Disclaimer of Warranty. + + THERE IS NO WARRANTY FOR THE PROGRAM, TO THE EXTENT PERMITTED BY +APPLICABLE LAW. EXCEPT WHEN OTHERWISE STATED IN WRITING THE COPYRIGHT +HOLDERS AND/OR OTHER PARTIES PROVIDE THE PROGRAM "AS IS" WITHOUT WARRANTY +OF ANY KIND, EITHER EXPRESSED OR IMPLIED, INCLUDING, BUT NOT LIMITED TO, +THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR +PURPOSE. THE ENTIRE RISK AS TO THE QUALITY AND PERFORMANCE OF THE PROGRAM +IS WITH YOU. SHOULD THE PROGRAM PROVE DEFECTIVE, YOU ASSUME THE COST OF +ALL NECESSARY SERVICING, REPAIR OR CORRECTION. + + 16. Limitation of Liability. + + IN NO EVENT UNLESS REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING +WILL ANY COPYRIGHT HOLDER, OR ANY OTHER PARTY WHO MODIFIES AND/OR CONVEYS +THE PROGRAM AS PERMITTED ABOVE, BE LIABLE TO YOU FOR DAMAGES, INCLUDING ANY +GENERAL, SPECIAL, INCIDENTAL OR CONSEQUENTIAL DAMAGES ARISING OUT OF THE +USE OR INABILITY TO USE THE PROGRAM (INCLUDING BUT NOT LIMITED TO LOSS OF +DATA OR DATA BEING RENDERED INACCURATE OR LOSSES SUSTAINED BY YOU OR THIRD +PARTIES OR A FAILURE OF THE PROGRAM TO OPERATE WITH ANY OTHER PROGRAMS), +EVEN IF SUCH HOLDER OR OTHER PARTY HAS BEEN ADVISED OF THE POSSIBILITY OF +SUCH DAMAGES. + + 17. Interpretation of Sections 15 and 16. + + If the disclaimer of warranty and limitation of liability provided +above cannot be given local legal effect according to their terms, +reviewing courts shall apply local law that most closely approximates +an absolute waiver of all civil liability in connection with the +Program, unless a warranty or assumption of liability accompanies a +copy of the Program in return for a fee. + + END OF TERMS AND CONDITIONS diff --git a/Myriad/COPYING b/Myriad/COPYING new file mode 100644 index 00000000..adf0ac6d --- /dev/null +++ b/Myriad/COPYING @@ -0,0 +1,20 @@ +Permission is hereby granted, free of charge, to any person obtaining +a copy of this software and associated documentation files (the +“Software”), to deal in the Software without restriction, including +without limitation the rights to use, copy, modify, merge, publish, +distribute, sublicense, and/or sell copies of the Software, and to +permit persons to whom the Software is furnished to do so, subject to +the following conditions: + +The above copyright notice and this permission notice shall be included +in all copies or substantial portions of the Software. + +THE SOFTWARE IS PROVIDED “AS IS”, WITHOUT WARRANTY OF ANY KIND, +EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF +MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. +IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY +CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, +TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE +SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. + + diff --git a/Myriad/README.md b/Myriad/README.md index 9ddc72cf..aa01760c 100644 --- a/Myriad/README.md +++ b/Myriad/README.md @@ -2,4 +2,6 @@ 'Myriad' is a .NET library used to interact with the Discord API. It's primarily intended for use with PluralKit, but feel free to fork or submodule it! -You can find a simple example bot using the Myriad library here: \ No newline at end of file +You can find a simple example bot using the Myriad library here: + +The Myriad library (`/Myriad` directory in this repository) is available under the MIT license. The license text can be found in the /Myriad/COPYING file. diff --git a/README.md b/README.md index 26b96c6d..bc560bcd 100644 --- a/README.md +++ b/README.md @@ -36,4 +36,6 @@ See [the dev-docs/ directory](./dev-docs/README.md) See [the docs/ directory](./docs/README.md) # License -This project is under the GNU Affero General Public License, Version 3. It is available at the following link: https://www.gnu.org/licenses/agpl-3.0.en.html +With the exception of the Myriad library, this project is under the GNU Affero General Public License, Version 3. The license text can be found in the COPYING file. + +Licensing information for the Myriad library can be found in the library's README.md file. From c4a4aad791889ea518b0d342fe1f96177aeac337 Mon Sep 17 00:00:00 2001 From: asleepyskye Date: Thu, 21 Aug 2025 11:20:47 -0400 Subject: [PATCH 05/40] chore: bump twilight --- Cargo.lock | 16 ++++++++-------- Cargo.toml | 10 +++++----- 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/Cargo.lock b/Cargo.lock index 96bb2e24..a0ea3bde 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -4444,7 +4444,7 @@ checksum = "e421abadd41a4225275504ea4d6566923418b7f05506fbc9c0fe86ba7396114b" [[package]] name = "twilight-cache-inmemory" version = "0.16.0" -source = "git+https://github.com/pluralkit/twilight?branch=pluralkit-70105ef#941604f888bb8d25239f4f3d4dfb1a9ecdb9851b" +source = "git+https://github.com/pluralkit/twilight?branch=pluralkit-7f08d95#054a2aa5d29fb46220af1cd5df568b73511cdb26" dependencies = [ "bitflags 2.9.0", "dashmap", @@ -4456,7 +4456,7 @@ dependencies = [ [[package]] name = "twilight-gateway" version = "0.16.0" -source = "git+https://github.com/pluralkit/twilight?branch=pluralkit-70105ef#941604f888bb8d25239f4f3d4dfb1a9ecdb9851b" +source = "git+https://github.com/pluralkit/twilight?branch=pluralkit-7f08d95#054a2aa5d29fb46220af1cd5df568b73511cdb26" dependencies = [ "bitflags 2.9.0", "fastrand", @@ -4476,7 +4476,7 @@ dependencies = [ [[package]] name = "twilight-gateway-queue" version = "0.16.0" -source = "git+https://github.com/pluralkit/twilight?branch=pluralkit-70105ef#941604f888bb8d25239f4f3d4dfb1a9ecdb9851b" +source = "git+https://github.com/pluralkit/twilight?branch=pluralkit-7f08d95#054a2aa5d29fb46220af1cd5df568b73511cdb26" dependencies = [ "tokio", "tracing", @@ -4485,7 +4485,7 @@ dependencies = [ [[package]] name = "twilight-http" version = "0.16.0" -source = "git+https://github.com/pluralkit/twilight?branch=pluralkit-70105ef#941604f888bb8d25239f4f3d4dfb1a9ecdb9851b" +source = "git+https://github.com/pluralkit/twilight?branch=pluralkit-7f08d95#054a2aa5d29fb46220af1cd5df568b73511cdb26" dependencies = [ "fastrand", "http 1.3.1", @@ -4507,7 +4507,7 @@ dependencies = [ [[package]] name = "twilight-http-ratelimiting" version = "0.16.0" -source = "git+https://github.com/pluralkit/twilight?branch=pluralkit-70105ef#941604f888bb8d25239f4f3d4dfb1a9ecdb9851b" +source = "git+https://github.com/pluralkit/twilight?branch=pluralkit-7f08d95#054a2aa5d29fb46220af1cd5df568b73511cdb26" dependencies = [ "tokio", "tracing", @@ -4516,7 +4516,7 @@ dependencies = [ [[package]] name = "twilight-model" version = "0.16.0" -source = "git+https://github.com/pluralkit/twilight?branch=pluralkit-70105ef#941604f888bb8d25239f4f3d4dfb1a9ecdb9851b" +source = "git+https://github.com/pluralkit/twilight?branch=pluralkit-7f08d95#054a2aa5d29fb46220af1cd5df568b73511cdb26" dependencies = [ "bitflags 2.9.0", "serde", @@ -4528,7 +4528,7 @@ dependencies = [ [[package]] name = "twilight-util" version = "0.16.0" -source = "git+https://github.com/pluralkit/twilight?branch=pluralkit-70105ef#941604f888bb8d25239f4f3d4dfb1a9ecdb9851b" +source = "git+https://github.com/pluralkit/twilight?branch=pluralkit-7f08d95#054a2aa5d29fb46220af1cd5df568b73511cdb26" dependencies = [ "twilight-model", ] @@ -4536,7 +4536,7 @@ dependencies = [ [[package]] name = "twilight-validate" version = "0.16.0" -source = "git+https://github.com/pluralkit/twilight?branch=pluralkit-70105ef#941604f888bb8d25239f4f3d4dfb1a9ecdb9851b" +source = "git+https://github.com/pluralkit/twilight?branch=pluralkit-7f08d95#054a2aa5d29fb46220af1cd5df568b73511cdb26" dependencies = [ "twilight-model", ] diff --git a/Cargo.toml b/Cargo.toml index 23ab960f..270d00a6 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -25,11 +25,11 @@ uuid = { version = "1.7.0", features = ["serde"] } axum = { git = "https://github.com/pluralkit/axum", branch = "v0.8.4-pluralkit" } -twilight-gateway = { git = "https://github.com/pluralkit/twilight", branch = "pluralkit-70105ef" } -twilight-cache-inmemory = { git = "https://github.com/pluralkit/twilight", branch = "pluralkit-70105ef", features = ["permission-calculator"] } -twilight-util = { git = "https://github.com/pluralkit/twilight", branch = "pluralkit-70105ef", features = ["permission-calculator"] } -twilight-model = { git = "https://github.com/pluralkit/twilight", branch = "pluralkit-70105ef" } -twilight-http = { git = "https://github.com/pluralkit/twilight", branch = "pluralkit-70105ef", default-features = false, features = ["rustls-aws_lc_rs", "rustls-native-roots"] } +twilight-gateway = { git = "https://github.com/pluralkit/twilight", branch = "pluralkit-7f08d95" } +twilight-cache-inmemory = { git = "https://github.com/pluralkit/twilight", branch = "pluralkit-7f08d95", features = ["permission-calculator"] } +twilight-util = { git = "https://github.com/pluralkit/twilight", branch = "pluralkit-7f08d95", features = ["permission-calculator"] } +twilight-model = { git = "https://github.com/pluralkit/twilight", branch = "pluralkit-7f08d95" } +twilight-http = { git = "https://github.com/pluralkit/twilight", branch = "pluralkit-7f08d95", default-features = false, features = ["rustls-aws_lc_rs", "rustls-native-roots"] } # twilight-gateway = { path = "../twilight/twilight-gateway" } # twilight-cache-inmemory = { path = "../twilight/twilight-cache-inmemory", features = ["permission-calculator"] } From 97f481120c76a02870adba9d19d0ccc6728a26be Mon Sep 17 00:00:00 2001 From: Iris System Date: Mon, 25 Aug 2025 11:32:58 +1200 Subject: [PATCH 06/40] fix: resolve NRE in DispatchService on system import --- PluralKit.Core/Dispatch/DispatchService.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PluralKit.Core/Dispatch/DispatchService.cs b/PluralKit.Core/Dispatch/DispatchService.cs index 832e63d3..0622ee64 100644 --- a/PluralKit.Core/Dispatch/DispatchService.cs +++ b/PluralKit.Core/Dispatch/DispatchService.cs @@ -97,7 +97,7 @@ public class DispatchService var repo = _provider.Resolve(); var system = await repo.GetSystem(systemId); - if (system.WebhookUrl == null) + if (system == null || system.WebhookUrl == null) return; data.SigningToken = system.WebhookToken; From 6b0b8f82ee4d27636592c4b32e7b10c876817b57 Mon Sep 17 00:00:00 2001 From: Iris System Date: Mon, 25 Aug 2025 12:21:28 +1200 Subject: [PATCH 07/40] chore: fix .NET build in VS2022 --- PluralKit.Core/PluralKit.Core.csproj | 2 +- PluralKit.sln | 17 ++++++++++++----- 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/PluralKit.Core/PluralKit.Core.csproj b/PluralKit.Core/PluralKit.Core.csproj index a13bcefb..0e87ecd5 100644 --- a/PluralKit.Core/PluralKit.Core.csproj +++ b/PluralKit.Core/PluralKit.Core.csproj @@ -60,7 +60,7 @@ - + diff --git a/PluralKit.sln b/PluralKit.sln index b1a66c75..26579278 100644 --- a/PluralKit.sln +++ b/PluralKit.sln @@ -1,6 +1,8 @@  Microsoft Visual Studio Solution File, Format Version 12.00 -# +# Visual Studio Version 17 +VisualStudioVersion = 17.14.36408.4 d17.14 +MinimumVisualStudioVersion = 10.0.40219.1 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "PluralKit.Bot", "PluralKit.Bot\PluralKit.Bot.csproj", "{F2C5562D-FD96-4C11-B54E-93737D127959}" EndProject Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "PluralKit.Core", "PluralKit.Core\PluralKit.Core.csproj", "{5DBE037D-179D-4C05-8A28-35E37129C961}" @@ -11,6 +13,8 @@ Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "PluralKit.Tests", "PluralKi EndProject Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Myriad", "Myriad\Myriad.csproj", "{ACB9BF37-F29C-4068-A7D1-2EFF2C308C4B}" EndProject +Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Serilog", "Serilog\src\Serilog\Serilog.csproj", "{4CF74FA7-1417-27D7-76DE-2467733F7E8B}" +EndProject Global GlobalSection(SolutionConfigurationPlatforms) = preSolution Debug|Any CPU = Debug|Any CPU @@ -37,9 +41,12 @@ Global {ACB9BF37-F29C-4068-A7D1-2EFF2C308C4B}.Debug|Any CPU.Build.0 = Debug|Any CPU {ACB9BF37-F29C-4068-A7D1-2EFF2C308C4B}.Release|Any CPU.ActiveCfg = Release|Any CPU {ACB9BF37-F29C-4068-A7D1-2EFF2C308C4B}.Release|Any CPU.Build.0 = Release|Any CPU - {374A8EB3-655D-4230-982B-459AE3553991}.Debug|Any CPU.ActiveCfg = Debug|Any CPU - {374A8EB3-655D-4230-982B-459AE3553991}.Debug|Any CPU.Build.0 = Debug|Any CPU - {374A8EB3-655D-4230-982B-459AE3553991}.Release|Any CPU.ActiveCfg = Release|Any CPU - {374A8EB3-655D-4230-982B-459AE3553991}.Release|Any CPU.Build.0 = Release|Any CPU + {4CF74FA7-1417-27D7-76DE-2467733F7E8B}.Debug|Any CPU.ActiveCfg = Debug|Any CPU + {4CF74FA7-1417-27D7-76DE-2467733F7E8B}.Debug|Any CPU.Build.0 = Debug|Any CPU + {4CF74FA7-1417-27D7-76DE-2467733F7E8B}.Release|Any CPU.ActiveCfg = Release|Any CPU + {4CF74FA7-1417-27D7-76DE-2467733F7E8B}.Release|Any CPU.Build.0 = Release|Any CPU + EndGlobalSection + GlobalSection(SolutionProperties) = preSolution + HideSolutionNode = FALSE EndGlobalSection EndGlobal From e4ad34655429373c31b81dee3bad080016992276 Mon Sep 17 00:00:00 2001 From: alyssa Date: Mon, 25 Aug 2025 03:58:17 +0000 Subject: [PATCH 08/40] chore(nix): bump flake lock --- flake.lock | 91 +++++++++++++++++++++++++++++------------------------- 1 file changed, 49 insertions(+), 42 deletions(-) diff --git a/flake.lock b/flake.lock index a13615a1..7298bd18 100644 --- a/flake.lock +++ b/flake.lock @@ -26,11 +26,11 @@ "pyproject-nix": "pyproject-nix" }, "locked": { - "lastModified": 1734729217, - "narHash": "sha256-UaBik0h7veLw+VqsK5EP2ucC68BEkHLDJkcfmY+wEuY=", + "lastModified": 1754978539, + "narHash": "sha256-nrDovydywSKRbWim9Ynmgj8SBm8LK3DI2WuhIqzOHYI=", "owner": "nix-community", "repo": "dream2nix", - "rev": "98c1c2e934995a2c6ce740d4ff43ce0daa19b79f", + "rev": "fbec3263cb4895ac86ee9506cdc4e6919a1a2214", "type": "github" }, "original": { @@ -57,12 +57,12 @@ }, "flake-compat_2": { "locked": { - "lastModified": 1696426674, - "narHash": "sha256-kvjfFW7WAETZlt09AgDn1MrtKzP7t90Vf7vypd3OL1U=", - "rev": "0f9255e01c2351cc7d116c072cb317785dd33b33", - "revCount": 57, + "lastModified": 1733328505, + "narHash": "sha256-NeCCThCEP3eCl2l/+27kNNK7QrwZB1IJCrXfrbv5oqU=", + "rev": "ff81ac966bb2cae68946d5ed5fc4994f96d0ffec", + "revCount": 69, "type": "tarball", - "url": "https://api.flakehub.com/f/pinned/edolstra/flake-compat/1.0.1/018afb31-abd1-7bff-a5e4-cff7e18efb7a/source.tar.gz" + "url": "https://api.flakehub.com/f/pinned/edolstra/flake-compat/1.1.0/01948eb7-9cba-704f-bbf3-3fa956735b52/source.tar.gz" }, "original": { "type": "tarball", @@ -104,11 +104,11 @@ ] }, "locked": { - "lastModified": 1734953472, - "narHash": "sha256-zWPAJFo7NNhSXbOc6YRAXbrWzcJGxNPtutKTTZz46Bs=", + "lastModified": 1756016279, + "narHash": "sha256-5BhsvOXsoMu4ZNe9HxQSynbbXm2FAZ0TIW5mWKlG5+Q=", "owner": "yusdacra", "repo": "nix-cargo-integration", - "rev": "e71c873cf3b0dfa52e9550d580531e41eb4b4c6a", + "rev": "4714a69e6de235cf750e6cc73f6a989cc7867579", "type": "github" }, "original": { @@ -119,11 +119,11 @@ }, "nixpkgs": { "locked": { - "lastModified": 1734435836, - "narHash": "sha256-kMBQ5PRiFLagltK0sH+08aiNt3zGERC2297iB6vrvlU=", + "lastModified": 1755829505, + "narHash": "sha256-4/Jd+LkQ2ssw8luQVkqVs9spDBVE6h/u/hC/tzngsPo=", "owner": "NixOS", "repo": "nixpkgs", - "rev": "4989a246d7a390a859852baddb1013f825435cee", + "rev": "f937f8ecd1c70efd7e9f90ba13dfb400cf559de4", "type": "github" }, "original": { @@ -134,14 +134,17 @@ }, "nixpkgs-lib": { "locked": { - "lastModified": 1733096140, - "narHash": "sha256-1qRH7uAUsyQI7R1Uwl4T+XvdNv778H0Nb5njNrqvylY=", - "type": "tarball", - "url": "https://github.com/NixOS/nixpkgs/archive/5487e69da40cbd611ab2cadee0b4637225f7cfae.tar.gz" + "lastModified": 1753579242, + "narHash": "sha256-zvaMGVn14/Zz8hnp4VWT9xVnhc8vuL3TStRqwk22biA=", + "owner": "nix-community", + "repo": "nixpkgs.lib", + "rev": "0f36c44e01a6129be94e3ade315a5883f0228a6e", + "type": "github" }, "original": { - "type": "tarball", - "url": "https://github.com/NixOS/nixpkgs/archive/5487e69da40cbd611ab2cadee0b4637225f7cfae.tar.gz" + "owner": "nix-community", + "repo": "nixpkgs.lib", + "type": "github" } }, "parts": { @@ -149,11 +152,11 @@ "nixpkgs-lib": "nixpkgs-lib" }, "locked": { - "lastModified": 1733312601, - "narHash": "sha256-4pDvzqnegAfRkPwO3wmwBhVi/Sye1mzps0zHWYnP88c=", + "lastModified": 1754487366, + "narHash": "sha256-pHYj8gUBapuUzKV/kN/tR3Zvqc7o6gdFB9XKXIp1SQ8=", "owner": "hercules-ci", "repo": "flake-parts", - "rev": "205b12d8b7cd4802fbcb8e8ef6a0f1408781a4f9", + "rev": "af66ad14b28a127c5c0f3bbb298218fc63528a18", "type": "github" }, "original": { @@ -164,11 +167,11 @@ }, "process-compose": { "locked": { - "lastModified": 1733325752, - "narHash": "sha256-79tzPuXNRo1NUllafYW6SjeLtjqfnLGq7tHCM7cAXNg=", + "lastModified": 1749418557, + "narHash": "sha256-wJHHckWz4Gvj8HXtM5WVJzSKXAEPvskQANVoRiu2w1w=", "owner": "Platonic-Systems", "repo": "process-compose-flake", - "rev": "1012530b582f1bd3b102295c799358d95abf42d7", + "rev": "91dcc48a6298e47e2441ec76df711f4e38eab94e", "type": "github" }, "original": { @@ -201,18 +204,22 @@ } }, "pyproject-nix": { - "flake": false, + "inputs": { + "nixpkgs": [ + "d2n", + "nixpkgs" + ] + }, "locked": { - "lastModified": 1702448246, - "narHash": "sha256-hFg5s/hoJFv7tDpiGvEvXP0UfFvFEDgTdyHIjDVHu1I=", - "owner": "davhau", + "lastModified": 1752481895, + "narHash": "sha256-luVj97hIMpCbwhx3hWiRwjP2YvljWy8FM+4W9njDhLA=", + "owner": "pyproject-nix", "repo": "pyproject.nix", - "rev": "5a06a2697b228c04dd2f35659b4b659ca74f7aeb", + "rev": "16ee295c25107a94e59a7fc7f2e5322851781162", "type": "github" }, "original": { - "owner": "davhau", - "ref": "dream2nix", + "owner": "pyproject-nix", "repo": "pyproject.nix", "type": "github" } @@ -238,11 +245,11 @@ ] }, "locked": { - "lastModified": 1734834660, - "narHash": "sha256-bm8V+Cu8rWJA+vKQnc94mXTpSDgvedyoDKxTVi/uJfw=", + "lastModified": 1756003222, + "narHash": "sha256-lmEMhIIbjt8Wp1EYbNqCojuU9ygyDFv8Tu0X1k8qIMc=", "owner": "oxalica", "repo": "rust-overlay", - "rev": "b070e6030118680977bc2388868c4b3963872134", + "rev": "88ceedecde53e809b4bf8b5fd10d181889d9bac7", "type": "github" }, "original": { @@ -253,11 +260,11 @@ }, "services": { "locked": { - "lastModified": 1734242477, - "narHash": "sha256-u+fkdD8+0/0J8k0/YKDc3ReUcYZZGiftGL+Sz2wdRqM=", + "lastModified": 1755996515, + "narHash": "sha256-1RQQIDhshp1g4PP5teqibcFLfk/ckTDOJRckecAHiU0=", "owner": "juspay", "repo": "services-flake", - "rev": "acc7f3f9f30621b469ca3ee511592a68a4437312", + "rev": "e316d6b994fd153f0c35d54bd07d60e53f0ad9a9", "type": "github" }, "original": { @@ -310,11 +317,11 @@ ] }, "locked": { - "lastModified": 1734704479, - "narHash": "sha256-MMi74+WckoyEWBRcg/oaGRvXC9BVVxDZNRMpL+72wBI=", + "lastModified": 1755934250, + "narHash": "sha256-CsDojnMgYsfshQw3t4zjRUkmMmUdZGthl16bXVWgRYU=", "owner": "numtide", "repo": "treefmt-nix", - "rev": "65712f5af67234dad91a5a4baee986a8b62dbf8f", + "rev": "74e1a52d5bd9430312f8d1b8b0354c92c17453e5", "type": "github" }, "original": { From d4611b3769014c99846b212290ca2b79f6c846c6 Mon Sep 17 00:00:00 2001 From: Iris System Date: Mon, 25 Aug 2025 15:24:14 +1200 Subject: [PATCH 09/40] chore: update CI dotnet-format action --- .github/workflows/dotnet.yml | 35 ++++++++++++++++++++--------------- 1 file changed, 20 insertions(+), 15 deletions(-) diff --git a/.github/workflows/dotnet.yml b/.github/workflows/dotnet.yml index 5f6d0afe..996a7cb7 100644 --- a/.github/workflows/dotnet.yml +++ b/.github/workflows/dotnet.yml @@ -21,26 +21,31 @@ jobs: name: 'run .net tests' runs-on: ubuntu-latest steps: - - uses: actions/checkout@v1 - with: - submodules: recursive - - name: Setup .NET Core - uses: actions/setup-dotnet@v1 - with: - dotnet-version: 8.0.x - - name: Run automated tests - run: dotnet test --configuration Release + - uses: actions/checkout@v4 + with: + submodules: recursive + + - name: Setup .NET Core + uses: actions/setup-dotnet@v1 + with: + dotnet-version: 8.0.x + + - name: Run automated tests + run: dotnet test --configuration Release + dotnet-format: runs-on: ubuntu-latest steps: - name: Checkout repo - uses: actions/checkout@v2 + uses: actions/checkout@v4 + + - name: Setup .NET Core + uses: actions/setup-dotnet@v1 + with: + dotnet-version: 8.0.x - name: Add dotnet-format problem matcher uses: xt0rted/dotnet-format-problem-matcher@v1 - - name: Restore dotnet tools - uses: xt0rted/dotnet-tool-restore@v1 - - - name: Run dotnet format - uses: PluralKit/dotnet-format@fix/net6 + - name: Run dotnet-format + run: dotnet format --no-restore --verify-no-changes From 2fc5f2a9d9b0848068496cc3de5271c637ea5f7b Mon Sep 17 00:00:00 2001 From: asleepyskye Date: Wed, 27 Aug 2025 17:22:04 -0400 Subject: [PATCH 10/40] chore: add link to new status page to docs, dash --- dashboard/main.go | 4 ++++ dashboard/src/components/common/Navigation.svelte | 2 +- docs/content/.vuepress/config.js | 5 +++-- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/dashboard/main.go b/dashboard/main.go index e657c740..9a0bc993 100644 --- a/dashboard/main.go +++ b/dashboard/main.go @@ -64,6 +64,10 @@ func main() { createEmbed(rw, r) }) + r.Get("/status", func(rw http.ResponseWriter, r *http.Request) { + http.Redirect(rw, r, "https://status.pluralkit.me/", http.StatusMovedPermanently) + }) + http.ListenAndServe(":8080", r) } diff --git a/dashboard/src/components/common/Navigation.svelte b/dashboard/src/components/common/Navigation.svelte index daf9db1d..498d6470 100644 --- a/dashboard/src/components/common/Navigation.svelte +++ b/dashboard/src/components/common/Navigation.svelte @@ -53,7 +53,7 @@ Public - Bot status + Bot status diff --git a/docs/content/.vuepress/config.js b/docs/content/.vuepress/config.js index 5bdc945e..b66c56e0 100644 --- a/docs/content/.vuepress/config.js +++ b/docs/content/.vuepress/config.js @@ -18,7 +18,7 @@ module.exports = { }, themeConfig: { - repo: 'PluralKit/PluralKit', + repo: false, docsDir: 'docs/content/', docsBranch: 'main', editLinks: true, @@ -29,7 +29,8 @@ module.exports = { nav: [ { text: "Web dashboard", link: "https://dash.pluralkit.me" }, { text: "Support server", link: "https://discord.gg/PczBt78" }, - { text: "Invite bot", link: "https://discord.com/oauth2/authorize?client_id=466378653216014359&scope=bot%20applications.commands&permissions=536995904" } + { text: "Invite bot", link: "https://discord.com/oauth2/authorize?client_id=466378653216014359&scope=bot%20applications.commands&permissions=536995904" }, + { text: "Bot status", link: "https://status.pluralkit.me/" } ], sidebar: [ "/", From 1378379e1491fe93edcc3d18e6c8c8d8e7ae9dbb Mon Sep 17 00:00:00 2001 From: asleepyskye Date: Wed, 27 Aug 2025 22:31:23 -0400 Subject: [PATCH 11/40] feat(gateway): add reconnect timestamp to shard state --- crates/gateway/src/discord/gateway.rs | 8 ++++++-- crates/gateway/src/discord/shard_state.rs | 3 ++- crates/gateway/src/main.rs | 11 ++++++++--- crates/libpk/src/state.rs | 2 ++ 4 files changed, 18 insertions(+), 6 deletions(-) diff --git a/crates/gateway/src/discord/gateway.rs b/crates/gateway/src/discord/gateway.rs index 6d16bfd1..2f657138 100644 --- a/crates/gateway/src/discord/gateway.rs +++ b/crates/gateway/src/discord/gateway.rs @@ -6,7 +6,7 @@ use std::sync::Arc; use tokio::sync::mpsc::Sender; use tracing::{error, info, warn}; use twilight_gateway::{ - create_iterator, ConfigBuilder, Event, EventTypeFlags, Message, Shard, ShardId, + create_iterator, ConfigBuilder, Event, EventTypeFlags, Message, Shard, ShardId, CloseFrame }; use twilight_model::gateway::{ payload::outgoing::update_presence::UpdatePresencePayload, @@ -116,7 +116,11 @@ pub async fn runner( let raw_event = match item { Ok(evt) => match evt { Message::Close(frame) => { + let mut state_event = ShardStateEvent::Closed; let close_code = if let Some(close) = frame { + if close == CloseFrame::RESUME { + state_event = ShardStateEvent::Reconnect; + } close.code.to_string() } else { "unknown".to_string() @@ -132,7 +136,7 @@ pub async fn runner( .increment(1); if let Err(error) = - tx_state.try_send((shard.id(), ShardStateEvent::Closed, None, None)) + tx_state.try_send((shard.id(), state_event, None, None)) { error!("failed to update shard state for socket closure: {error}"); } diff --git a/crates/gateway/src/discord/shard_state.rs b/crates/gateway/src/discord/shard_state.rs index c85e02c8..fe047b50 100644 --- a/crates/gateway/src/discord/shard_state.rs +++ b/crates/gateway/src/discord/shard_state.rs @@ -86,7 +86,7 @@ impl ShardStateManager { Ok(()) } - pub async fn socket_closed(&self, shard_id: u32) -> anyhow::Result<()> { + pub async fn socket_closed(&self, shard_id: u32, reconnect: bool) -> anyhow::Result<()> { gauge!("pluralkit_gateway_shard_up").decrement(1); let mut info = self @@ -97,6 +97,7 @@ impl ShardStateManager { info.shard_id = shard_id as i32; info.cluster_id = Some(cluster_config().node_id as i32); info.up = false; + info.last_reconnect = chrono::offset::Utc::now().timestamp() as i32; info.disconnection_count += 1; self.save_shard(shard_id, info).await?; diff --git a/crates/gateway/src/main.rs b/crates/gateway/src/main.rs index e61c3445..a4bf7d2a 100644 --- a/crates/gateway/src/main.rs +++ b/crates/gateway/src/main.rs @@ -109,8 +109,13 @@ async fn main() -> anyhow::Result<()> { }; } ShardStateEvent::Closed => { - if let Err(error) = shard_state.socket_closed(shard_id.number()).await { - error!("failed to update shard state for heartbeat: {error}") + if let Err(error) = shard_state.socket_closed(shard_id.number(), false).await { + error!("failed to update shard state for closed: {error}") + }; + } + ShardStateEvent::Reconnect => { + if let Err(error) = shard_state.socket_closed(shard_id.number(), true).await { + error!("failed to update shard state for reconnect: {error}") }; } ShardStateEvent::Other => { @@ -121,7 +126,7 @@ async fn main() -> anyhow::Result<()> { ) .await { - error!("failed to update shard state for heartbeat: {error}") + error!("failed to update shard state for other evt: {error}") }; } } diff --git a/crates/libpk/src/state.rs b/crates/libpk/src/state.rs index df44ea1d..3ea6342a 100644 --- a/crates/libpk/src/state.rs +++ b/crates/libpk/src/state.rs @@ -8,11 +8,13 @@ pub struct ShardState { /// unix timestamp pub last_heartbeat: i32, pub last_connection: i32, + pub last_reconnect: i32, pub cluster_id: Option, } pub enum ShardStateEvent { Closed, Heartbeat, + Reconnect, Other, } From 65b40c498b8ef05620080d05724a3ae2b38517fe Mon Sep 17 00:00:00 2001 From: asleepyskye Date: Wed, 27 Aug 2025 22:34:19 -0400 Subject: [PATCH 12/40] chore(gateway): format --- crates/gateway/src/discord/gateway.rs | 6 ++---- crates/gateway/src/main.rs | 7 +++++-- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/crates/gateway/src/discord/gateway.rs b/crates/gateway/src/discord/gateway.rs index 2f657138..8210e06e 100644 --- a/crates/gateway/src/discord/gateway.rs +++ b/crates/gateway/src/discord/gateway.rs @@ -6,7 +6,7 @@ use std::sync::Arc; use tokio::sync::mpsc::Sender; use tracing::{error, info, warn}; use twilight_gateway::{ - create_iterator, ConfigBuilder, Event, EventTypeFlags, Message, Shard, ShardId, CloseFrame + create_iterator, CloseFrame, ConfigBuilder, Event, EventTypeFlags, Message, Shard, ShardId, }; use twilight_model::gateway::{ payload::outgoing::update_presence::UpdatePresencePayload, @@ -135,9 +135,7 @@ pub async fn runner( ) .increment(1); - if let Err(error) = - tx_state.try_send((shard.id(), state_event, None, None)) - { + if let Err(error) = tx_state.try_send((shard.id(), state_event, None, None)) { error!("failed to update shard state for socket closure: {error}"); } diff --git a/crates/gateway/src/main.rs b/crates/gateway/src/main.rs index a4bf7d2a..12db76b5 100644 --- a/crates/gateway/src/main.rs +++ b/crates/gateway/src/main.rs @@ -109,12 +109,15 @@ async fn main() -> anyhow::Result<()> { }; } ShardStateEvent::Closed => { - if let Err(error) = shard_state.socket_closed(shard_id.number(), false).await { + if let Err(error) = + shard_state.socket_closed(shard_id.number(), false).await + { error!("failed to update shard state for closed: {error}") }; } ShardStateEvent::Reconnect => { - if let Err(error) = shard_state.socket_closed(shard_id.number(), true).await { + if let Err(error) = shard_state.socket_closed(shard_id.number(), true).await + { error!("failed to update shard state for reconnect: {error}") }; } From 0cd351de4565030289b9b28212f831818ba126f0 Mon Sep 17 00:00:00 2001 From: asleepyskye Date: Sun, 31 Aug 2025 22:46:51 -0400 Subject: [PATCH 13/40] fix(gateway): add missing 'if' to shard state --- crates/gateway/src/discord/shard_state.rs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/crates/gateway/src/discord/shard_state.rs b/crates/gateway/src/discord/shard_state.rs index fe047b50..847b14c6 100644 --- a/crates/gateway/src/discord/shard_state.rs +++ b/crates/gateway/src/discord/shard_state.rs @@ -97,7 +97,9 @@ impl ShardStateManager { info.shard_id = shard_id as i32; info.cluster_id = Some(cluster_config().node_id as i32); info.up = false; - info.last_reconnect = chrono::offset::Utc::now().timestamp() as i32; + if reconnect { + info.last_reconnect = chrono::offset::Utc::now().timestamp() as i32 + } info.disconnection_count += 1; self.save_shard(shard_id, info).await?; From b3eb108a13f50e61fb4be654ed815008b554f385 Mon Sep 17 00:00:00 2001 From: asleepyskye Date: Mon, 1 Sep 2025 21:23:24 -0400 Subject: [PATCH 14/40] chore(bot): update wording on error message --- PluralKit.Bot/Services/ErrorMessageService.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PluralKit.Bot/Services/ErrorMessageService.cs b/PluralKit.Bot/Services/ErrorMessageService.cs index 50f47d1c..efab9d02 100644 --- a/PluralKit.Bot/Services/ErrorMessageService.cs +++ b/PluralKit.Bot/Services/ErrorMessageService.cs @@ -116,7 +116,7 @@ public class ErrorMessageService return new EmbedBuilder() .Color(0xE74C3C) .Title("Internal error occurred") - .Description($"For support, please send the error code above as text in {channelInfo} with a description of what you were doing at the time.") + .Description($"**If you need support,** please send/forward the error code above **as text** in {channelInfo} with a description of what you were doing at the time.") .Footer(new Embed.EmbedFooter(errorId)) .Timestamp(now.ToDateTimeOffset().ToString("O")) .Build(); From 2248403140031ecd7fa3ed14e4826763e6558d28 Mon Sep 17 00:00:00 2001 From: asleepyskye Date: Mon, 1 Sep 2025 21:33:16 -0400 Subject: [PATCH 15/40] fix(flake): change systems url to default --- flake.lock | 10 +++++----- flake.nix | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/flake.lock b/flake.lock index 7298bd18..4024bfd9 100644 --- a/flake.lock +++ b/flake.lock @@ -297,16 +297,16 @@ }, "systems": { "locked": { - "lastModified": 1680978846, - "narHash": "sha256-Gtqg8b/v49BFDpDetjclCYXm8mAnTrUzR0JnE2nv5aw=", + "lastModified": 1681028828, + "narHash": "sha256-Vy1rq5AaRuLzOxct8nz4T6wlgyUR7zLU309k9mBC768=", "owner": "nix-systems", - "repo": "x86_64-linux", - "rev": "2ecfcac5e15790ba6ce360ceccddb15ad16d08a8", + "repo": "default", + "rev": "da67096a3b9bf56a91d16901293e51ba5b49a27e", "type": "github" }, "original": { "owner": "nix-systems", - "repo": "x86_64-linux", + "repo": "default", "type": "github" } }, diff --git a/flake.nix b/flake.nix index 8fd2ed6b..85793415 100644 --- a/flake.nix +++ b/flake.nix @@ -4,7 +4,7 @@ inputs = { nixpkgs.url = "nixpkgs/nixpkgs-unstable"; parts.url = "github:hercules-ci/flake-parts"; - systems.url = "github:nix-systems/x86_64-linux"; + systems.url = "github:nix-systems/default"; # process compose process-compose.url = "github:Platonic-Systems/process-compose-flake"; services.url = "github:juspay/services-flake"; From 2d40a1ee1623a1d0cc9d1173befb8d89c9962f38 Mon Sep 17 00:00:00 2001 From: alyssa Date: Sun, 27 Jul 2025 00:18:47 +0000 Subject: [PATCH 16/40] feat(stats): add metric for basebackup age --- Cargo.lock | 1 + ci/rust-docker-target.sh | 7 ++- crates/scheduled_tasks/Cargo.toml | 1 + crates/scheduled_tasks/src/main.rs | 14 ++++- crates/scheduled_tasks/src/tasks.rs | 91 ++++++++++++++++++++++++++++- 5 files changed, 111 insertions(+), 3 deletions(-) diff --git a/Cargo.lock b/Cargo.lock index a0ea3bde..2b168f1b 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -3311,6 +3311,7 @@ dependencies = [ "chrono", "croner", "fred", + "lazy_static", "libpk", "metrics", "num-format", diff --git a/ci/rust-docker-target.sh b/ci/rust-docker-target.sh index ba6df5e9..d7d5f6fc 100755 --- a/ci/rust-docker-target.sh +++ b/ci/rust-docker-target.sh @@ -42,5 +42,10 @@ build api build dispatch build gateway build avatars "COPY .docker-bin/avatar_cleanup /bin/avatar_cleanup" -build scheduled_tasks +build scheduled_tasks "$(cat < anyhow::Result<()> { update_db_message_meta ); doforever!("* * * * *", "discord stats updater", update_discord_stats); - // on :00 and :30 + // on hh:00 and hh:30 doforever!( "0,30 * * * *", "queue deleted image cleanup job", queue_deleted_image_cleanup ); + // non-standard cron: at hh:mm:00, hh:mm:30 doforever!("0,30 * * * * *", "stats api updater", update_stats_api); + // every hour (could probably even be less frequent, basebackups are taken rarely) + doforever!( + "* * * * *", + "data basebackup info updater", + update_data_basebackup_prometheus + ); + doforever!( + "* * * * *", + "messages basebackup info updater", + update_messages_basebackup_prometheus + ); set.join_next() .await diff --git a/crates/scheduled_tasks/src/tasks.rs b/crates/scheduled_tasks/src/tasks.rs index 64246fc9..84773149 100644 --- a/crates/scheduled_tasks/src/tasks.rs +++ b/crates/scheduled_tasks/src/tasks.rs @@ -1,4 +1,4 @@ -use std::time::Duration; +use std::{collections::HashMap, time::Duration}; use anyhow::anyhow; use fred::prelude::KeysInterface; @@ -10,10 +10,22 @@ use metrics::gauge; use num_format::{Locale, ToFormattedString}; use reqwest::ClientBuilder; use sqlx::Executor; +use tokio::{process::Command, sync::Mutex}; use crate::AppCtx; pub async fn update_prometheus(ctx: AppCtx) -> anyhow::Result<()> { + let data_ts = *BASEBACKUP_TS.lock().await.get("data").unwrap_or(&0) as f64; + let messages_ts = *BASEBACKUP_TS.lock().await.get("messages").unwrap_or(&0) as f64; + + let now_ts = chrono::Utc::now().timestamp() as f64; + + gauge!("pluralkit_latest_backup_ts", "repo" => "data").set(data_ts); + gauge!("pluralkit_latest_backup_ts", "repo" => "messages").set(messages_ts); + + gauge!("pluralkit_latest_backup_age", "repo" => "data").set(now_ts - data_ts); + gauge!("pluralkit_latest_backup_age", "repo" => "messages").set(now_ts - messages_ts); + #[derive(sqlx::FromRow)] struct Count { count: i64, @@ -41,6 +53,83 @@ pub async fn update_prometheus(ctx: AppCtx) -> anyhow::Result<()> { Ok(()) } +lazy_static::lazy_static! { + static ref BASEBACKUP_TS: Mutex> = Mutex::new(HashMap::new()); +} + +pub async fn update_data_basebackup_prometheus(_: AppCtx) -> anyhow::Result<()> { + update_basebackup_ts("data".to_string()).await +} + +pub async fn update_messages_basebackup_prometheus(_: AppCtx) -> anyhow::Result<()> { + update_basebackup_ts("messages".to_string()).await +} + +async fn update_basebackup_ts(repo: String) -> anyhow::Result<()> { + let mut env = HashMap::new(); + + for (key, value) in std::env::vars() { + if key.starts_with("AWS") { + env.insert(key, value); + } + } + + env.insert( + "WALG_S3_PREFIX".to_string(), + format!("s3://pluralkit-backups/{repo}/"), + ); + + let output = Command::new("wal-g") + .arg("backup-list") + .arg("--json") + .envs(env) + .output() + .await?; + + if !output.status.success() { + // todo: we should return error here + tracing::error!( + status = output.status.code(), + "failed to execute wal-g command" + ); + return Ok(()); + } + + #[derive(serde::Deserialize)] + struct WalgBackupInfo { + backup_name: String, + time: String, + ts_parsed: Option, + } + + let mut info = + serde_json::from_str::>(&String::from_utf8_lossy(&output.stdout))? + .into_iter() + .filter(|v| v.backup_name.contains("base")) + .filter_map(|mut v| { + chrono::DateTime::parse_from_rfc3339(&v.time) + .ok() + .map(|dt| { + v.ts_parsed = Some(dt.with_timezone(&chrono::Utc).timestamp()); + v + }) + }) + .collect::>(); + + info.sort_by(|a, b| b.ts_parsed.cmp(&a.ts_parsed)); + + let Some(info) = info.first() else { + anyhow::bail!("could not find any basebackups in repo {repo}"); + }; + + BASEBACKUP_TS + .lock() + .await + .insert(repo, info.ts_parsed.unwrap()); + + Ok(()) +} + pub async fn update_db_meta(ctx: AppCtx) -> anyhow::Result<()> { ctx.data .execute( From 9c1acd84e1bae6b8bdaa5a0c9b32b4faa28fcba7 Mon Sep 17 00:00:00 2001 From: alyssa Date: Fri, 8 Aug 2025 20:36:51 +0000 Subject: [PATCH 17/40] fix(api): use constant time comparison for tokens --- Cargo.lock | 1 + crates/api/Cargo.toml | 1 + crates/api/src/middleware/auth.rs | 9 ++++++--- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/Cargo.lock b/Cargo.lock index 2b168f1b..d4b91f58 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -95,6 +95,7 @@ dependencies = [ "serde_json", "serde_urlencoded", "sqlx", + "subtle", "tokio", "tower 0.4.13", "tower-http", diff --git a/crates/api/Cargo.toml b/crates/api/Cargo.toml index d2f883d7..e1f99425 100644 --- a/crates/api/Cargo.toml +++ b/crates/api/Cargo.toml @@ -26,3 +26,4 @@ reverse-proxy-service = { version = "0.2.1", features = ["axum"] } serde_urlencoded = "0.7.1" tower = "0.4.13" tower-http = { version = "0.5.2", features = ["catch-panic"] } +subtle = "2.6.1" diff --git a/crates/api/src/middleware/auth.rs b/crates/api/src/middleware/auth.rs index 08981c3a..3d1d813b 100644 --- a/crates/api/src/middleware/auth.rs +++ b/crates/api/src/middleware/auth.rs @@ -5,6 +5,8 @@ use axum::{ response::Response, }; +use subtle::ConstantTimeEq; + use tracing::error; use crate::auth::AuthState; @@ -48,9 +50,10 @@ pub async fn auth(State(ctx): State, mut req: Request, next: Next) - .expect("missing api config") .temp_token2 .as_ref() - // this is NOT how you validate tokens - // but this is low abuse risk so we're keeping it for now - && app_auth_header == config_token2 + && app_auth_header + .as_bytes() + .ct_eq(config_token2.as_bytes()) + .into() { authed_app_id = Some(1); } From dd14e7daefb0757c41afc761fd3488ae466caa09 Mon Sep 17 00:00:00 2001 From: alyssa Date: Fri, 8 Aug 2025 20:57:38 +0000 Subject: [PATCH 18/40] feat(api): add internal auth --- crates/api/src/auth.rs | 13 +++++++++++-- crates/api/src/middleware/auth.rs | 17 ++++++++++++++++- crates/libpk/src/_config.rs | 3 +++ 3 files changed, 30 insertions(+), 3 deletions(-) diff --git a/crates/api/src/auth.rs b/crates/api/src/auth.rs index c084eafe..4e12a287 100644 --- a/crates/api/src/auth.rs +++ b/crates/api/src/auth.rs @@ -7,11 +7,16 @@ pub const INTERNAL_APPID_HEADER: &'static str = "x-pluralkit-appid"; pub struct AuthState { system_id: Option, app_id: Option, + internal: bool, } impl AuthState { - pub fn new(system_id: Option, app_id: Option) -> Self { - Self { system_id, app_id } + pub fn new(system_id: Option, app_id: Option, internal: bool) -> Self { + Self { + system_id, + app_id, + internal, + } } pub fn system_id(&self) -> Option { @@ -22,6 +27,10 @@ impl AuthState { self.app_id } + pub fn internal(&self) -> bool { + self.internal + } + pub fn access_level_for(&self, a: &impl Authable) -> PrivacyLevel { if self .system_id diff --git a/crates/api/src/middleware/auth.rs b/crates/api/src/middleware/auth.rs index 3d1d813b..0992757f 100644 --- a/crates/api/src/middleware/auth.rs +++ b/crates/api/src/middleware/auth.rs @@ -58,8 +58,23 @@ pub async fn auth(State(ctx): State, mut req: Request, next: Next) - authed_app_id = Some(1); } + // todo: fix syntax + let internal = if req.headers().get("x-pluralkit-client-ip").is_none() + && let Some(auth_header) = req + .headers() + .get("x-pluralkit-internalauth") + .map(|h| h.to_str().ok()) + .flatten() + && let Some(real_token) = libpk::config.internal_auth.clone() + && auth_header.as_bytes().ct_eq(real_token.as_bytes()).into() + { + true + } else { + false + }; + req.extensions_mut() - .insert(AuthState::new(authed_system_id, authed_app_id)); + .insert(AuthState::new(authed_system_id, authed_app_id, internal)); next.run(req).await } diff --git a/crates/libpk/src/_config.rs b/crates/libpk/src/_config.rs index 8358440b..7f992d95 100644 --- a/crates/libpk/src/_config.rs +++ b/crates/libpk/src/_config.rs @@ -128,6 +128,9 @@ pub struct PKConfig { #[serde(default)] pub sentry_url: Option, + + #[serde(default)] + pub internal_auth: Option, } impl PKConfig { From a49dbefe83ee2e756308d4e762d04252309b0046 Mon Sep 17 00:00:00 2001 From: alyssa Date: Sat, 9 Aug 2025 14:50:57 +0000 Subject: [PATCH 19/40] fix(api): automatically reload ratelimit script on redis server restart --- crates/api/src/middleware/ratelimit.rs | 43 +++++++++++++++----------- 1 file changed, 25 insertions(+), 18 deletions(-) diff --git a/crates/api/src/middleware/ratelimit.rs b/crates/api/src/middleware/ratelimit.rs index f4a63f7e..1638ecc9 100644 --- a/crates/api/src/middleware/ratelimit.rs +++ b/crates/api/src/middleware/ratelimit.rs @@ -45,21 +45,6 @@ pub fn ratelimiter(f: F) -> FromFnLayer, T> { tokio::spawn(async move { handle }); - let rscript = r.clone(); - tokio::spawn(async move { - if let Ok(()) = rscript.wait_for_connect().await { - match rscript - .script_load::(LUA_SCRIPT.to_string()) - .await - { - Ok(_) => info!("connected to redis for request rate limiting"), - Err(error) => error!(?error, "could not load redis script"), - } - } else { - error!("could not wait for connection to load redis script!"); - } - }); - r }); @@ -152,12 +137,34 @@ pub async fn do_request_ratelimited( let period = 1; // seconds let cost = 1; // todo: update this for group member endpoints + let script_exists: Vec = + match redis.script_exists(vec![LUA_SCRIPT_SHA.to_string()]).await { + Ok(exists) => exists, + Err(error) => { + error!(?error, "failed to check ratelimit script"); + return json_err( + StatusCode::INTERNAL_SERVER_ERROR, + r#"{"message": "500: internal server error", "code": 0}"#.to_string(), + ); + } + }; + + if script_exists[0] != 1 { + match redis + .script_load::(LUA_SCRIPT.to_string()) + .await + { + Ok(_) => info!("successfully loaded ratelimit script to redis"), + Err(error) => { + error!(?error, "could not load redis script") + } + } + } + // local rate_limit_key = KEYS[1] // local rate = ARGV[1] // local period = ARGV[2] // return {remaining, tostring(retry_after), reset_after} - - // todo: check if error is script not found and reload script let resp = redis .evalsha::<(i32, String, u64), String, Vec, Vec>( LUA_SCRIPT_SHA.to_string(), @@ -219,7 +226,7 @@ pub async fn do_request_ratelimited( return response; } Err(error) => { - tracing::error!(?error, "error getting ratelimit info"); + error!(?error, "error getting ratelimit info"); return json_err( StatusCode::INTERNAL_SERVER_ERROR, r#"{"message": "500: internal server error", "code": 0}"#.to_string(), From 214f164fbcee1eb7d26ede0018b2cd5efac6024e Mon Sep 17 00:00:00 2001 From: alyssa Date: Sun, 10 Aug 2025 00:25:29 +0000 Subject: [PATCH 20/40] feat(api): implement PKError in rust-api --- Cargo.lock | 10 +++-- crates/api/Cargo.toml | 1 + crates/api/src/endpoints/private.rs | 18 ++++---- crates/api/src/endpoints/system.rs | 43 ++++++------------ crates/api/src/error.rs | 68 ++++++++++++++++++++++++++--- crates/api/src/main.rs | 21 ++++----- crates/macros/Cargo.toml | 1 + crates/macros/src/api.rs | 52 ++++++++++++++++++++++ crates/macros/src/lib.rs | 6 +++ 9 files changed, 157 insertions(+), 63 deletions(-) create mode 100644 crates/macros/src/api.rs diff --git a/Cargo.lock b/Cargo.lock index d4b91f58..d52d073b 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -88,6 +88,7 @@ dependencies = [ "lazy_static", "libpk", "metrics", + "pk_macros", "pluralkit_models", "reqwest 0.12.15", "reverse-proxy-service", @@ -2530,6 +2531,7 @@ checksum = "8b870d8c151b6f2fb93e84a13146138f05d02ed11c7e7c54f8826aaaf7c9f184" name = "pk_macros" version = "0.1.0" dependencies = [ + "prettyplease", "proc-macro2", "quote", "syn", @@ -2611,9 +2613,9 @@ dependencies = [ [[package]] name = "prettyplease" -version = "0.2.31" +version = "0.2.36" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "5316f57387668042f561aae71480de936257848f9c43ce528e311d89a07cadeb" +checksum = "ff24dfcda44452b9816fff4cd4227e1bb73ff5a2f1bc1105aa92fb8565ce44d2" dependencies = [ "proc-macro2", "syn", @@ -3965,9 +3967,9 @@ checksum = "13c2bddecc57b384dee18652358fb23172facb8a2c51ccc10d74c157bdea3292" [[package]] name = "syn" -version = "2.0.100" +version = "2.0.104" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "b09a44accad81e1ba1cd74a32461ba89dee89095ba17b32f5d03683b1b1fc2a0" +checksum = "17b6f705963418cdb9927482fa304bc562ece2fdd4f616084c50b7023b435a40" dependencies = [ "proc-macro2", "quote", diff --git a/crates/api/Cargo.toml b/crates/api/Cargo.toml index e1f99425..9413d62c 100644 --- a/crates/api/Cargo.toml +++ b/crates/api/Cargo.toml @@ -5,6 +5,7 @@ edition = "2021" [dependencies] pluralkit_models = { path = "../models" } +pk_macros = { path = "../macros" } libpk = { path = "../libpk" } anyhow = { workspace = true } diff --git a/crates/api/src/endpoints/private.rs b/crates/api/src/endpoints/private.rs index df67421c..067fef57 100644 --- a/crates/api/src/endpoints/private.rs +++ b/crates/api/src/endpoints/private.rs @@ -2,6 +2,7 @@ use crate::ApiContext; use axum::{extract::State, response::Json}; use fred::interfaces::*; use libpk::state::ShardState; +use pk_macros::api_endpoint; use serde::Deserialize; use serde_json::{json, Value}; use std::collections::HashMap; @@ -13,34 +14,33 @@ struct ClusterStats { pub channel_count: i32, } +#[api_endpoint] pub async fn discord_state(State(ctx): State) -> Json { let mut shard_status = ctx .redis .hgetall::, &str>("pluralkit:shardstatus") - .await - .unwrap() + .await? .values() .map(|v| serde_json::from_str(v).expect("could not deserialize shard")) .collect::>(); shard_status.sort_by(|a, b| b.shard_id.cmp(&a.shard_id)); - Json(json!({ + Ok(Json(json!({ "shards": shard_status, - })) + }))) } +#[api_endpoint] pub async fn meta(State(ctx): State) -> Json { let stats = serde_json::from_str::( ctx.redis .get::("statsapi") - .await - .unwrap() + .await? .as_str(), - ) - .unwrap(); + )?; - Json(stats) + Ok(Json(stats)) } use std::time::Duration; diff --git a/crates/api/src/endpoints/system.rs b/crates/api/src/endpoints/system.rs index e510f7c5..7b919df5 100644 --- a/crates/api/src/endpoints/system.rs +++ b/crates/api/src/endpoints/system.rs @@ -1,22 +1,18 @@ -use axum::{ - extract::State, - http::StatusCode, - response::{IntoResponse, Response}, - Extension, Json, -}; -use serde_json::json; +use axum::{extract::State, response::IntoResponse, Extension, Json}; +use pk_macros::api_endpoint; +use serde_json::{json, Value}; use sqlx::Postgres; -use tracing::error; use pluralkit_models::{PKSystem, PKSystemConfig, PrivacyLevel}; -use crate::{auth::AuthState, util::json_err, ApiContext}; +use crate::{auth::AuthState, error::fail, ApiContext}; +#[api_endpoint] pub async fn get_system_settings( Extension(auth): Extension, Extension(system): Extension, State(ctx): State, -) -> Response { +) -> Json { let access_level = auth.access_level_for(&system); let mut config = match sqlx::query_as::( @@ -27,23 +23,11 @@ pub async fn get_system_settings( .await { Ok(Some(config)) => config, - Ok(None) => { - error!( - system = system.id, - "failed to find system config for existing system" - ); - return json_err( - StatusCode::INTERNAL_SERVER_ERROR, - r#"{"message": "500: Internal Server Error", "code": 0}"#.to_string(), - ); - } - Err(err) => { - error!(?err, "failed to query system config"); - return json_err( - StatusCode::INTERNAL_SERVER_ERROR, - r#"{"message": "500: Internal Server Error", "code": 0}"#.to_string(), - ); - } + Ok(None) => fail!( + system = system.id, + "failed to find system config for existing system" + ), + Err(err) => fail!(?err, "failed to query system config"), }; // fix this @@ -51,7 +35,7 @@ pub async fn get_system_settings( config.name_format = Some("{name} {tag}".to_string()); } - Json(&match access_level { + Ok(Json(match access_level { PrivacyLevel::Private => config.to_json(), PrivacyLevel::Public => json!({ "pings_enabled": config.pings_enabled, @@ -64,6 +48,5 @@ pub async fn get_system_settings( "proxy_switch": config.proxy_switch, "name_format": config.name_format, }), - }) - .into_response() + })) } diff --git a/crates/api/src/error.rs b/crates/api/src/error.rs index 464534d8..fc481d0c 100644 --- a/crates/api/src/error.rs +++ b/crates/api/src/error.rs @@ -1,13 +1,17 @@ -use axum::http::StatusCode; +use axum::{ + http::StatusCode, + response::{IntoResponse, Response}, +}; use std::fmt; -// todo -#[allow(dead_code)] +// todo: model parse errors #[derive(Debug)] pub struct PKError { pub response_code: StatusCode, pub json_code: i32, pub message: &'static str, + + pub inner: Option, } impl fmt::Display for PKError { @@ -16,17 +20,67 @@ impl fmt::Display for PKError { } } -impl std::error::Error for PKError {} +impl Clone for PKError { + fn clone(&self) -> PKError { + if self.inner.is_some() { + panic!("cannot clone PKError with inner error"); + } + PKError { + response_code: self.response_code, + json_code: self.json_code, + message: self.message, + inner: None, + } + } +} + +impl From for PKError +where + E: std::fmt::Display + Into, +{ + fn from(err: E) -> Self { + let mut res = GENERIC_SERVER_ERROR.clone(); + res.inner = Some(err.into()); + res + } +} + +impl IntoResponse for PKError { + fn into_response(self) -> Response { + if let Some(inner) = self.inner { + tracing::error!(?inner, "error returned from handler"); + } + crate::util::json_err( + self.response_code, + serde_json::to_string(&serde_json::json!({ + "message": self.message, + "code": self.json_code, + })) + .unwrap(), + ) + } +} + +macro_rules! fail { + ($($stuff:tt)+) => {{ + tracing::error!($($stuff)+); + return Err(crate::error::GENERIC_SERVER_ERROR); + }}; +} + +pub(crate) use fail; -#[allow(unused_macros)] macro_rules! define_error { ( $name:ident, $response_code:expr, $json_code:expr, $message:expr ) => { - const $name: PKError = PKError { + #[allow(dead_code)] + pub const $name: PKError = PKError { response_code: $response_code, json_code: $json_code, message: $message, + inner: None, }; }; } -// define_error! { GENERIC_BAD_REQUEST, StatusCode::BAD_REQUEST, 0, "400: Bad Request" } +define_error! { GENERIC_BAD_REQUEST, StatusCode::BAD_REQUEST, 0, "400: Bad Request" } +define_error! { GENERIC_SERVER_ERROR, StatusCode::INTERNAL_SERVER_ERROR, 0, "500: Internal Server Error" } diff --git a/crates/api/src/main.rs b/crates/api/src/main.rs index e3a201cb..07e47f89 100644 --- a/crates/api/src/main.rs +++ b/crates/api/src/main.rs @@ -4,8 +4,8 @@ use auth::{AuthState, INTERNAL_APPID_HEADER, INTERNAL_SYSTEMID_HEADER}; use axum::{ body::Body, extract::{Request as ExtractRequest, State}, - http::{Response, StatusCode, Uri}, - response::IntoResponse, + http::Uri, + response::{IntoResponse, Response}, routing::{delete, get, patch, post}, Extension, Router, }; @@ -13,7 +13,9 @@ use hyper_util::{ client::legacy::{connect::HttpConnector, Client}, rt::TokioExecutor, }; -use tracing::{error, info}; +use tracing::info; + +use pk_macros::api_endpoint; mod auth; mod endpoints; @@ -30,11 +32,12 @@ pub struct ApiContext { rproxy_client: Client, } +#[api_endpoint] async fn rproxy( Extension(auth): Extension, State(ctx): State, mut req: ExtractRequest, -) -> Result, StatusCode> { +) -> Response { let path = req.uri().path(); let path_query = req .uri() @@ -59,15 +62,7 @@ async fn rproxy( headers.append(INTERNAL_APPID_HEADER, aid.into()); } - Ok(ctx - .rproxy_client - .request(req) - .await - .map_err(|error| { - error!(?error, "failed to serve reverse proxy to dotnet-api"); - StatusCode::BAD_GATEWAY - })? - .into_response()) + Ok(ctx.rproxy_client.request(req).await?.into_response()) } // this function is manually formatted for easier legibility of route_services diff --git a/crates/macros/Cargo.toml b/crates/macros/Cargo.toml index 8090798f..10feaf88 100644 --- a/crates/macros/Cargo.toml +++ b/crates/macros/Cargo.toml @@ -10,4 +10,5 @@ proc-macro = true quote = "1.0" proc-macro2 = "1.0" syn = "2.0" +prettyplease = "0.2.36" diff --git a/crates/macros/src/api.rs b/crates/macros/src/api.rs new file mode 100644 index 00000000..7f797b8c --- /dev/null +++ b/crates/macros/src/api.rs @@ -0,0 +1,52 @@ +use quote::quote; +use syn::{parse_macro_input, FnArg, ItemFn, Pat}; + +fn pretty_print(ts: &proc_macro2::TokenStream) -> String { + let file = syn::parse_file(&ts.to_string()).unwrap(); + prettyplease::unparse(&file) +} + +pub fn macro_impl( + _args: proc_macro::TokenStream, + input: proc_macro::TokenStream, +) -> proc_macro::TokenStream { + let input = parse_macro_input!(input as ItemFn); + + let fn_name = &input.sig.ident; + let fn_params = &input.sig.inputs; + let fn_body = &input.block; + let syn::ReturnType::Type(_, fn_return_type) = &input.sig.output else { + panic!("handler return type must not be nothing"); + }; + let pms: Vec = fn_params + .iter() + .map(|v| { + let FnArg::Typed(pat) = v else { + panic!("must not have self param in handler"); + }; + let mut pat = pat.pat.clone(); + if let Pat::Ident(ident) = *pat { + let mut ident = ident.clone(); + ident.mutability = None; + pat = Box::new(Pat::Ident(ident)); + } + quote! { #pat } + }) + .collect(); + + let res = quote! { + #[allow(unused_mut)] + pub async fn #fn_name(#fn_params) -> axum::response::Response { + async fn inner(#fn_params) -> Result<#fn_return_type, crate::error::PKError> { + #fn_body + } + + match inner(#(#pms),*).await { + Ok(res) => res.into_response(), + Err(err) => err.into_response(), + } + } + }; + + res.into() +} diff --git a/crates/macros/src/lib.rs b/crates/macros/src/lib.rs index db5a55b7..ad3c1064 100644 --- a/crates/macros/src/lib.rs +++ b/crates/macros/src/lib.rs @@ -1,8 +1,14 @@ use proc_macro::TokenStream; +mod api; mod entrypoint; mod model; +#[proc_macro_attribute] +pub fn api_endpoint(args: TokenStream, input: TokenStream) -> TokenStream { + api::macro_impl(args, input) +} + #[proc_macro_attribute] pub fn main(args: TokenStream, input: TokenStream) -> TokenStream { entrypoint::macro_impl(args, input) From ebb23286d80f1df4588ad80a29f8c57bb803ca1c Mon Sep 17 00:00:00 2001 From: alyssa Date: Mon, 1 Sep 2025 03:36:13 +0000 Subject: [PATCH 21/40] chore: bump rust edition to 2024 --- .dockerignore | 1 + ci/Dockerfile.rust | 3 ++- crates/api/Cargo.toml | 2 +- crates/api/src/endpoints/private.rs | 3 ++- crates/api/src/endpoints/system.rs | 6 +++--- crates/api/src/main.rs | 6 ++---- crates/api/src/middleware/auth.rs | 2 +- crates/api/src/middleware/logger.rs | 2 +- crates/api/src/middleware/params.rs | 6 +++--- crates/api/src/util.rs | 2 +- crates/avatars/Cargo.toml | 2 +- crates/avatars/src/main.rs | 4 ++-- crates/avatars/src/process.rs | 2 +- crates/avatars/src/pull.rs | 4 ++-- crates/dispatch/Cargo.toml | 2 +- crates/dispatch/src/logger.rs | 2 +- crates/dispatch/src/main.rs | 9 ++++----- crates/gateway/Cargo.toml | 2 +- crates/gateway/src/api.rs | 6 +++--- crates/gateway/src/discord/cache.rs | 4 ++-- crates/gateway/src/discord/gateway.rs | 6 +++--- crates/gateway/src/event_awaiter.rs | 12 +++++++++--- crates/gateway/src/logger.rs | 2 +- crates/gateway/src/main.rs | 3 +-- crates/gdpr_worker/Cargo.toml | 2 +- crates/gdpr_worker/src/main.rs | 4 +--- crates/libpk/Cargo.toml | 2 +- crates/libpk/src/_config.rs | 6 +++--- crates/libpk/src/db/repository/avatars.rs | 2 +- crates/libpk/src/db/types/avatars.rs | 2 +- crates/libpk/src/lib.rs | 3 +-- crates/macros/Cargo.toml | 2 +- crates/macros/src/api.rs | 4 ++-- crates/macros/src/model.rs | 2 +- crates/migrate/Cargo.toml | 2 +- crates/migrate/src/main.rs | 2 -- crates/models/Cargo.toml | 2 +- crates/models/src/lib.rs | 2 +- crates/scheduled_tasks/Cargo.toml | 2 +- flake.nix | 4 +--- rust-toolchain.toml | 3 +++ 41 files changed, 70 insertions(+), 69 deletions(-) create mode 100644 rust-toolchain.toml diff --git a/.dockerignore b/.dockerignore index ee5756d6..43d7d2ca 100644 --- a/.dockerignore +++ b/.dockerignore @@ -11,6 +11,7 @@ !Cargo.toml !Cargo.lock +!rust-toolchain.toml !PluralKit.sln !nuget.config !ci/dotnet-version.sh diff --git a/ci/Dockerfile.rust b/ci/Dockerfile.rust index e320fb00..b51ea03a 100644 --- a/ci/Dockerfile.rust +++ b/ci/Dockerfile.rust @@ -4,7 +4,8 @@ WORKDIR /build RUN apk add rustup build-base # todo: arm64 target -RUN rustup-init --default-host x86_64-unknown-linux-musl --default-toolchain nightly-2024-08-20 --profile default -y +COPY rust-toolchain.toml . +RUN rustup-init --no-update-default-toolchain -y ENV PATH=/root/.cargo/bin:$PATH ENV RUSTFLAGS='-C link-arg=-s' diff --git a/crates/api/Cargo.toml b/crates/api/Cargo.toml index 9413d62c..b19bfe74 100644 --- a/crates/api/Cargo.toml +++ b/crates/api/Cargo.toml @@ -1,7 +1,7 @@ [package] name = "api" version = "0.1.0" -edition = "2021" +edition = "2024" [dependencies] pluralkit_models = { path = "../models" } diff --git a/crates/api/src/endpoints/private.rs b/crates/api/src/endpoints/private.rs index 067fef57..2116e3c5 100644 --- a/crates/api/src/endpoints/private.rs +++ b/crates/api/src/endpoints/private.rs @@ -4,9 +4,10 @@ use fred::interfaces::*; use libpk::state::ShardState; use pk_macros::api_endpoint; use serde::Deserialize; -use serde_json::{json, Value}; +use serde_json::{Value, json}; use std::collections::HashMap; +#[allow(dead_code)] #[derive(Deserialize)] #[serde(rename_all = "PascalCase")] struct ClusterStats { diff --git a/crates/api/src/endpoints/system.rs b/crates/api/src/endpoints/system.rs index 7b919df5..58c9a154 100644 --- a/crates/api/src/endpoints/system.rs +++ b/crates/api/src/endpoints/system.rs @@ -1,11 +1,11 @@ -use axum::{extract::State, response::IntoResponse, Extension, Json}; +use axum::{Extension, Json, extract::State, response::IntoResponse}; use pk_macros::api_endpoint; -use serde_json::{json, Value}; +use serde_json::{Value, json}; use sqlx::Postgres; use pluralkit_models::{PKSystem, PKSystemConfig, PrivacyLevel}; -use crate::{auth::AuthState, error::fail, ApiContext}; +use crate::{ApiContext, auth::AuthState, error::fail}; #[api_endpoint] pub async fn get_system_settings( diff --git a/crates/api/src/main.rs b/crates/api/src/main.rs index 07e47f89..f22450ce 100644 --- a/crates/api/src/main.rs +++ b/crates/api/src/main.rs @@ -1,16 +1,14 @@ -#![feature(let_chains)] - use auth::{AuthState, INTERNAL_APPID_HEADER, INTERNAL_SYSTEMID_HEADER}; use axum::{ + Extension, Router, body::Body, extract::{Request as ExtractRequest, State}, http::Uri, response::{IntoResponse, Response}, routing::{delete, get, patch, post}, - Extension, Router, }; use hyper_util::{ - client::legacy::{connect::HttpConnector, Client}, + client::legacy::{Client, connect::HttpConnector}, rt::TokioExecutor, }; use tracing::info; diff --git a/crates/api/src/middleware/auth.rs b/crates/api/src/middleware/auth.rs index 0992757f..1d536e97 100644 --- a/crates/api/src/middleware/auth.rs +++ b/crates/api/src/middleware/auth.rs @@ -10,7 +10,7 @@ use subtle::ConstantTimeEq; use tracing::error; use crate::auth::AuthState; -use crate::{util::json_err, ApiContext}; +use crate::{ApiContext, util::json_err}; pub async fn auth(State(ctx): State, mut req: Request, next: Next) -> Response { let mut authed_system_id: Option = None; diff --git a/crates/api/src/middleware/logger.rs b/crates/api/src/middleware/logger.rs index 38e45e2c..512234bb 100644 --- a/crates/api/src/middleware/logger.rs +++ b/crates/api/src/middleware/logger.rs @@ -2,7 +2,7 @@ use std::time::Instant; use axum::{extract::MatchedPath, extract::Request, middleware::Next, response::Response}; use metrics::{counter, histogram}; -use tracing::{info, span, warn, Instrument, Level}; +use tracing::{Instrument, Level, info, span, warn}; use crate::{auth::AuthState, util::header_or_unknown}; diff --git a/crates/api/src/middleware/params.rs b/crates/api/src/middleware/params.rs index 06a76f64..1b52bfbf 100644 --- a/crates/api/src/middleware/params.rs +++ b/crates/api/src/middleware/params.rs @@ -6,11 +6,11 @@ use axum::{ routing::url_params::UrlParams, }; -use sqlx::{types::Uuid, Postgres}; +use sqlx::{Postgres, types::Uuid}; use tracing::error; use crate::auth::AuthState; -use crate::{util::json_err, ApiContext}; +use crate::{ApiContext, util::json_err}; use pluralkit_models::PKSystem; // move this somewhere else @@ -31,7 +31,7 @@ pub async fn params(State(ctx): State, mut req: Request, next: Next) StatusCode::BAD_REQUEST, r#"{"message":"400: Bad Request","code": 0}"#.to_string(), ) - .into() + .into(); } }; diff --git a/crates/api/src/util.rs b/crates/api/src/util.rs index 35a5bf0d..e9723976 100644 --- a/crates/api/src/util.rs +++ b/crates/api/src/util.rs @@ -3,7 +3,7 @@ use axum::{ http::{HeaderValue, StatusCode}, response::IntoResponse, }; -use serde_json::{json, to_string, Value}; +use serde_json::{Value, json, to_string}; use tracing::error; pub fn header_or_unknown(header: Option<&HeaderValue>) -> &str { diff --git a/crates/avatars/Cargo.toml b/crates/avatars/Cargo.toml index 725e5396..ee1aa91e 100644 --- a/crates/avatars/Cargo.toml +++ b/crates/avatars/Cargo.toml @@ -1,7 +1,7 @@ [package] name = "avatars" version = "0.1.0" -edition = "2021" +edition = "2024" [[bin]] name = "avatar_cleanup" diff --git a/crates/avatars/src/main.rs b/crates/avatars/src/main.rs index c8399086..df80ac82 100644 --- a/crates/avatars/src/main.rs +++ b/crates/avatars/src/main.rs @@ -8,10 +8,10 @@ use anyhow::Context; use axum::extract::State; use axum::routing::get; use axum::{ + Json, Router, http::StatusCode, response::{IntoResponse, Response}, routing::post, - Json, Router, }; use libpk::_config::AvatarsConfig; use libpk::db::repository::avatars as db; @@ -153,7 +153,7 @@ async fn verify( ) .await?; - let encoded = process::process_async(result.data, req.kind).await?; + process::process_async(result.data, req.kind).await?; Ok(()) } diff --git a/crates/avatars/src/process.rs b/crates/avatars/src/process.rs index 024f40de..0c9ba8c1 100644 --- a/crates/avatars/src/process.rs +++ b/crates/avatars/src/process.rs @@ -4,7 +4,7 @@ use std::io::Cursor; use std::time::Instant; use tracing::{debug, error, info, instrument}; -use crate::{hash::Hash, ImageKind, PKAvatarError}; +use crate::{ImageKind, PKAvatarError, hash::Hash}; const MAX_DIMENSION: u32 = 4000; diff --git a/crates/avatars/src/pull.rs b/crates/avatars/src/pull.rs index fdf5f073..44c4a952 100644 --- a/crates/avatars/src/pull.rs +++ b/crates/avatars/src/pull.rs @@ -62,7 +62,7 @@ pub async fn pull( let size = match response.content_length() { None => return Err(PKAvatarError::MissingHeader("Content-Length")), Some(size) if size > MAX_SIZE => { - return Err(PKAvatarError::ImageFileSizeTooLarge(size, MAX_SIZE)) + return Err(PKAvatarError::ImageFileSizeTooLarge(size, MAX_SIZE)); } Some(size) => size, }; @@ -162,7 +162,7 @@ pub fn parse_url(url: &str) -> anyhow::Result { attachment_id: 0, filename: "".to_string(), full_url: url.to_string(), - }) + }); } _ => anyhow::bail!("not a discord cdn url"), } diff --git a/crates/dispatch/Cargo.toml b/crates/dispatch/Cargo.toml index c76856d1..f48acf8c 100644 --- a/crates/dispatch/Cargo.toml +++ b/crates/dispatch/Cargo.toml @@ -1,7 +1,7 @@ [package] name = "dispatch" version = "0.1.0" -edition = "2021" +edition = "2024" [dependencies] anyhow = { workspace = true } diff --git a/crates/dispatch/src/logger.rs b/crates/dispatch/src/logger.rs index aa65bc67..ec2576b6 100644 --- a/crates/dispatch/src/logger.rs +++ b/crates/dispatch/src/logger.rs @@ -1,7 +1,7 @@ use std::time::Instant; use axum::{extract::MatchedPath, extract::Request, middleware::Next, response::Response}; -use tracing::{info, span, warn, Instrument, Level}; +use tracing::{Instrument, Level, info, span, warn}; // log any requests that take longer than 2 seconds // todo: change as necessary diff --git a/crates/dispatch/src/main.rs b/crates/dispatch/src/main.rs index 6570cf19..3a3403bd 100644 --- a/crates/dispatch/src/main.rs +++ b/crates/dispatch/src/main.rs @@ -5,17 +5,16 @@ use hickory_client::{ rr::{DNSClass, Name, RData, RecordType}, udp::UdpClientStream, }; -use reqwest::{redirect::Policy, StatusCode}; +use reqwest::{StatusCode, redirect::Policy}; use std::{ net::{Ipv4Addr, SocketAddr, SocketAddrV4}, sync::Arc, time::Duration, }; use tokio::{net::UdpSocket, sync::RwLock}; -use tracing::{debug, error, info}; -use tracing_subscriber::EnvFilter; +use tracing::{debug, error}; -use axum::{extract::State, http::Uri, routing::post, Json, Router}; +use axum::{Json, Router, extract::State, http::Uri, routing::post}; mod logger; @@ -128,7 +127,7 @@ async fn dispatch( match res { Ok(res) if res.status() != 200 => { - return DispatchResponse::InvalidResponseCode(res.status()).to_string() + return DispatchResponse::InvalidResponseCode(res.status()).to_string(); } Err(error) => { error!(?error, url = req.url.clone(), "failed to fetch"); diff --git a/crates/gateway/Cargo.toml b/crates/gateway/Cargo.toml index c707b29b..0222ab18 100644 --- a/crates/gateway/Cargo.toml +++ b/crates/gateway/Cargo.toml @@ -1,7 +1,7 @@ [package] name = "gateway" version = "0.1.0" -edition = "2021" +edition = "2024" [dependencies] anyhow = { workspace = true } diff --git a/crates/gateway/src/api.rs b/crates/gateway/src/api.rs index f8c3f556..aa2d069e 100644 --- a/crates/gateway/src/api.rs +++ b/crates/gateway/src/api.rs @@ -1,18 +1,18 @@ use axum::{ + Router, extract::{ConnectInfo, Path, State}, http::StatusCode, response::{IntoResponse, Response}, routing::{delete, get, post}, - Router, }; use libpk::runtime_config::RuntimeConfig; use serde_json::{json, to_string}; use tracing::{error, info}; -use twilight_model::id::{marker::ChannelMarker, Id}; +use twilight_model::id::{Id, marker::ChannelMarker}; use crate::{ discord::{ - cache::{dm_channel, DiscordCache, DM_PERMISSIONS}, + cache::{DM_PERMISSIONS, DiscordCache, dm_channel}, gateway::cluster_config, shard_state::ShardStateManager, }, diff --git a/crates/gateway/src/discord/cache.rs b/crates/gateway/src/discord/cache.rs index e0a4aacf..cc538d08 100644 --- a/crates/gateway/src/discord/cache.rs +++ b/crates/gateway/src/discord/cache.rs @@ -4,18 +4,18 @@ use serde::Serialize; use std::{collections::HashMap, sync::Arc}; use tokio::sync::RwLock; use twilight_cache_inmemory::{ + InMemoryCache, ResourceType, model::CachedMember, permission::{MemberRoles, RootError}, traits::CacheableChannel, - InMemoryCache, ResourceType, }; use twilight_gateway::Event; use twilight_model::{ channel::{Channel, ChannelType}, guild::{Guild, Member, Permissions}, id::{ - marker::{ChannelMarker, GuildMarker, MessageMarker, UserMarker}, Id, + marker::{ChannelMarker, GuildMarker, MessageMarker, UserMarker}, }, }; use twilight_util::permission_calculator::PermissionCalculator; diff --git a/crates/gateway/src/discord/gateway.rs b/crates/gateway/src/discord/gateway.rs index 8210e06e..215fb4cf 100644 --- a/crates/gateway/src/discord/gateway.rs +++ b/crates/gateway/src/discord/gateway.rs @@ -6,17 +6,17 @@ use std::sync::Arc; use tokio::sync::mpsc::Sender; use tracing::{error, info, warn}; use twilight_gateway::{ - create_iterator, CloseFrame, ConfigBuilder, Event, EventTypeFlags, Message, Shard, ShardId, + CloseFrame, ConfigBuilder, Event, EventTypeFlags, Message, Shard, ShardId, create_iterator, }; use twilight_model::gateway::{ + Intents, payload::outgoing::update_presence::UpdatePresencePayload, presence::{Activity, ActivityType, Status}, - Intents, }; use crate::{ - discord::identify_queue::{self, RedisQueue}, RUNTIME_CONFIG_KEY_EVENT_TARGET, + discord::identify_queue::{self, RedisQueue}, }; use super::cache::DiscordCache; diff --git a/crates/gateway/src/event_awaiter.rs b/crates/gateway/src/event_awaiter.rs index 765ad8e5..97a6955e 100644 --- a/crates/gateway/src/event_awaiter.rs +++ b/crates/gateway/src/event_awaiter.rs @@ -3,7 +3,7 @@ // - interaction: (custom_id where not_includes "help-menu") use std::{ - collections::{hash_map::Entry, HashMap}, + collections::{HashMap, hash_map::Entry}, net::{IpAddr, SocketAddr}, time::Duration, }; @@ -15,8 +15,8 @@ use twilight_gateway::Event; use twilight_model::{ application::interaction::InteractionData, id::{ - marker::{ChannelMarker, MessageMarker, UserMarker}, Id, + marker::{ChannelMarker, MessageMarker, UserMarker}, }, }; @@ -103,7 +103,13 @@ impl EventAwaiter { } } } - info!("ran event_awaiter cleanup loop, took {}us, {} reactions, {} messages, {} interactions", Instant::now().duration_since(now).as_micros(), counts.0, counts.1, counts.2); + info!( + "ran event_awaiter cleanup loop, took {}us, {} reactions, {} messages, {} interactions", + Instant::now().duration_since(now).as_micros(), + counts.0, + counts.1, + counts.2 + ); } } diff --git a/crates/gateway/src/logger.rs b/crates/gateway/src/logger.rs index 459aef31..0a081432 100644 --- a/crates/gateway/src/logger.rs +++ b/crates/gateway/src/logger.rs @@ -4,7 +4,7 @@ use axum::{ extract::MatchedPath, extract::Request, http::StatusCode, middleware::Next, response::Response, }; use metrics::{counter, histogram}; -use tracing::{info, span, warn, Instrument, Level}; +use tracing::{Instrument, Level, info, span, warn}; // log any requests that take longer than 2 seconds // todo: change as necessary diff --git a/crates/gateway/src/main.rs b/crates/gateway/src/main.rs index 12db76b5..3ac7be21 100644 --- a/crates/gateway/src/main.rs +++ b/crates/gateway/src/main.rs @@ -1,4 +1,3 @@ -#![feature(let_chains)] #![feature(if_let_guard)] #![feature(duration_constructors)] @@ -10,7 +9,7 @@ use libpk::{runtime_config::RuntimeConfig, state::ShardStateEvent}; use reqwest::{ClientBuilder, StatusCode}; use std::{sync::Arc, time::Duration, vec::Vec}; use tokio::{ - signal::unix::{signal, SignalKind}, + signal::unix::{SignalKind, signal}, sync::mpsc::channel, task::JoinSet, }; diff --git a/crates/gdpr_worker/Cargo.toml b/crates/gdpr_worker/Cargo.toml index a30751f9..b57ccddf 100644 --- a/crates/gdpr_worker/Cargo.toml +++ b/crates/gdpr_worker/Cargo.toml @@ -1,7 +1,7 @@ [package] name = "gdpr_worker" version = "0.1.0" -edition = "2021" +edition = "2024" [dependencies] libpk = { path = "../libpk" } diff --git a/crates/gdpr_worker/src/main.rs b/crates/gdpr_worker/src/main.rs index b40557c0..bcedbedd 100644 --- a/crates/gdpr_worker/src/main.rs +++ b/crates/gdpr_worker/src/main.rs @@ -1,12 +1,10 @@ -#![feature(let_chains)] - use sqlx::prelude::FromRow; use std::{sync::Arc, time::Duration}; use tracing::{error, info, warn}; use twilight_http::api_error::{ApiError, GeneralApiError}; use twilight_model::id::{ - marker::{ChannelMarker, MessageMarker}, Id, + marker::{ChannelMarker, MessageMarker}, }; // create table messages_gdpr_jobs (mid bigint not null references messages(mid) on delete cascade, channel bigint not null); diff --git a/crates/libpk/Cargo.toml b/crates/libpk/Cargo.toml index 30d77ae0..1f0c3c42 100644 --- a/crates/libpk/Cargo.toml +++ b/crates/libpk/Cargo.toml @@ -1,7 +1,7 @@ [package] name = "libpk" version = "0.1.0" -edition = "2021" +edition = "2024" [dependencies] anyhow = { workspace = true } diff --git a/crates/libpk/src/_config.rs b/crates/libpk/src/_config.rs index 7f992d95..f21d9adf 100644 --- a/crates/libpk/src/_config.rs +++ b/crates/libpk/src/_config.rs @@ -3,7 +3,7 @@ use lazy_static::lazy_static; use serde::Deserialize; use std::sync::Arc; -use twilight_model::id::{marker::UserMarker, Id}; +use twilight_model::id::{Id, marker::UserMarker}; #[derive(Clone, Deserialize, Debug)] pub struct ClusterSettings { @@ -151,11 +151,11 @@ lazy_static! { // hacks if let Ok(var) = std::env::var("NOMAD_ALLOC_INDEX") && std::env::var("pluralkit__discord__cluster__total_nodes").is_ok() { - std::env::set_var("pluralkit__discord__cluster__node_id", var); + unsafe { std::env::set_var("pluralkit__discord__cluster__node_id", var); } } if let Ok(var) = std::env::var("STATEFULSET_NAME_FOR_INDEX") && std::env::var("pluralkit__discord__cluster__total_nodes").is_ok() { - std::env::set_var("pluralkit__discord__cluster__node_id", var.split("-").last().unwrap()); + unsafe { std::env::set_var("pluralkit__discord__cluster__node_id", var.split("-").last().unwrap()); } } Arc::new(Config::builder() diff --git a/crates/libpk/src/db/repository/avatars.rs b/crates/libpk/src/db/repository/avatars.rs index 1ff10cc7..9a667c11 100644 --- a/crates/libpk/src/db/repository/avatars.rs +++ b/crates/libpk/src/db/repository/avatars.rs @@ -52,7 +52,7 @@ pub async fn remove_deletion_queue(pool: &PgPool, attachment_id: u64) -> anyhow: pub async fn pop_queue( pool: &PgPool, -) -> anyhow::Result, ImageQueueEntry)>> { +) -> anyhow::Result, ImageQueueEntry)>> { let mut tx = pool.begin().await?; let res: Option = sqlx::query_as("delete from image_queue where itemid = (select itemid from image_queue order by itemid for update skip locked limit 1) returning *") .fetch_optional(&mut *tx).await?; diff --git a/crates/libpk/src/db/types/avatars.rs b/crates/libpk/src/db/types/avatars.rs index aea6aafd..0b07fbb2 100644 --- a/crates/libpk/src/db/types/avatars.rs +++ b/crates/libpk/src/db/types/avatars.rs @@ -1,7 +1,7 @@ use serde::{Deserialize, Serialize}; use sqlx::{ - types::chrono::{DateTime, Utc}, FromRow, + types::chrono::{DateTime, Utc}, }; use uuid::Uuid; diff --git a/crates/libpk/src/lib.rs b/crates/libpk/src/lib.rs index 55031bf3..137eb94d 100644 --- a/crates/libpk/src/lib.rs +++ b/crates/libpk/src/lib.rs @@ -1,9 +1,8 @@ -#![feature(let_chains)] use std::net::SocketAddr; use metrics_exporter_prometheus::PrometheusBuilder; use sentry::IntoDsn; -use tracing_subscriber::{layer::SubscriberExt, util::SubscriberInitExt, EnvFilter}; +use tracing_subscriber::{EnvFilter, layer::SubscriberExt, util::SubscriberInitExt}; use sentry_tracing::event_from_event; diff --git a/crates/macros/Cargo.toml b/crates/macros/Cargo.toml index 10feaf88..7f320881 100644 --- a/crates/macros/Cargo.toml +++ b/crates/macros/Cargo.toml @@ -1,7 +1,7 @@ [package] name = "pk_macros" version = "0.1.0" -edition = "2021" +edition = "2024" [lib] proc-macro = true diff --git a/crates/macros/src/api.rs b/crates/macros/src/api.rs index 7f797b8c..8094b9ea 100644 --- a/crates/macros/src/api.rs +++ b/crates/macros/src/api.rs @@ -1,7 +1,7 @@ use quote::quote; -use syn::{parse_macro_input, FnArg, ItemFn, Pat}; +use syn::{FnArg, ItemFn, Pat, parse_macro_input}; -fn pretty_print(ts: &proc_macro2::TokenStream) -> String { +fn _pretty_print(ts: &proc_macro2::TokenStream) -> String { let file = syn::parse_file(&ts.to_string()).unwrap(); prettyplease::unparse(&file) } diff --git a/crates/macros/src/model.rs b/crates/macros/src/model.rs index 924b5bcd..e37d0dde 100644 --- a/crates/macros/src/model.rs +++ b/crates/macros/src/model.rs @@ -1,6 +1,6 @@ use proc_macro2::{Span, TokenStream}; use quote::quote; -use syn::{parse_macro_input, DeriveInput, Expr, Ident, Meta, Type}; +use syn::{DeriveInput, Expr, Ident, Meta, Type, parse_macro_input}; #[derive(Clone, Debug)] enum ElemPatchability { diff --git a/crates/migrate/Cargo.toml b/crates/migrate/Cargo.toml index cf4eff2d..0843cb3f 100644 --- a/crates/migrate/Cargo.toml +++ b/crates/migrate/Cargo.toml @@ -1,7 +1,7 @@ [package] name = "migrate" version = "0.1.0" -edition = "2021" +edition = "2024" [dependencies] libpk = { path = "../libpk" } diff --git a/crates/migrate/src/main.rs b/crates/migrate/src/main.rs index 85b15e33..0ee621e2 100644 --- a/crates/migrate/src/main.rs +++ b/crates/migrate/src/main.rs @@ -1,5 +1,3 @@ -#![feature(let_chains)] - use tracing::info; include!(concat!(env!("OUT_DIR"), "/data.rs")); diff --git a/crates/models/Cargo.toml b/crates/models/Cargo.toml index 0fbc358c..752fbaa5 100644 --- a/crates/models/Cargo.toml +++ b/crates/models/Cargo.toml @@ -1,7 +1,7 @@ [package] name = "pluralkit_models" version = "0.1.0" -edition = "2021" +edition = "2024" [dependencies] chrono = { workspace = true, features = ["serde"] } diff --git a/crates/models/src/lib.rs b/crates/models/src/lib.rs index 0bd1f92b..08350488 100644 --- a/crates/models/src/lib.rs +++ b/crates/models/src/lib.rs @@ -18,7 +18,7 @@ pub enum PrivacyLevel { } // this sucks, put it somewhere else -use sqlx::{postgres::PgTypeInfo, Database, Decode, Postgres, Type}; +use sqlx::{Database, Decode, Postgres, Type, postgres::PgTypeInfo}; use std::error::Error; _util::fake_enum_impls!(PrivacyLevel); diff --git a/crates/scheduled_tasks/Cargo.toml b/crates/scheduled_tasks/Cargo.toml index 624db0e8..1e86f2c3 100644 --- a/crates/scheduled_tasks/Cargo.toml +++ b/crates/scheduled_tasks/Cargo.toml @@ -1,7 +1,7 @@ [package] name = "scheduled_tasks" version = "0.1.0" -edition = "2021" +edition = "2024" [dependencies] libpk = { path = "../libpk" } diff --git a/flake.nix b/flake.nix index 85793415..c0a766da 100644 --- a/flake.nix +++ b/flake.nix @@ -72,9 +72,7 @@ programs.nixfmt.enable = true; }; - nci.toolchainConfig = { - channel = "nightly"; - }; + nci.toolchainConfig = ./rust-toolchain.toml; nci.projects."pluralkit-services" = { path = ./.; export = false; diff --git a/rust-toolchain.toml b/rust-toolchain.toml new file mode 100644 index 00000000..d573d1d3 --- /dev/null +++ b/rust-toolchain.toml @@ -0,0 +1,3 @@ +[toolchain] +channel = "nightly-2025-08-22" +components = ["rust-src", "rustfmt", "rust-analyzer"] From 695d1debf2fc6fc4ea390d480c5c1322152329cc Mon Sep 17 00:00:00 2001 From: alyssa Date: Wed, 3 Sep 2025 00:43:56 +0000 Subject: [PATCH 22/40] chore: update recovery message on dashboard --- dashboard/src/routes/Settings/Settings.svelte | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dashboard/src/routes/Settings/Settings.svelte b/dashboard/src/routes/Settings/Settings.svelte index 62ce89b6..c2e8d333 100644 --- a/dashboard/src/routes/Settings/Settings.svelte +++ b/dashboard/src/routes/Settings/Settings.svelte @@ -154,7 +154,7 @@

If you've lost access to your discord account, you can retrieve your token here.

-

Send a direct message to a staff member (a helper, moderator or developer in the support server), they can recover your system with this token.

+

Ask in the #bot-support channel of the support server for a staff member to DM you, they can recover your system with this token. Do not post the token in the channel.

{#if showToken} From fbf51b41c1c7d218b3dc3c914d9d3ed8dcff1980 Mon Sep 17 00:00:00 2001 From: Iris System Date: Sun, 7 Sep 2025 10:16:50 +1200 Subject: [PATCH 23/40] feat(bot): ComponentsV2 system/member/group cards --- Cargo.toml | 2 +- Myriad/Rest/Types/Requests/MessageRequest.cs | 1 + Myriad/Types/Component/ComponentMedia.cs | 13 + Myriad/Types/Component/ComponentType.cs | 9 +- Myriad/Types/Component/MessageComponent.cs | 6 + Myriad/Types/Message.cs | 3 +- PluralKit.Bot/ApplicationCommands/Message.cs | 3 +- PluralKit.Bot/CommandMeta/CommandTree.cs | 2 + .../CommandSystem/Context/Context.cs | 35 ++ PluralKit.Bot/Commands/Config.cs | 21 + PluralKit.Bot/Commands/Groups.cs | 8 +- PluralKit.Bot/Commands/Member.cs | 10 +- PluralKit.Bot/Commands/Random.cs | 38 +- PluralKit.Bot/Commands/System.cs | 7 +- PluralKit.Bot/Handlers/InteractionCreated.cs | 3 +- PluralKit.Bot/Services/EmbedService.cs | 440 +++++++++++++++++- PluralKit.Core/CoreConfig.cs | 1 + .../Models/Patch/SystemConfigPatch.cs | 8 + PluralKit.Core/Models/SystemConfig.cs | 2 + crates/migrate/data/migrations/53.sql | 6 + 20 files changed, 600 insertions(+), 18 deletions(-) create mode 100644 Myriad/Types/Component/ComponentMedia.cs create mode 100644 crates/migrate/data/migrations/53.sql diff --git a/Cargo.toml b/Cargo.toml index 270d00a6..444bcee6 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -17,7 +17,7 @@ reqwest = { version = "0.12.7" , default-features = false, features = ["rustls-t sentry = { version = "0.36.0", default-features = false, features = ["backtrace", "contexts", "panic", "debug-images", "reqwest", "rustls"] } # replace native-tls with rustls serde = { version = "1.0.196", features = ["derive"] } serde_json = "1.0.117" -sqlx = { version = "0.8.2", features = ["runtime-tokio", "postgres", "time", "macros", "uuid"] } +sqlx = { version = "0.8.2", features = ["runtime-tokio", "postgres", "time", "chrono", "macros", "uuid"] } tokio = { version = "1.36.0", features = ["full"] } tracing = "0.1" tracing-subscriber = { version = "0.3.16", features = ["env-filter", "json"] } diff --git a/Myriad/Rest/Types/Requests/MessageRequest.cs b/Myriad/Rest/Types/Requests/MessageRequest.cs index d403f8ae..97b272b2 100644 --- a/Myriad/Rest/Types/Requests/MessageRequest.cs +++ b/Myriad/Rest/Types/Requests/MessageRequest.cs @@ -9,6 +9,7 @@ public record MessageRequest public bool Tts { get; set; } public AllowedMentions? AllowedMentions { get; set; } public Embed[]? Embeds { get; set; } + public Message.MessageFlags Flags { get; set; } public MessageComponent[]? Components { get; set; } public Message.Reference? MessageReference { get; set; } } \ No newline at end of file diff --git a/Myriad/Types/Component/ComponentMedia.cs b/Myriad/Types/Component/ComponentMedia.cs new file mode 100644 index 00000000..77a3b50e --- /dev/null +++ b/Myriad/Types/Component/ComponentMedia.cs @@ -0,0 +1,13 @@ +namespace Myriad.Types; + +public record ComponentMedia +{ + public string? Url { get; init; } +} + +public record ComponentMediaItem +{ + public ComponentMedia Media { get; init; } + public string? Description { get; init; } + public bool Spoiler { get; init; } = false; +} \ No newline at end of file diff --git a/Myriad/Types/Component/ComponentType.cs b/Myriad/Types/Component/ComponentType.cs index 0b10a756..61578dbb 100644 --- a/Myriad/Types/Component/ComponentType.cs +++ b/Myriad/Types/Component/ComponentType.cs @@ -3,5 +3,12 @@ namespace Myriad.Types; public enum ComponentType { ActionRow = 1, - Button = 2 + Button = 2, + StringSelect = 3, + Section = 9, + Text = 10, + Thumbnail = 11, + MediaGallery = 12, + Separator = 14, + Container = 17, } \ No newline at end of file diff --git a/Myriad/Types/Component/MessageComponent.cs b/Myriad/Types/Component/MessageComponent.cs index 9421fb89..bc01bcbb 100644 --- a/Myriad/Types/Component/MessageComponent.cs +++ b/Myriad/Types/Component/MessageComponent.cs @@ -5,9 +5,15 @@ public record MessageComponent public ComponentType Type { get; init; } public ButtonStyle? Style { get; set; } public string? Label { get; init; } + public string? Content { get; init; } public Emoji? Emoji { get; init; } public string? CustomId { get; init; } public string? Url { get; init; } public bool? Disabled { get; init; } + public uint? AccentColor { get; init; } + public ComponentMedia? Media { get; init; } + public ComponentMediaItem[]? Items { get; init; } + + public MessageComponent? Accessory { get; init; } public MessageComponent[]? Components { get; init; } } \ No newline at end of file diff --git a/Myriad/Types/Message.cs b/Myriad/Types/Message.cs index 1b8f723e..10416676 100644 --- a/Myriad/Types/Message.cs +++ b/Myriad/Types/Message.cs @@ -17,6 +17,7 @@ public record Message Ephemeral = 1 << 6, SuppressNotifications = 1 << 12, VoiceMessage = 1 << 13, + IsComponentsV2 = 1 << 15, } public enum MessageType @@ -73,8 +74,6 @@ public record Message public MessagePoll? Poll { get; init; } - // public MessageComponent[]? Components { get; init; } - public record Reference(ulong? GuildId, ulong? ChannelId, ulong? MessageId); public record MessageActivity(int Type, string PartyId); diff --git a/PluralKit.Bot/ApplicationCommands/Message.cs b/PluralKit.Bot/ApplicationCommands/Message.cs index 2f7be692..15144717 100644 --- a/PluralKit.Bot/ApplicationCommands/Message.cs +++ b/PluralKit.Bot/ApplicationCommands/Message.cs @@ -139,7 +139,8 @@ public class ApplicationCommandProxiedMessage if (member == null || !(await _cache.PermissionsForMemberInChannel(ctx.GuildId, ctx.ChannelId, member)).HasFlag(requiredPerms)) { throw new PKError("You do not have permission to send messages in this channel."); - }; + } + ; var config = await _repo.GetSystemConfig(msg.System.Id); diff --git a/PluralKit.Bot/CommandMeta/CommandTree.cs b/PluralKit.Bot/CommandMeta/CommandTree.cs index 8d111ef4..67379fe1 100644 --- a/PluralKit.Bot/CommandMeta/CommandTree.cs +++ b/PluralKit.Bot/CommandMeta/CommandTree.cs @@ -592,6 +592,8 @@ public partial class CommandTree return ctx.Execute(null, m => m.HidDisplayCaps(ctx)); if (ctx.MatchMultiple(new[] { "pad" }, new[] { "id", "ids" }) || ctx.MatchMultiple(new[] { "id" }, new[] { "pad", "padding" }) || ctx.Match("idpad", "padid", "padids")) return ctx.Execute(null, m => m.HidListPadding(ctx)); + if (ctx.MatchMultiple(new[] { "show" }, new[] { "color", "colour", "colors", "colours" }) || ctx.Match("showcolor", "showcolour", "showcolors", "showcolours", "colorcode", "colorhex")) + return ctx.Execute(null, m => m.CardShowColorHex(ctx)); if (ctx.MatchMultiple(new[] { "name" }, new[] { "format" }) || ctx.Match("nameformat", "nf")) return ctx.Execute(null, m => m.NameFormat(ctx)); if (ctx.MatchMultiple(new[] { "member", "group" }, new[] { "limit" }) || ctx.Match("limit")) diff --git a/PluralKit.Bot/CommandSystem/Context/Context.cs b/PluralKit.Bot/CommandSystem/Context/Context.cs index 9bab740e..f155c8dc 100644 --- a/PluralKit.Bot/CommandSystem/Context/Context.cs +++ b/PluralKit.Bot/CommandSystem/Context/Context.cs @@ -119,6 +119,41 @@ public class Context return msg; } + public async Task Reply(MessageComponent[] components = null, AllowedMentions? mentions = null, MultipartFile[]? files = null) + { + var botPerms = await BotPermissions; + + if (!botPerms.HasFlag(PermissionSet.SendMessages)) + // Will be "swallowed" during the error handler anyway, this message is never shown. + throw new PKError("PluralKit does not have permission to send messages in this channel."); + + if (files != null && !botPerms.HasFlag(PermissionSet.AttachFiles)) + throw new PKError("PluralKit does not have permission to attach files in this channel. Please ensure I have the **Attach Files** permission enabled."); + + var msg = await Rest.CreateMessage(Channel.Id, new MessageRequest + { + Components = components, + Flags = Message.MessageFlags.IsComponentsV2, + + // Default to an empty allowed mentions object instead of null (which means no mentions allowed) + AllowedMentions = mentions ?? new AllowedMentions() + }, files: files); + + // store log of sent message, so it can be queried or deleted later + // skip DMs as DM messages can always be deleted + if (Guild != null) + await Repository.AddCommandMessage(new Core.CommandMessage + { + Mid = msg.Id, + Guild = Guild!.Id, + Channel = Channel.Id, + Sender = Author.Id, + OriginalMid = Message.Id, + }); + + return msg; + } + public async Task Execute(Command? commandDef, Func handler, bool deprecated = false) { _currentCommand = commandDef; diff --git a/PluralKit.Bot/Commands/Config.cs b/PluralKit.Bot/Commands/Config.cs index 1b8efab1..1feb7c37 100644 --- a/PluralKit.Bot/Commands/Config.cs +++ b/PluralKit.Bot/Commands/Config.cs @@ -123,6 +123,13 @@ public class Config "off" )); + items.Add(new( + "show color", + "Whether to show color codes in system/member/group cards", + EnabledDisabled(ctx.Config.CardShowColorHex), + "disabled" + )); + items.Add(new( "Proxy Switch", "Switching behavior when proxy tags are used", @@ -570,6 +577,20 @@ public class Config else throw new PKError(badInputError); } + public async Task CardShowColorHex(Context ctx) + { + if (!ctx.HasNext()) + { + var msg = $"Showing color codes on system/member/group cards is currently **{EnabledDisabled(ctx.Config.CardShowColorHex)}**."; + await ctx.Reply(msg); + return; + } + + var newVal = ctx.MatchToggle(false); + await ctx.Repository.UpdateSystemConfig(ctx.System.Id, new() { CardShowColorHex = newVal }); + await ctx.Reply($"Showing color codes on system/member/group cards is now {EnabledDisabled(newVal)}."); + } + public async Task ProxySwitch(Context ctx) { if (!ctx.HasNext()) diff --git a/PluralKit.Bot/Commands/Groups.cs b/PluralKit.Bot/Commands/Groups.cs index 45c5f8b4..b18764d2 100644 --- a/PluralKit.Bot/Commands/Groups.cs +++ b/PluralKit.Bot/Commands/Groups.cs @@ -520,7 +520,13 @@ public class Groups public async Task ShowGroupCard(Context ctx, PKGroup target) { var system = await GetGroupSystem(ctx, target); - await ctx.Reply(embed: await _embeds.CreateGroupEmbed(ctx, system, target)); + if (ctx.MatchFlag("show-embed", "se")) + { + await ctx.Reply(text: EmbedService.LEGACY_EMBED_WARNING, embed: await _embeds.CreateGroupEmbed(ctx, system, target)); + return; + } + + await ctx.Reply(components: await _embeds.CreateGroupMessageComponents(ctx, system, target)); } public async Task GroupPrivacy(Context ctx, PKGroup target, PrivacyLevel? newValueFromCommand) diff --git a/PluralKit.Bot/Commands/Member.cs b/PluralKit.Bot/Commands/Member.cs index 65931e13..37ab9d18 100644 --- a/PluralKit.Bot/Commands/Member.cs +++ b/PluralKit.Bot/Commands/Member.cs @@ -122,8 +122,16 @@ public class Member public async Task ViewMember(Context ctx, PKMember target) { var system = await ctx.Repository.GetSystem(target.System); + if (ctx.MatchFlag("show-embed", "se")) + { + await ctx.Reply( + text: EmbedService.LEGACY_EMBED_WARNING, + embed: await _embeds.CreateMemberEmbed(system, target, ctx.Guild, ctx.Config, ctx.LookupContextFor(system.Id), ctx.Zone)); + return; + } + await ctx.Reply( - embed: await _embeds.CreateMemberEmbed(system, target, ctx.Guild, ctx.Config, ctx.LookupContextFor(system.Id), ctx.Zone)); + components: await _embeds.CreateMemberMessageComponents(system, target, ctx.Guild, ctx.Config, ctx.LookupContextFor(system.Id), ctx.Zone)); } public async Task Soulscream(Context ctx, PKMember target) diff --git a/PluralKit.Bot/Commands/Random.cs b/PluralKit.Bot/Commands/Random.cs index 179d8fc5..4b0aa8a4 100644 --- a/PluralKit.Bot/Commands/Random.cs +++ b/PluralKit.Bot/Commands/Random.cs @@ -36,8 +36,17 @@ public class Random "This system has no members!"); var randInt = randGen.Next(members.Count); - await ctx.Reply(embed: await _embeds.CreateMemberEmbed(target, members[randInt], ctx.Guild, - ctx.Config, ctx.LookupContextFor(target.Id), ctx.Zone)); + + if (ctx.MatchFlag("show-embed", "se")) + { + await ctx.Reply( + text: EmbedService.LEGACY_EMBED_WARNING, + embed: await _embeds.CreateMemberEmbed(target, members[randInt], ctx.Guild, ctx.Config, ctx.LookupContextFor(target.Id), ctx.Zone)); + return; + } + + await ctx.Reply( + components: await _embeds.CreateMemberMessageComponents(target, members[randInt], ctx.Guild, ctx.Config, ctx.LookupContextFor(target.Id), ctx.Zone)); } public async Task Group(Context ctx, PKSystem target) @@ -60,7 +69,17 @@ public class Random $"This system has no groups!"); var randInt = randGen.Next(groups.Count()); - await ctx.Reply(embed: await _embeds.CreateGroupEmbed(ctx, target, groups.ToArray()[randInt])); + + if (ctx.MatchFlag("show-embed", "se")) + { + await ctx.Reply( + text: EmbedService.LEGACY_EMBED_WARNING, + embed: await _embeds.CreateGroupEmbed(ctx, target, groups.ToArray()[randInt])); + return; + } + + await ctx.Reply( + components: await _embeds.CreateGroupMessageComponents(ctx, target, groups.ToArray()[randInt])); } public async Task GroupMember(Context ctx, PKGroup group) @@ -92,7 +111,16 @@ public class Random system = await ctx.Repository.GetSystem(group.System); var randInt = randGen.Next(ms.Count); - await ctx.Reply(embed: await _embeds.CreateMemberEmbed(system, ms[randInt], ctx.Guild, - ctx.Config, ctx.LookupContextFor(group.System), ctx.Zone)); + + if (ctx.MatchFlag("show-embed", "se")) + { + await ctx.Reply( + text: EmbedService.LEGACY_EMBED_WARNING, + embed: await _embeds.CreateMemberEmbed(system, ms[randInt], ctx.Guild, ctx.Config, ctx.LookupContextFor(system.Id), ctx.Zone)); + return; + } + + await ctx.Reply( + components: await _embeds.CreateMemberMessageComponents(system, ms[randInt], ctx.Guild, ctx.Config, ctx.LookupContextFor(system.Id), ctx.Zone)); } } \ No newline at end of file diff --git a/PluralKit.Bot/Commands/System.cs b/PluralKit.Bot/Commands/System.cs index efeeb0f1..2160dfd1 100644 --- a/PluralKit.Bot/Commands/System.cs +++ b/PluralKit.Bot/Commands/System.cs @@ -17,8 +17,13 @@ public class System public async Task Query(Context ctx, PKSystem system) { if (system == null) throw Errors.NoSystemError(ctx.DefaultPrefix); + if (ctx.MatchFlag("show-embed", "se")) + { + await ctx.Reply(text: EmbedService.LEGACY_EMBED_WARNING, embed: await _embeds.CreateSystemEmbed(ctx, system, ctx.LookupContextFor(system.Id))); + return; + } - await ctx.Reply(embed: await _embeds.CreateSystemEmbed(ctx, system, ctx.LookupContextFor(system.Id))); + await ctx.Reply(components: await _embeds.CreateSystemMessageComponents(ctx, system, ctx.LookupContextFor(system.Id))); } public async Task New(Context ctx) diff --git a/PluralKit.Bot/Handlers/InteractionCreated.cs b/PluralKit.Bot/Handlers/InteractionCreated.cs index becd70d6..57f7090a 100644 --- a/PluralKit.Bot/Handlers/InteractionCreated.cs +++ b/PluralKit.Bot/Handlers/InteractionCreated.cs @@ -61,6 +61,7 @@ public class InteractionCreated: IEventHandler // got some unhandled command, log and ignore _logger.Warning(@"Unhandled ApplicationCommand interaction: {EventId} {CommandName}", evt.Id, evt.Data?.Name); break; - }; + } + ; } } \ No newline at end of file diff --git a/PluralKit.Bot/Services/EmbedService.cs b/PluralKit.Bot/Services/EmbedService.cs index 186e3a45..39e85a37 100644 --- a/PluralKit.Bot/Services/EmbedService.cs +++ b/PluralKit.Bot/Services/EmbedService.cs @@ -15,17 +15,21 @@ namespace PluralKit.Bot; public class EmbedService { + public const string LEGACY_EMBED_WARNING = "\u26A0\uFE0F The \"legacy\" embeds for system/member/group cards are deprecated, and will be removed in future."; + private readonly IDiscordCache _cache; private readonly IDatabase _db; private readonly ModelRepository _repo; private readonly DiscordApiClient _rest; + private readonly CoreConfig _coreConfig; - public EmbedService(IDatabase db, ModelRepository repo, IDiscordCache cache, DiscordApiClient rest) + public EmbedService(IDatabase db, ModelRepository repo, IDiscordCache cache, DiscordApiClient rest, CoreConfig coreConfig) { _db = db; _repo = repo; _cache = cache; _rest = rest; + _coreConfig = coreConfig; } private Task<(ulong Id, User? User)[]> GetUsers(IEnumerable ids) @@ -39,6 +43,169 @@ public class EmbedService return Task.WhenAll(ids.Select(Inner)); } + public async Task CreateSystemMessageComponents(Context cctx, PKSystem system, LookupContext ctx) + { + // Fetch/render info for all accounts simultaneously + var accounts = await _repo.GetSystemAccounts(system.Id); + var users = (await GetUsers(accounts)).Select(x => x.User?.NameAndMention() ?? $"(deleted account {x.Id})"); + var linkedAccounts = new MessageComponent() + { + Type = ComponentType.Text, + Content = "**Linked accounts:**\n" + string.Join("\n", users).Truncate(1000), + }; + + var countctx = LookupContext.ByNonOwner; + if (cctx.MatchFlag("a", "all")) + { + if (system.Id == cctx.System.Id) + countctx = LookupContext.ByOwner; + else + throw Errors.LookupNotAllowed; + } + + var memberCount = await _repo.GetSystemMemberCount(system.Id, countctx == LookupContext.ByOwner ? null : PrivacyLevel.Public); + var guildSettings = cctx.Guild != null ? await _repo.GetSystemGuild(cctx.Guild.Id, system.Id) : null; + + var avatar = system.AvatarFor(ctx); + var headerText = ""; + + if (system.PronounPrivacy.CanAccess(ctx) && system.Pronouns != null) + headerText += $"\n**Pronouns:** {system.Pronouns}"; + + if (system.Tag != null) + headerText += $"\n**Tag:** {system.Tag.EscapeMarkdown()}"; + + if (cctx.Config.CardShowColorHex && !system.Color.EmptyOrNull()) + headerText += $"\n**Color:** #{system.Color}"; + + if (cctx.Guild != null) + { + if (guildSettings.Tag != null && guildSettings.TagEnabled) + headerText += $"\n**Tag (in server '{cctx.Guild.Name}'):** {guildSettings.Tag.EscapeMarkdown()}"; + if (!guildSettings.TagEnabled) + headerText += $"\n**Tag (in server '{cctx.Guild.Name}'):** *(tag is disabled in this server)*"; + } + + if (system.MemberListPrivacy.CanAccess(ctx)) + { + headerText += $"\n**Members:** {memberCount}"; + if (system.Id == cctx.System.Id) + if (memberCount > 0) + headerText += $" (see `{cctx.DefaultPrefix}system list`)"; + else + headerText += $" (add one with `{cctx.DefaultPrefix}member new`!)"; + else if (memberCount > 0) + headerText += $" (see `{cctx.DefaultPrefix}system {system.DisplayHid(cctx.Config)} list`)"; + } + + List switchComponent = []; + var latestSwitch = await _repo.GetLatestSwitch(system.Id); + if (latestSwitch != null && system.FrontPrivacy.CanAccess(ctx)) + { + var switchMembers = + await _db.Execute(conn => _repo.GetSwitchMembers(conn, latestSwitch.Id)).ToListAsync(); + if (switchMembers.Count > 0) + { + var memberStr = string.Join(", ", switchMembers.Select(m => m.NameFor(ctx))); + if (memberStr.Length > 200) + memberStr = $"(too many to show, see `{cctx.DefaultPrefix}system {system.DisplayHid(cctx.Config)} fronters`)"; + + switchComponent.Add(new() + { + Type = ComponentType.Text, + Content = $"**{"Current fronter".ToQuantity(switchMembers.Count, ShowQuantityAs.None)}:** {memberStr}", + }); + } + } + + List descComponents = []; + if (system.DescriptionFor(ctx) is { } desc) + { + descComponents.Add(new() + { + Type = ComponentType.Separator, + }); + + descComponents.Add(new() + { + Type = ComponentType.Text, + Content = desc.NormalizeLineEndSpacing().Truncate(1024), + }); + } + + if (system.BannerPrivacy.CanAccess(ctx) && !string.IsNullOrWhiteSpace(system.BannerImage)) + descComponents.Add(new() + { + Type = ComponentType.MediaGallery, + Items = [new() { Media = new() { Url = system.BannerImage } }], + }); + + var systemName = (cctx.Guild != null && guildSettings?.DisplayName != null) ? guildSettings?.DisplayName! : system.NameFor(ctx); + var premiumText = ""; // TODO(iris): "\n\U0001F31F *PluralKit Premium supporter!*"; + List header = [ + new MessageComponent() + { + Type = ComponentType.Text, + Content = $"### {systemName ?? $"`{system.DisplayHid(cctx.Config)}`"}{premiumText}", + }, + ]; + + if (!string.IsNullOrWhiteSpace(headerText)) + header.Add(new MessageComponent() + { + Type = ComponentType.Text, + Content = headerText, + }); + + if (cctx.Guild != null) + { + var guildAvatar = guildSettings.AvatarUrl.TryGetCleanCdnUrl(); + if (!string.IsNullOrWhiteSpace(guildAvatar)) + avatar = guildAvatar; + } + + if (!string.IsNullOrWhiteSpace(avatar)) + header = [ + new MessageComponent() + { + Type = ComponentType.Section, + Components = [.. header], + Accessory = new MessageComponent() + { + Type = ComponentType.Thumbnail, + Media = new() { Url = avatar }, + }, + }, + ]; + + return [ + new MessageComponent() + { + Type = ComponentType.Container, + AccentColor = system.Color?.ToDiscordColor(), + Components = [ ..header, ..switchComponent, linkedAccounts, ..descComponents ], + }, + new MessageComponent() + { + Type = ComponentType.Section, + Components = [ + new MessageComponent() + { + Type = ComponentType.Text, + Content = $"-# System ID: `{system.DisplayHid(cctx.Config)}`\n-# Created: {system.Created.FormatZoned(cctx.Zone)}", + }, + ], + Accessory = new MessageComponent() + { + Type = ComponentType.Button, + Style = ButtonStyle.Link, + Label = "View on dashboard", + Url = $"{_coreConfig.DashboardBaseUrl}/profile/s/{system.Hid}", + }, + }, + ]; + } + public async Task CreateSystemEmbed(Context cctx, PKSystem system, LookupContext ctx) { // Fetch/render info for all accounts simultaneously @@ -61,7 +228,7 @@ public class EmbedService .Footer(new Embed.EmbedFooter( $"System ID: {system.DisplayHid(cctx.Config)} | Created on {system.Created.FormatZoned(cctx.Zone)}")) .Color(system.Color?.ToDiscordColor()) - .Url($"https://dash.pluralkit.me/profile/s/{system.Hid}"); + .Url($"{_coreConfig.DashboardBaseUrl}/profile/s/{system.Hid}"); var avatar = system.AvatarFor(ctx); if (avatar != null) @@ -164,6 +331,158 @@ public class EmbedService return embed.Build(); } + public async Task CreateMemberMessageComponents(PKSystem system, PKMember member, Guild guild, SystemConfig? ccfg, LookupContext ctx, DateTimeZone zone) + { + var name = member.NameFor(ctx); + var systemGuildSettings = guild != null ? await _repo.GetSystemGuild(guild.Id, system.Id) : null; + var systemName = (guild != null && systemGuildSettings?.DisplayName != null) ? systemGuildSettings?.DisplayName! : system.NameFor(ctx); + + var guildSettings = guild != null ? await _repo.GetMemberGuild(guild.Id, member.Id) : null; + var guildDisplayName = guildSettings?.DisplayName; + var webhook_avatar = guildSettings?.AvatarUrl ?? member.WebhookAvatarFor(ctx) ?? member.AvatarFor(ctx); + var avatar = guildSettings?.AvatarUrl ?? member.AvatarFor(ctx); + + var groups = await _repo.GetMemberGroups(member.Id) + .Where(g => g.Visibility.CanAccess(ctx)) + .OrderBy(g => g.Name, StringComparer.InvariantCultureIgnoreCase) + .ToListAsync(); + + var headerText = ""; + if (member.MemberVisibility == PrivacyLevel.Private) + headerText += "*(this member is hidden)*\n"; + if (guildSettings?.AvatarUrl != null) + if (member.AvatarFor(ctx) != null) + headerText += + $"*(this member has a server-specific avatar set; [click here]({member.AvatarUrl.TryGetCleanCdnUrl()}) to see the global avatar)*\n"; + else + headerText += "*(this member has a server-specific avatar set)*\n"; + + if (!member.DisplayName.EmptyOrNull() && member.NamePrivacy.CanAccess(ctx)) + headerText += $"\n**Display name:** {member.DisplayName.Truncate(1024)}"; + if (guild != null && guildDisplayName != null) + headerText += $"\n**Server nickname (for '{guild.Name}'):** {guildDisplayName.Truncate(1024)}"; + if (ccfg.CardShowColorHex && !member.Color.EmptyOrNull()) + headerText += $"\n**Color:** #{member.Color}"; + if (member.PronounsFor(ctx) is { } pronouns && !string.IsNullOrWhiteSpace(pronouns)) + headerText += $"\n**Pronouns:** {pronouns}"; + if (member.BirthdayFor(ctx) != null) + headerText += $"\n**Birthday:** {member.BirthdayString}"; + if (member.MessageCountFor(ctx) is { } count && count > 0) + headerText += $"\n**Message count:** {member.MessageCount}"; + + List extraData = []; + if (member.HasProxyTags && member.ProxyPrivacy.CanAccess(ctx)) + { + extraData.Add(new MessageComponent + { + Type = ComponentType.Separator, + }); + + extraData.Add(new MessageComponent + { + Type = ComponentType.Text, + Content = $"**Proxy tags:**\n{member.ProxyTagsString("\n").Truncate(1024)}", + }); + } + + if (groups.Count > 0) + { + // More than 5 groups show in "compact" format without ID + var content = groups.Count > 5 + ? string.Join(", ", groups.Select(g => g.DisplayName ?? g.Name)) + : string.Join("\n", groups.Select(g => $"[`{g.DisplayHid(ccfg, isList: true)}`] **{g.DisplayName ?? g.Name}**")); + + extraData.Add(new MessageComponent + { + Type = ComponentType.Separator, + }); + + extraData.Add(new MessageComponent + { + Type = ComponentType.Text, + Content = $"**Groups ({groups.Count}):**\n{content.Truncate(1000)}", + }); + } + + List descComponents = []; + if (member.DescriptionFor(ctx) is { } desc) + { + descComponents.Add(new() + { + Type = ComponentType.Separator, + }); + + descComponents.Add(new() + { + Type = ComponentType.Text, + Content = desc.NormalizeLineEndSpacing().Truncate(1024), + }); + } + + if (member.BannerPrivacy.CanAccess(ctx) && !string.IsNullOrWhiteSpace(member.BannerImage)) + descComponents.Add(new() + { + Type = ComponentType.MediaGallery, + Items = [new() { Media = new() { Url = member.BannerImage } }], + }); + + List header = [ + new MessageComponent() + { + Type = ComponentType.Text, + Content = $"### {name}{(systemName != null ? $" ({systemName})" : "")}", + }, + ]; + + if (!string.IsNullOrWhiteSpace(headerText)) + header.Add(new MessageComponent() + { + Type = ComponentType.Text, + Content = headerText, + }); + + if (!string.IsNullOrWhiteSpace(avatar)) + header = [ + new MessageComponent() + { + Type = ComponentType.Section, + Components = [.. header], + Accessory = new MessageComponent() + { + Type = ComponentType.Thumbnail, + Media = new() { Url = avatar }, + }, + }, + ]; + + return [ + new MessageComponent() + { + Type = ComponentType.Container, + AccentColor = member.Color?.ToDiscordColor(), + Components = [ ..header, ..extraData, ..descComponents ], + }, + new MessageComponent() + { + Type = ComponentType.Section, + Components = [ + new MessageComponent() + { + Type = ComponentType.Text, + Content = $"-# System ID: `{system.DisplayHid(ccfg)}` \u2219 Member ID: `{member.DisplayHid(ccfg)}`{(member.MetadataPrivacy.CanAccess(ctx) ? $"\n-# Created: {member.Created.FormatZoned(zone)}" : "")}", + }, + ], + Accessory = new MessageComponent() + { + Type = ComponentType.Button, + Style = ButtonStyle.Link, + Label = "View on dashboard", + Url = $"{_coreConfig.DashboardBaseUrl}/profile/m/{member.Hid}", + }, + }, + ]; + } + public async Task CreateMemberEmbed(PKSystem system, PKMember member, Guild guild, SystemConfig? ccfg, LookupContext ctx, DateTimeZone zone) { // string FormatTimestamp(Instant timestamp) => DateTimeFormats.ZonedDateTimeFormat.Format(timestamp.InZone(system.Zone)); @@ -188,7 +507,7 @@ public class EmbedService .ToListAsync(); var eb = new EmbedBuilder() - .Author(new Embed.EmbedAuthor(name, IconUrl: webhook_avatar.TryGetCleanCdnUrl(), Url: $"https://dash.pluralkit.me/profile/m/{member.Hid}")) + .Author(new Embed.EmbedAuthor(name, IconUrl: webhook_avatar.TryGetCleanCdnUrl(), Url: $"{_coreConfig.DashboardBaseUrl}/profile/m/{member.Hid}")) // .WithColor(member.ColorPrivacy.CanAccess(ctx) ? color : null) .Color(member.Color?.ToDiscordColor()) .Footer(new Embed.EmbedFooter( @@ -241,6 +560,119 @@ public class EmbedService return eb.Build(); } + public async Task CreateGroupMessageComponents(Context ctx, PKSystem system, PKGroup target) + { + var pctx = ctx.LookupContextFor(system.Id); + var name = target.NameFor(ctx); + var systemGuildSettings = ctx.Guild != null ? await _repo.GetSystemGuild(ctx.Guild.Id, system.Id) : null; + var systemName = (ctx.Guild != null && systemGuildSettings?.DisplayName != null) ? systemGuildSettings?.DisplayName! : system.NameFor(ctx); + + var countctx = LookupContext.ByNonOwner; + if (ctx.MatchFlag("a", "all")) + { + if (system.Id == ctx.System.Id) + countctx = LookupContext.ByOwner; + else + throw Errors.LookupNotAllowed; + } + + var memberCount = await _repo.GetGroupMemberCount(target.Id, countctx == LookupContext.ByOwner ? null : PrivacyLevel.Public); + var headerText = ""; + + if (target.NamePrivacy.CanAccess(pctx) && target.DisplayName != null) + headerText += $"\n**Display name:** {target.DisplayName}"; + + if (ctx.Config.CardShowColorHex && !target.Color.EmptyOrNull()) + headerText += $"\n**Color:** #{target.Color}"; + + if (target.ListPrivacy.CanAccess(pctx)) + { + headerText += $"\n**Members:** {memberCount}"; + if (system.Id == ctx.System.Id && memberCount == 0) + headerText += $" (add one with `{ctx.DefaultPrefix}group {target.Reference(ctx)} add `!)"; + else if (memberCount > 0) + headerText += $" (see `{ctx.DefaultPrefix}group {target.Reference(ctx)} list`)"; + } + + List descComponents = []; + if (target.DescriptionFor(pctx) is { } desc) + { + descComponents.Add(new() + { + Type = ComponentType.Separator, + }); + + descComponents.Add(new() + { + Type = ComponentType.Text, + Content = desc.NormalizeLineEndSpacing().Truncate(1024), + }); + } + + if (target.BannerPrivacy.CanAccess(pctx) && !string.IsNullOrWhiteSpace(target.BannerImage)) + descComponents.Add(new() + { + Type = ComponentType.MediaGallery, + Items = [new() { Media = new() { Url = target.BannerImage } }], + }); + + List header = [ + new MessageComponent() + { + Type = ComponentType.Text, + Content = $"### {name}{(systemName != null ? $" ({systemName})" : "")}", + }, + ]; + + if (!string.IsNullOrWhiteSpace(headerText)) + header.Add(new MessageComponent() + { + Type = ComponentType.Text, + Content = headerText, + }); + + if (target.IconFor(pctx) is { } icon) + header = [ + new MessageComponent() + { + Type = ComponentType.Section, + Components = [.. header], + Accessory = new MessageComponent() + { + Type = ComponentType.Thumbnail, + Media = new() { Url = icon.TryGetCleanCdnUrl() }, + }, + }, + ]; + + return [ + new MessageComponent() + { + Type = ComponentType.Container, + AccentColor = target.Color?.ToDiscordColor(), + Components = [ ..header, ..descComponents ], + }, + new MessageComponent() + { + Type = ComponentType.Section, + Components = [ + new MessageComponent() + { + Type = ComponentType.Text, + Content = $"-# System ID: `{system.DisplayHid(ctx.Config)}` \u2219 Group ID: `{target.DisplayHid(ctx.Config)}`{(target.MetadataPrivacy.CanAccess(pctx) ? $"\n-# Created: {target.Created.FormatZoned(ctx.Zone)}" : "")}", + }, + ], + Accessory = new MessageComponent() + { + Type = ComponentType.Button, + Style = ButtonStyle.Link, + Label = "View on dashboard", + Url = $"{_coreConfig.DashboardBaseUrl}/profile/g/{target.Hid}", + }, + }, + ]; + } + public async Task CreateGroupEmbed(Context ctx, PKSystem system, PKGroup target) { var pctx = ctx.LookupContextFor(system.Id); @@ -266,7 +698,7 @@ public class EmbedService nameField = $"{nameField}"; var eb = new EmbedBuilder() - .Author(new Embed.EmbedAuthor(nameField, IconUrl: target.IconFor(pctx), Url: $"https://dash.pluralkit.me/profile/g/{target.Hid}")) + .Author(new Embed.EmbedAuthor(nameField, IconUrl: target.IconFor(pctx), Url: $"{_coreConfig.DashboardBaseUrl}/profile/g/{target.Hid}")) .Color(target.Color?.ToDiscordColor()); eb.Footer(new Embed.EmbedFooter($"System ID: {system.DisplayHid(ctx.Config)} | Group ID: {target.DisplayHid(ctx.Config)}{(target.MetadataPrivacy.CanAccess(pctx) ? $" | Created on {target.Created.FormatZoned(ctx.Zone)}" : "")}")); diff --git a/PluralKit.Core/CoreConfig.cs b/PluralKit.Core/CoreConfig.cs index 1e77271b..9792bc8e 100644 --- a/PluralKit.Core/CoreConfig.cs +++ b/PluralKit.Core/CoreConfig.cs @@ -16,6 +16,7 @@ public class CoreConfig public string? SeqLogUrl { get; set; } public string? DispatchProxyUrl { get; set; } public string? DispatchProxyToken { get; set; } + public string DashboardBaseUrl { get; set; } = "https://dash.pluralkit.local"; public LogEventLevel ConsoleLogLevel { get; set; } = LogEventLevel.Debug; public LogEventLevel ElasticLogLevel { get; set; } = LogEventLevel.Information; diff --git a/PluralKit.Core/Models/Patch/SystemConfigPatch.cs b/PluralKit.Core/Models/Patch/SystemConfigPatch.cs index d3d80428..c29cfae8 100644 --- a/PluralKit.Core/Models/Patch/SystemConfigPatch.cs +++ b/PluralKit.Core/Models/Patch/SystemConfigPatch.cs @@ -22,6 +22,7 @@ public class SystemConfigPatch: PatchObject public Partial ProxyErrorMessageEnabled { get; set; } public Partial HidDisplaySplit { get; set; } public Partial HidDisplayCaps { get; set; } + public Partial CardShowColorHex { get; set; } public Partial NameFormat { get; set; } public Partial HidListPadding { get; set; } public Partial ProxySwitch { get; set; } @@ -41,6 +42,7 @@ public class SystemConfigPatch: PatchObject .With("hid_display_split", HidDisplaySplit) .With("hid_display_caps", HidDisplayCaps) .With("hid_list_padding", HidListPadding) + .With("card_show_color_hex", CardShowColorHex) .With("proxy_switch", ProxySwitch) .With("name_format", NameFormat) ); @@ -107,6 +109,9 @@ public class SystemConfigPatch: PatchObject if (HidListPadding.IsPresent) o.Add("hid_list_padding", HidListPadding.Value.ToUserString()); + if (CardShowColorHex.IsPresent) + o.Add("card_show_color_hex", CardShowColorHex.Value); + if (ProxySwitch.IsPresent) o.Add("proxy_switch", ProxySwitch.Value.ToUserString()); @@ -150,6 +155,9 @@ public class SystemConfigPatch: PatchObject if (o.ContainsKey("hid_display_caps")) patch.HidDisplayCaps = o.Value("hid_display_caps"); + if (o.ContainsKey("card_show_color_hex")) + patch.CardShowColorHex = o.Value("card_show_color_hex"); + if (o.ContainsKey("proxy_switch")) patch.ProxySwitch = o.Value("proxy_switch") switch { diff --git a/PluralKit.Core/Models/SystemConfig.cs b/PluralKit.Core/Models/SystemConfig.cs index b4148211..dac7965f 100644 --- a/PluralKit.Core/Models/SystemConfig.cs +++ b/PluralKit.Core/Models/SystemConfig.cs @@ -23,6 +23,7 @@ public class SystemConfig public bool ProxyErrorMessageEnabled { get; } public bool HidDisplaySplit { get; } public bool HidDisplayCaps { get; } + public bool CardShowColorHex { get; } public HidPadFormat HidListPadding { get; } public ProxySwitchAction ProxySwitch { get; } public string NameFormat { get; } @@ -60,6 +61,7 @@ public static class SystemConfigExt o.Add("hid_display_split", cfg.HidDisplaySplit); o.Add("hid_display_caps", cfg.HidDisplayCaps); o.Add("hid_list_padding", cfg.HidListPadding.ToUserString()); + o.Add("card_show_color_hex", cfg.CardShowColorHex); o.Add("proxy_switch", cfg.ProxySwitch.ToUserString()); o.Add("name_format", cfg.NameFormat); diff --git a/crates/migrate/data/migrations/53.sql b/crates/migrate/data/migrations/53.sql new file mode 100644 index 00000000..3bfa3582 --- /dev/null +++ b/crates/migrate/data/migrations/53.sql @@ -0,0 +1,6 @@ +-- database version 53 +-- add toggle for showing color codes on cv2 cards + +alter table system_config add column card_show_color_hex bool default false; + +update info set schema_version = 53; \ No newline at end of file From 5df3191a2c35c686131e210bc45322888c40bc10 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Sun, 7 Sep 2025 13:02:10 -0400 Subject: [PATCH 24/40] chore(deps): bump webp from 0.2.6 to 0.3.1 (#767) Bumps [webp](https://github.com/jaredforth/webp) from 0.2.6 to 0.3.1. - [Commits](https://github.com/jaredforth/webp/commits) --- updated-dependencies: - dependency-name: webp dependency-version: 0.3.1 dependency-type: direct:production ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- Cargo.lock | 25 +++++++++++++++++++++---- crates/avatars/Cargo.toml | 2 +- 2 files changed, 22 insertions(+), 5 deletions(-) diff --git a/Cargo.lock b/Cargo.lock index d52d073b..c4a272eb 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -180,7 +180,7 @@ dependencies = [ "form_urlencoded", "futures", "gif", - "image", + "image 0.24.9", "libpk", "reqwest 0.12.15", "rust-s3", @@ -448,6 +448,12 @@ version = "1.5.0" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "1fd0f2584146f6f2ef48085050886acf353beff7305ebd1ae69500e27c67f64b" +[[package]] +name = "byteorder-lite" +version = "0.1.0" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "8f1fe948ff07f4bd06c30984e69f5b4899c516a3ef74f34df92a2df2ab535495" + [[package]] name = "bytes" version = "1.10.1" @@ -1847,6 +1853,17 @@ dependencies = [ "tiff", ] +[[package]] +name = "image" +version = "0.25.6" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "db35664ce6b9810857a38a906215e75a9c879f0696556a39f59c62829710251a" +dependencies = [ + "bytemuck", + "byteorder-lite", + "num-traits", +] + [[package]] name = "indexmap" version = "2.8.0" @@ -4830,11 +4847,11 @@ dependencies = [ [[package]] name = "webp" -version = "0.2.6" +version = "0.3.1" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "4bb5d8e7814e92297b0e1c773ce43d290bef6c17452dafd9fc49e5edb5beba71" +checksum = "c071456adef4aca59bf6a583c46b90ff5eb0b4f758fc347cea81290288f37ce1" dependencies = [ - "image", + "image 0.25.6", "libwebp-sys", ] diff --git a/crates/avatars/Cargo.toml b/crates/avatars/Cargo.toml index ee1aa91e..01cea291 100644 --- a/crates/avatars/Cargo.toml +++ b/crates/avatars/Cargo.toml @@ -26,4 +26,4 @@ form_urlencoded = "1.2.1" rust-s3 = { version = "0.33.0", default-features = false, features = ["tokio-rustls-tls"] } sha2 = "0.10.8" thiserror = "1.0.56" -webp = "0.2.6" +webp = "0.3.1" From 443e402cdbb609bcf57c9b39669dcb2bdd580526 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Sun, 7 Sep 2025 13:02:48 -0400 Subject: [PATCH 25/40] chore(deps): bump tracing-subscriber from 0.3.19 to 0.3.20 (#768) Bumps [tracing-subscriber](https://github.com/tokio-rs/tracing) from 0.3.19 to 0.3.20. - [Release notes](https://github.com/tokio-rs/tracing/releases) - [Commits](https://github.com/tokio-rs/tracing/compare/tracing-subscriber-0.3.19...tracing-subscriber-0.3.20) --- updated-dependencies: - dependency-name: tracing-subscriber dependency-version: 0.3.20 dependency-type: direct:production ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- Cargo.lock | 46 ++++++++++++---------------------------------- Cargo.toml | 2 +- 2 files changed, 13 insertions(+), 35 deletions(-) diff --git a/Cargo.lock b/Cargo.lock index c4a272eb..c99e2fa0 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -2107,11 +2107,11 @@ checksum = "13dc2df351e3202783a1fe0d44375f7295ffb4049267b0f3018346dc122a1d94" [[package]] name = "matchers" -version = "0.1.0" +version = "0.2.0" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "8263075bb86c5a1b1427b5ae862e8889656f126e9f77c484496e8b47cf5c5558" +checksum = "d1525a2a28c7f4fa0fc98bb91ae755d1e2d1505079e05539e35bc876b5d65ae9" dependencies = [ - "regex-automata 0.1.10", + "regex-automata", ] [[package]] @@ -2269,12 +2269,11 @@ dependencies = [ [[package]] name = "nu-ansi-term" -version = "0.46.0" +version = "0.50.1" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "77a8165726e8236064dbb45459242600304b42a5ea24ee2948e18e023bf7ba84" +checksum = "d4a28e057d01f97e61255210fcff094d74ed0466038633e95017f5beb68e4399" dependencies = [ - "overload", - "winapi", + "windows-sys 0.52.0", ] [[package]] @@ -2411,12 +2410,6 @@ dependencies = [ "windows-sys 0.52.0", ] -[[package]] -name = "overload" -version = "0.1.1" -source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "b15813163c1d831bf4a13c3610c05c0d03b39feb07f7e09fa234dac9b15aaf39" - [[package]] name = "parking" version = "2.2.1" @@ -2862,17 +2855,8 @@ checksum = "b544ef1b4eac5dc2db33ea63606ae9ffcfac26c1416a2806ae0bf5f56b201191" dependencies = [ "aho-corasick", "memchr", - "regex-automata 0.4.9", - "regex-syntax 0.8.5", -] - -[[package]] -name = "regex-automata" -version = "0.1.10" -source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "6c230d73fb8d8c1b9c0b3135c5142a8acee3a0558fb8db5cf1cb65f8d7862132" -dependencies = [ - "regex-syntax 0.6.29", + "regex-automata", + "regex-syntax", ] [[package]] @@ -2883,15 +2867,9 @@ checksum = "809e8dc61f6de73b46c85f4c96486310fe304c434cfa43669d7b40f711150908" dependencies = [ "aho-corasick", "memchr", - "regex-syntax 0.8.5", + "regex-syntax", ] -[[package]] -name = "regex-syntax" -version = "0.6.29" -source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "f162c6dd7b008981e4d40210aca20b4bd0f9b60ca9271061b07f78537722f2e1" - [[package]] name = "regex-syntax" version = "0.8.5" @@ -4437,14 +4415,14 @@ dependencies = [ [[package]] name = "tracing-subscriber" -version = "0.3.19" +version = "0.3.20" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "e8189decb5ac0fa7bc8b96b7cb9b2701d60d48805aca84a238004d665fcc4008" +checksum = "2054a14f5307d601f88daf0553e1cbf472acc4f2c51afab632431cdcd72124d5" dependencies = [ "matchers", "nu-ansi-term", "once_cell", - "regex", + "regex-automata", "serde", "serde_json", "sharded-slab", diff --git a/Cargo.toml b/Cargo.toml index 444bcee6..e3acaec3 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -20,7 +20,7 @@ serde_json = "1.0.117" sqlx = { version = "0.8.2", features = ["runtime-tokio", "postgres", "time", "chrono", "macros", "uuid"] } tokio = { version = "1.36.0", features = ["full"] } tracing = "0.1" -tracing-subscriber = { version = "0.3.16", features = ["env-filter", "json"] } +tracing-subscriber = { version = "0.3.20", features = ["env-filter", "json"] } uuid = { version = "1.7.0", features = ["serde"] } axum = { git = "https://github.com/pluralkit/axum", branch = "v0.8.4-pluralkit" } From 2ba624d1273fc3b2b9328b182fea6d8ec61c3d2c Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Sun, 7 Sep 2025 13:03:17 -0400 Subject: [PATCH 26/40] build(deps): bump tokio from 1.44.1 to 1.44.2 (#729) Bumps [tokio](https://github.com/tokio-rs/tokio) from 1.44.1 to 1.44.2. - [Release notes](https://github.com/tokio-rs/tokio/releases) - [Commits](https://github.com/tokio-rs/tokio/compare/tokio-1.44.1...tokio-1.44.2) --- updated-dependencies: - dependency-name: tokio dependency-version: 1.44.2 dependency-type: direct:production ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- Cargo.lock | 45 ++++++++++++++++++++++++++++++++++----------- Cargo.toml | 2 +- 2 files changed, 35 insertions(+), 12 deletions(-) diff --git a/Cargo.lock b/Cargo.lock index c99e2fa0..1628247e 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1085,7 +1085,7 @@ dependencies = [ "redis-protocol", "semver", "sha-1", - "socket2", + "socket2 0.5.9", "tokio", "tokio-stream", "tokio-util", @@ -1587,7 +1587,7 @@ dependencies = [ "httpdate", "itoa", "pin-project-lite", - "socket2", + "socket2 0.5.9", "tokio", "tower-service", "tracing", @@ -1662,7 +1662,7 @@ dependencies = [ "hyper 1.6.0", "libc", "pin-project-lite", - "socket2", + "socket2 0.5.9", "tokio", "tower-service", "tracing", @@ -1885,6 +1885,17 @@ dependencies = [ "syn", ] +[[package]] +name = "io-uring" +version = "0.7.10" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "046fa2d4d00aea763528b4950358d0ead425372445dc8ff86312b3c69ff7727b" +dependencies = [ + "bitflags 2.9.0", + "cfg-if", + "libc", +] + [[package]] name = "ipnet" version = "2.11.0" @@ -1997,9 +2008,9 @@ checksum = "830d08ce1d1d941e6b30645f1a0eb5643013d835ce3779a5fc208261dbe10f55" [[package]] name = "libc" -version = "0.2.171" +version = "0.2.175" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "c19937216e9d3aa9956d9bb8dfc0b0c8beb6058fc4f7a4dc4d850edf86a237d6" +checksum = "6a82ae493e598baaea5209805c49bbf2ea7de956d50d7da0da1164f9c6d28543" [[package]] name = "libloading" @@ -2678,7 +2689,7 @@ dependencies = [ "quinn-udp", "rustc-hash 2.1.1", "rustls 0.23.25", - "socket2", + "socket2 0.5.9", "thiserror 2.0.12", "tokio", "tracing", @@ -2714,7 +2725,7 @@ dependencies = [ "cfg_aliases", "libc", "once_cell", - "socket2", + "socket2 0.5.9", "tracing", "windows-sys 0.59.0", ] @@ -3713,6 +3724,16 @@ dependencies = [ "windows-sys 0.52.0", ] +[[package]] +name = "socket2" +version = "0.6.0" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "233504af464074f9d066d7b5416c5f9b894a5862a6506e306f7b816cdd6f1807" +dependencies = [ + "libc", + "windows-sys 0.59.0", +] + [[package]] name = "spin" version = "0.5.2" @@ -4159,20 +4180,22 @@ checksum = "1f3ccbac311fea05f86f61904b462b55fb3df8837a366dfc601a0161d0532f20" [[package]] name = "tokio" -version = "1.44.1" +version = "1.47.1" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "f382da615b842244d4b8738c82ed1275e6c5dd90c459a30941cd07080b06c91a" +checksum = "89e49afdadebb872d3145a5638b59eb0691ea23e46ca484037cfab3b76b95038" dependencies = [ "backtrace", "bytes", + "io-uring", "libc", "mio", "parking_lot", "pin-project-lite", "signal-hook-registry", - "socket2", + "slab", + "socket2 0.6.0", "tokio-macros", - "windows-sys 0.52.0", + "windows-sys 0.59.0", ] [[package]] diff --git a/Cargo.toml b/Cargo.toml index e3acaec3..c566e979 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -18,7 +18,7 @@ sentry = { version = "0.36.0", default-features = false, features = ["backtrace serde = { version = "1.0.196", features = ["derive"] } serde_json = "1.0.117" sqlx = { version = "0.8.2", features = ["runtime-tokio", "postgres", "time", "chrono", "macros", "uuid"] } -tokio = { version = "1.36.0", features = ["full"] } +tokio = { version = "1.46.1", features = ["full"] } tracing = "0.1" tracing-subscriber = { version = "0.3.20", features = ["env-filter", "json"] } uuid = { version = "1.7.0", features = ["serde"] } From ccbc02772972477cc77bbc163733dc4aa4dddc05 Mon Sep 17 00:00:00 2001 From: alyssa Date: Sun, 7 Sep 2025 17:18:27 +0000 Subject: [PATCH 27/40] chore: fix rust build --- Cargo.lock | 58 ++++++++++++++++++++++++----------- crates/avatars/Cargo.toml | 2 +- crates/avatars/src/process.rs | 4 +-- 3 files changed, 43 insertions(+), 21 deletions(-) diff --git a/Cargo.lock b/Cargo.lock index 1628247e..858c207a 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -180,7 +180,7 @@ dependencies = [ "form_urlencoded", "futures", "gif", - "image 0.24.9", + "image", "libpk", "reqwest 0.12.15", "rust-s3", @@ -1837,22 +1837,6 @@ dependencies = [ "icu_properties", ] -[[package]] -name = "image" -version = "0.24.9" -source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "5690139d2f55868e080017335e4b94cb7414274c74f1669c84fb5feba2c9f69d" -dependencies = [ - "bytemuck", - "byteorder", - "color_quant", - "gif", - "jpeg-decoder", - "num-traits", - "png", - "tiff", -] - [[package]] name = "image" version = "0.25.6" @@ -1861,7 +1845,24 @@ checksum = "db35664ce6b9810857a38a906215e75a9c879f0696556a39f59c62829710251a" dependencies = [ "bytemuck", "byteorder-lite", + "color_quant", + "gif", + "image-webp", "num-traits", + "png", + "tiff", + "zune-core", + "zune-jpeg", +] + +[[package]] +name = "image-webp" +version = "0.2.4" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "525e9ff3e1a4be2fbea1fdf0e98686a6d98b4d8f937e1bf7402245af1909e8c3" +dependencies = [ + "byteorder-lite", + "quick-error", ] [[package]] @@ -2666,6 +2667,12 @@ dependencies = [ "winapi", ] +[[package]] +name = "quick-error" +version = "2.0.1" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "a993555f31e5a609f617c12db6250dedcac1b0a85076912c436e6fc9b2c8e6a3" + [[package]] name = "quick-xml" version = "0.26.0" @@ -4852,7 +4859,7 @@ version = "0.3.1" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "c071456adef4aca59bf6a583c46b90ff5eb0b4f758fc347cea81290288f37ce1" dependencies = [ - "image 0.25.6", + "image", "libwebp-sys", ] @@ -5516,3 +5523,18 @@ dependencies = [ "cc", "pkg-config", ] + +[[package]] +name = "zune-core" +version = "0.4.12" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "3f423a2c17029964870cfaabb1f13dfab7d092a62a29a89264f4d36990ca414a" + +[[package]] +name = "zune-jpeg" +version = "0.4.21" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "29ce2c8a9384ad323cf564b67da86e21d3cfdff87908bc1223ed5c99bc792713" +dependencies = [ + "zune-core", +] diff --git a/crates/avatars/Cargo.toml b/crates/avatars/Cargo.toml index 01cea291..f6dfb96f 100644 --- a/crates/avatars/Cargo.toml +++ b/crates/avatars/Cargo.toml @@ -21,7 +21,7 @@ uuid = { workspace = true } data-encoding = "2.5.0" gif = "0.13.1" -image = { version = "0.24.8", default-features = false, features = ["gif", "jpeg", "png", "webp", "tiff"] } +image = { version = "0.25.6", default-features = false, features = ["gif", "jpeg", "png", "webp", "tiff"] } form_urlencoded = "1.2.1" rust-s3 = { version = "0.33.0", default-features = false, features = ["tokio-rustls-tls"] } sha2 = "0.10.8" diff --git a/crates/avatars/src/process.rs b/crates/avatars/src/process.rs index 0c9ba8c1..99ae2d36 100644 --- a/crates/avatars/src/process.rs +++ b/crates/avatars/src/process.rs @@ -211,8 +211,8 @@ fn process_gif_inner( })) } -fn reader_for(data: &[u8]) -> image::io::Reader> { - image::io::Reader::new(Cursor::new(data)) +fn reader_for(data: &[u8]) -> image::ImageReader> { + image::ImageReader::new(Cursor::new(data)) .with_guessed_format() .expect("cursor i/o is infallible") } From a55ccdceeae343044713aecf840fc06592b02875 Mon Sep 17 00:00:00 2001 From: Iris System Date: Mon, 8 Sep 2025 10:43:38 +1200 Subject: [PATCH 28/40] fix(bot): resolve NRE on querying CV2 cards --- PluralKit.Bot/Services/EmbedService.cs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/PluralKit.Bot/Services/EmbedService.cs b/PluralKit.Bot/Services/EmbedService.cs index 39e85a37..e49e56e1 100644 --- a/PluralKit.Bot/Services/EmbedService.cs +++ b/PluralKit.Bot/Services/EmbedService.cs @@ -75,7 +75,7 @@ public class EmbedService if (system.Tag != null) headerText += $"\n**Tag:** {system.Tag.EscapeMarkdown()}"; - if (cctx.Config.CardShowColorHex && !system.Color.EmptyOrNull()) + if (cctx.Config != null && cctx.Config.CardShowColorHex && !system.Color.EmptyOrNull()) headerText += $"\n**Color:** #{system.Color}"; if (cctx.Guild != null) @@ -361,7 +361,7 @@ public class EmbedService headerText += $"\n**Display name:** {member.DisplayName.Truncate(1024)}"; if (guild != null && guildDisplayName != null) headerText += $"\n**Server nickname (for '{guild.Name}'):** {guildDisplayName.Truncate(1024)}"; - if (ccfg.CardShowColorHex && !member.Color.EmptyOrNull()) + if (ccfg != null && ccfg.CardShowColorHex && !member.Color.EmptyOrNull()) headerText += $"\n**Color:** #{member.Color}"; if (member.PronounsFor(ctx) is { } pronouns && !string.IsNullOrWhiteSpace(pronouns)) headerText += $"\n**Pronouns:** {pronouns}"; @@ -582,7 +582,7 @@ public class EmbedService if (target.NamePrivacy.CanAccess(pctx) && target.DisplayName != null) headerText += $"\n**Display name:** {target.DisplayName}"; - if (ctx.Config.CardShowColorHex && !target.Color.EmptyOrNull()) + if (ctx.Config != null && ctx.Config.CardShowColorHex && !target.Color.EmptyOrNull()) headerText += $"\n**Color:** #{target.Color}"; if (target.ListPrivacy.CanAccess(pctx)) From 26208ce16cd08bf1864a0c9b2ac1f2ac17e979c9 Mon Sep 17 00:00:00 2001 From: alyssa Date: Sun, 7 Sep 2025 03:20:57 +0000 Subject: [PATCH 29/40] feat(bot): port help menu to components v2 --- PluralKit.Bot/Commands/Help.cs | 120 +++++++++++++++++++++++++++------ PluralKit.Bot/Commands/Misc.cs | 2 +- 2 files changed, 100 insertions(+), 22 deletions(-) diff --git a/PluralKit.Bot/Commands/Help.cs b/PluralKit.Bot/Commands/Help.cs index e148714b..333f4997 100644 --- a/PluralKit.Bot/Commands/Help.cs +++ b/PluralKit.Bot/Commands/Help.cs @@ -7,12 +7,94 @@ namespace PluralKit.Bot; public class Help { + public Task HelpRoot(Context ctx) + { + if (ctx.MatchFlag("show-embed", "se")) + return HelpRootOld(ctx); + + return ctx.Reply(BuildComponents(ctx.Author.Id, Help.Description.Replace("{prefix}", ctx.DefaultPrefix), -1)); + } + + public static Task ButtonClick(InteractionContext ctx, string prefix) + { + if (!ctx.CustomId.Contains(ctx.User.Id.ToString())) + return ctx.Ignore(); + + if (ctx.CustomId.StartsWith("new-")) + { + Console.WriteLine($"{ctx.Event.Message.Components.First().Components.Length}"); + if (ctx.Event.Message.Components.First().Components[1].Components.Where(x => x.CustomId == ctx.CustomId).First().Style == ButtonStyle.Primary) + return ctx.Respond(InteractionResponse.ResponseType.UpdateMessage, new() + { + Components = BuildComponents(ctx.User.Id, Help.Description.Replace("{prefix}", prefix), -1), + Flags = Message.MessageFlags.IsComponentsV2, + }); + + var text = helpEmbedPages.GetValueOrDefault(ctx.CustomId.Split("-")[3]).Select( + (item, index) => $"### {item.Name.Replace("{prefix}", prefix)}\n{item.Value.Replace("{prefix}", prefix)}" + ).ToArray(); + + var index = Array.FindIndex(ctx.Event.Message.Components.First().Components[1].Components, x => x.CustomId == ctx.CustomId); + var components = BuildComponents(ctx.User.Id, Help.Description.Replace("{prefix}", prefix), index); + + components.First().Components[ctx.Event.Message.Components.First().Components.Length - 1] = new MessageComponent() + { + Type = ComponentType.Text, + Content = String.Join("\n", text), + }; + + return ctx.Respond(InteractionResponse.ResponseType.UpdateMessage, new() + { + Components = components, + Flags = Message.MessageFlags.IsComponentsV2, + }); + } + + return ButtonClickOld(ctx, prefix); + } + + private static MessageComponent[] BuildComponents(ulong userId, string textContent, int menuIndex) + { + return [ + new MessageComponent() + { + Type = ComponentType.Container, + AccentColor = DiscordUtils.Blue, + Components = [ + new MessageComponent() + { + Type = ComponentType.Text, + Content = "# PluralKit\n-# Use the buttons below to see more info!" + }, + helpPageButtons(userId, "new-", menuIndex), + new MessageComponent() + { + Type = ComponentType.Separator, + }, + new MessageComponent() + { + Type = ComponentType.Text, + Content = textContent, + }, + ], + }, + new MessageComponent() + { + Type = ComponentType.Text, + Content = EmbedFooter("\n-# "), + }, + ]; + } + + /// + private static string Description = "PluralKit is a bot designed for plural communities on Discord, and is open for anyone to use. It allows you to register systems, maintain system information, set up message proxying, log switches, and more.\n\n" + "**System recovery:** in the case of your Discord account getting lost or deleted, the PluralKit staff can help you recover your system, **only if you save the system token from `{prefix}token`**. See [this FAQ entry](https://pluralkit.me/faq/#can-i-recover-my-system-if-i-lose-access-to-my-discord-account) for more details.\n\n" + - "If PluralKit is useful to you, please consider donating on [Patreon](https://patreon.com/pluralkit) or [Buy Me A Coffee](https://buymeacoffee.com/pluralkit).\n" + - "## Use the buttons below to see more info!"; + "If PluralKit is useful to you, please consider donating on [Patreon](https://patreon.com/pluralkit) or [Buy Me A Coffee](https://buymeacoffee.com/pluralkit)."; - public static string EmbedFooter = "-# PluralKit by @ske and contributors | Myriad design by @layl, icon by @tedkalashnikov, banner by @fulmine | GitHub: https://github.com/PluralKit/PluralKit/ | Website: https://pluralkit.me/"; + private static string DescriptionOld = $"{Description}\n## Use the buttons below to see more info!"; + + public static string EmbedFooter(string linkSeparator) => $"-# PluralKit by @ske and contributors | Myriad design by @layl, icon by @tedkalashnikov, banner by @fulmine{linkSeparator}GitHub: https://github.com/PluralKit/PluralKit/ | Website: https://pluralkit.me/"; public static Embed helpEmbed = new() { @@ -98,7 +180,7 @@ public class Help } }; - private static MessageComponent helpPageButtons(ulong userId) => new MessageComponent + private static MessageComponent helpPageButtons(ulong userId, string pfx = "", int menuIndex = -1) => new MessageComponent { Type = ComponentType.ActionRow, Components = new[] @@ -106,58 +188,54 @@ public class Help new MessageComponent { Type = ComponentType.Button, - Style = ButtonStyle.Secondary, + Style = menuIndex == 0 ? ButtonStyle.Primary : ButtonStyle.Secondary, Label = "Basic Info", - CustomId = $"help-menu-basicinfo-{userId}", + CustomId = $"{pfx}help-menu-basicinfo-{userId}", Emoji = new() { Name = "\u2139" }, }, new() { Type = ComponentType.Button, - Style = ButtonStyle.Secondary, + Style = menuIndex == 1 ? ButtonStyle.Primary : ButtonStyle.Secondary, Label = "Getting Started", - CustomId = $"help-menu-gettingstarted-{userId}", + CustomId = $"{pfx}help-menu-gettingstarted-{userId}", Emoji = new() { Name = "\u2753", }, }, new() { Type = ComponentType.Button, - Style = ButtonStyle.Secondary, + Style = menuIndex == 2 ? ButtonStyle.Primary : ButtonStyle.Secondary, Label = "Useful Tips", - CustomId = $"help-menu-usefultips-{userId}", + CustomId = $"{pfx}help-menu-usefultips-{userId}", Emoji = new() { Name = "\U0001f4a1", }, - }, new() { Type = ComponentType.Button, - Style = ButtonStyle.Secondary, + Style = menuIndex == 3 ? ButtonStyle.Primary : ButtonStyle.Secondary, Label = "More Info", - CustomId = $"help-menu-moreinfo-{userId}", + CustomId = $"{pfx}help-menu-moreinfo-{userId}", Emoji = new() { Id = 986379675066593330, }, } } }; - public Task HelpRoot(Context ctx) + public Task HelpRootOld(Context ctx) => ctx.Rest.CreateMessage(ctx.Channel.Id, new MessageRequest { Content = $"{Emojis.Warn} If you cannot see the rest of this message see [the FAQ]()", - Embeds = new[] { helpEmbed with { Description = Help.Description.Replace("{prefix}", ctx.DefaultPrefix), Fields = new Embed.Field[] { new("", EmbedFooter) } } }, + Embeds = new[] { helpEmbed with { Description = Help.DescriptionOld.Replace("{prefix}", ctx.DefaultPrefix), Fields = new Embed.Field[] { new("", EmbedFooter(" | ")) } } }, Components = new[] { helpPageButtons(ctx.Author.Id) }, }); - public static Task ButtonClick(InteractionContext ctx, string prefix) + public static Task ButtonClickOld(InteractionContext ctx, string prefix) { - if (!ctx.CustomId.Contains(ctx.User.Id.ToString())) - return ctx.Ignore(); - var buttons = helpPageButtons(ctx.User.Id); if (ctx.Event.Message.Components.First().Components.Where(x => x.CustomId == ctx.CustomId).First().Style == ButtonStyle.Primary) return ctx.Respond(InteractionResponse.ResponseType.UpdateMessage, new() { - Embeds = new[] { helpEmbed with { Description = Help.Description.Replace("{prefix}", prefix), Fields = new Embed.Field[] { new("", EmbedFooter) } } }, + Embeds = new[] { helpEmbed with { Description = Help.DescriptionOld.Replace("{prefix}", prefix), Fields = new Embed.Field[] { new("", EmbedFooter(" | ")) } } }, Components = new[] { buttons } }); @@ -167,7 +245,7 @@ public class Help { Embeds = new[] { helpEmbed with { Fields = helpEmbedPages.GetValueOrDefault(ctx.CustomId.Split("-")[2]).Select( (item, index) => new Embed.Field(item.Name.Replace("{prefix}", prefix), item.Value.Replace("{prefix}", prefix)) - ).Append(new("", EmbedFooter)).ToArray() } }, + ).Append(new("", EmbedFooter(" | "))).ToArray() } }, Components = new[] { buttons } }); } diff --git a/PluralKit.Bot/Commands/Misc.cs b/PluralKit.Bot/Commands/Misc.cs index 8688f9ef..514c8999 100644 --- a/PluralKit.Bot/Commands/Misc.cs +++ b/PluralKit.Bot/Commands/Misc.cs @@ -92,7 +92,7 @@ public class Misc + $"**{stats.db.switches:N0}** switches, **{stats.db.messages:N0}** messages\n" + $"**{stats.db.guilds:N0}** servers with **{stats.db.channels:N0}** channels")); - embed.Field(new("", Help.EmbedFooter)); + embed.Field(new("", Help.EmbedFooter(" | "))); var uptime = ((DateTimeOffset)process.StartTime).ToUnixTimeSeconds(); embed.Description($"### PluralKit [{BuildInfoService.Version}](https://github.com/pluralkit/pluralkit/commit/{BuildInfoService.FullVersion})\n" + From cd42131b3fe9b2ce84d785df226e591ecb1d5712 Mon Sep 17 00:00:00 2001 From: Iris System Date: Mon, 8 Sep 2025 10:58:51 +1200 Subject: [PATCH 30/40] chore: update changelog, add CV2 post --- docs/content/changelog.md | 45 ++++++++ .../content/posts/2025-09-08-components-v2.md | 105 ++++++++++++++++++ 2 files changed, 150 insertions(+) create mode 100644 docs/content/posts/2025-09-08-components-v2.md diff --git a/docs/content/changelog.md b/docs/content/changelog.md index d55621be..12ceec1a 100644 --- a/docs/content/changelog.md +++ b/docs/content/changelog.md @@ -9,6 +9,51 @@ the below is a lightly edited copy of the changelog messages posted on discord. a more complete list of code changes can be found [in the git repo](https://github.com/pluralkit/pluralkit/commits/main) +## 2025-09-08 + +### new/updated +- **new "ComponentsV2" format for system/member/group cards and help menu** (use -show-embed or -se flag to get the old view) + - [we have written a blog post giving some context behind this change](/posts/2025-09-08-components-v2/) - please read this also! + - a config option to toggle showing color codes on the new cards was also added as `pk;config show color` +- **new status page at ** +- replies to commands can now be deleted forever (previously 24h) +- logclean support for [Zeppelin](https://zeppelin.gg/) bot +- `pk;system` command now can be used with `pk;account` alias +- creating a new system now shows a note about the terms of service +- the announcements/changelog are now cross-posted from discord to the website +- `pk;member name` command now can show the member name as well as setting it +- clarified wording and updated formatting for some messages + +### fixed +- reply embeds now strip out excessive newlines +- cleaned up some error messages +- bot now correctly checks privacy in a few commands +- made a better attempt to not delete images uploaded to CDN on export/import +- importing system data with a large amount of switches should no longer throw an error + +### API changes +- api no longer breaks when the redis server is restarted +- some error messages have been fixed to use the correct JSON format +- document that short IDs are accepted in any format displayable by the bot +- added public/unauthenticated partial view for `/systems/:id/settings` endpoint +- autoproxy endpoint now allows changing the currently latched member +- discord guild endpoints now try harder at checking if the system is in the guild +- many docs fixes + +### Internal changes +- updated docker-compose configuration for self-hosting +- modernised the development documentation +- the Myriad Discord library has been relicensed to MIT to facilitate external use +- the C# code now correctly builds in Visual Studio 2022 +- the C# services now log in JSON format; this required a fork of Serilog and thus a git submodule +- code to generate colour previews has been rewritten, since the third-party site went offline +- fixed a bug where shards would never reconnect and require manual intervention +- bumped Rust language version to 2024 +- rewrote scheduled tasks and database migrations in Rust +- the Rust entrypoint macro has been rewritten as a proc macro to clean up call sites +- all (well, most) Rust errors correctly use fields for values instead of formatting them into the error string +- gateway events are now sent to the C# bot code through HTTP + ## 2025-01-01 ### Added diff --git a/docs/content/posts/2025-09-08-components-v2.md b/docs/content/posts/2025-09-08-components-v2.md new file mode 100644 index 00000000..29f67155 --- /dev/null +++ b/docs/content/posts/2025-09-08-components-v2.md @@ -0,0 +1,105 @@ +--- +title: on the switch to Components V2 +permalink: /posts/2025-09-08-components-v2/ +--- + +## on the switch to Components V2 + +you probably will have noticed the new design of system/member/group cards +in PluralKit. we know that a lot of people will have questions as to why +we've suddenly changed the layout & design of the cards, so we hope this +post can explain some of the decisions that went into these. + +### why change the cards at all? + +the old cards used something Discord calls "embeds." embeds were initially +only meant for showing details about a link posted in chat, but were later +also used by Discord bots for displaying information in a structured way. + +embeds are extremely limited in their layout, and bots have very little +control over how things are displayed in them. in addition, a lot of newer +Discord features (things like the Markdown headers, or small text) either +don't display in embeds at all, or only display on some platforms - making +them very inconsistent in how they display. + +the new cards use Discord's "Components V2" - which has been designed by +Discord from the ground up specifically for bots to use for custom content. +Components V2 is much more flexible, and fixes a lot of the issues with the +old embeds (the Markdown headers / small text being one example), letting us +have a lot more control over the display of the cards. + +Components V2 is the way forward, as far as Discord is concerned - meaning +that some of the issues with embeds will never be fixed in embeds themselves, +necessitating a move to Components V2. + +### continual improvement (also: "where'd my proxy avatar go?") + +currently, the only thing missing from PluralKit's new Components V2 cards +(compared to the previous embed-based cards) is member proxy avatars. on +the old member cards, proxy avatars would display as a tiny circle at the +top left. there is not currently a way to display an image of that size/ +position in Components V2... but from what we understand, that is on the +list of things Discord will be adding in the future. which leads into the +next point: + +unlike embeds, which have remained stagnant for years, Discord are actively +working on adding *new functionality* to Components V2, as well as fixing +whatever issues arise - in order to take advantage of new functionality as +Discord release it, we would have needed to move to Components V2 at some +point. we figured that with the state Components V2 is currently in, now +was a good time to make that switch! + +### character limits + +another advantage of Components V2 over embeds is the character limit for +cards. the old embeds had a hard limit of 1024 characters in a single field, +with a limit of 2000 characters for the entire embed. this is the reason that +PK descriptions are capped at 1000 characters. + +Components V2, however, has a character limit of *6000* characters across +the entire card, which can be split however we like. this means that once the +old embed-based cards are removed, we will be able to raise the description +character limit! + +### other small improvements + +- Components V2 allows us to use real code blocks in the card footers for + things like system/member/group IDs. on mobile Discord clients, this makes + copying IDs a lot easier - you can copy an individual code block's content + by tapping on it +- having a banner image set no longer makes the description width smaller +- on mobile clients, it is now a lot easier to view any images larger, just + by tapping on them +- some PluralKit users who use screen readers have reported that the new + Components V2 cards are read by their screen readers in a much more easily + understood way + +### the new cards don't show up! / is there a way to see the old cards? + +Components V2 is not supported on older Discord clients. there is nothing +we can do about this, other than encourage you to update your Discord +client. + +however - for now, using the `-show-embed` (or `-se`) flag to the +`pk;system`, `pk;member`, and `pk;group` commands will show the old +embed-based cards. + +the old cards will still show in some places in the bot (the most prominent +example being when querying message info with the ❓ reaction) also, +until we migrate those parts of the bot to use Components V2. + +the old embed-based cards will be removed from the bot in future - although +we do not have any specific timeframe in mind for this yet. + +### in closing + +we hope that this gives you a bit more context as to why we've made this +change - although there are some new design choices here, this was not +a change made just for the sake of changing. + +a lot of the decisions that went into the new versions of the cards were +iterated on with feedback from members of the community who help beta test +new PluralKit features - i want to thank those people immensely for their +input! + +if you have any questions, please let us know in [the support server](https://discord.gg/PczBt78). From ceedf8a327642089cb3fe595823e10e0ac2d67a5 Mon Sep 17 00:00:00 2001 From: Iris System Date: Mon, 8 Sep 2025 11:08:11 +1200 Subject: [PATCH 31/40] chore: update announcement index --- docs/content/posts/index.md | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/content/posts/index.md b/docs/content/posts/index.md index b268d706..c6b3c412 100644 --- a/docs/content/posts/index.md +++ b/docs/content/posts/index.md @@ -4,5 +4,6 @@ title: Announcements & other posts # Announcements & other posts +- 2025-09-08: [on the switch to Components V2](/posts/2025-09-08-components-v2/) - 2025-01-14: [january 2025 funding update](/posts/2025-01-14-funding-update/) - 2024-12-05: [late 2024 downtime notes & funding update](/posts/2024-12-05-downtime-notes/) From 21ec6ce0226fdb938a0c9668600d10326418604b Mon Sep 17 00:00:00 2001 From: Iris System Date: Mon, 8 Sep 2025 13:30:31 +1200 Subject: [PATCH 32/40] fix(bot): properly check description presence in CV2 cards --- PluralKit.Bot/Services/EmbedService.cs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/PluralKit.Bot/Services/EmbedService.cs b/PluralKit.Bot/Services/EmbedService.cs index e49e56e1..7ed006e3 100644 --- a/PluralKit.Bot/Services/EmbedService.cs +++ b/PluralKit.Bot/Services/EmbedService.cs @@ -119,7 +119,7 @@ public class EmbedService } List descComponents = []; - if (system.DescriptionFor(ctx) is { } desc) + if (system.DescriptionFor(ctx) is { } desc && !string.IsNullOrWhiteSpace(desc)) { descComponents.Add(new() { @@ -405,7 +405,7 @@ public class EmbedService } List descComponents = []; - if (member.DescriptionFor(ctx) is { } desc) + if (member.DescriptionFor(ctx) is { } desc && !string.IsNullOrWhiteSpace(desc)) { descComponents.Add(new() { @@ -595,7 +595,7 @@ public class EmbedService } List descComponents = []; - if (target.DescriptionFor(pctx) is { } desc) + if (target.DescriptionFor(pctx) is { } desc && !string.IsNullOrWhiteSpace(desc)) { descComponents.Add(new() { From bb0f27a70d93d92249287ed5274bf1237016bc9d Mon Sep 17 00:00:00 2001 From: Iris System Date: Mon, 8 Sep 2025 13:31:28 +1200 Subject: [PATCH 33/40] chore: add "pk;cfg show color" info to website --- docs/content/changelog.md | 2 +- docs/content/command-list.md | 1 + docs/content/posts/2025-09-08-components-v2.md | 10 ++++++++++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/docs/content/changelog.md b/docs/content/changelog.md index 12ceec1a..c9eff48d 100644 --- a/docs/content/changelog.md +++ b/docs/content/changelog.md @@ -14,7 +14,7 @@ a more complete list of code changes can be found [in the git repo](https://gith ### new/updated - **new "ComponentsV2" format for system/member/group cards and help menu** (use -show-embed or -se flag to get the old view) - [we have written a blog post giving some context behind this change](/posts/2025-09-08-components-v2/) - please read this also! - - a config option to toggle showing color codes on the new cards was also added as `pk;config show color` + - color codes are now hidden by default on cards, and a config option to show them again was added: `pk;config show color on` - **new status page at ** - replies to commands can now be deleted forever (previously 24h) - logclean support for [Zeppelin](https://zeppelin.gg/) bot diff --git a/docs/content/command-list.md b/docs/content/command-list.md index dd50f0d0..80abf707 100644 --- a/docs/content/command-list.md +++ b/docs/content/command-list.md @@ -148,6 +148,7 @@ You can have a space after `pk;`, e.g. `pk;system` and `pk; system` will do the - `pk;config split IDs [on|off]` - Toggles whether to display 6-letter IDs with a hyphen, to ease readability. - `pk;config capitalize IDs [on|off]` - Toggles whether to display IDs as capital letters, to ease readability. - `pk;config pad IDs [left|right|off]` - Toggles whether to pad (add a space) 5-character IDs in lists. +- `pk;config show color [on|off]` - Toggles whether to show color codes in system/member/group cards - `pk;config proxy switch [new|add|off]` - Toggles whether to log a switch whenever you proxy as a different member (or add member to recent switch in add mode). - `pk;config name format [format]` - Changes your system's username formatting. - `pk;config server name format [format]` - Changes your system's username formatting for the current server. diff --git a/docs/content/posts/2025-09-08-components-v2.md b/docs/content/posts/2025-09-08-components-v2.md index 29f67155..70384499 100644 --- a/docs/content/posts/2025-09-08-components-v2.md +++ b/docs/content/posts/2025-09-08-components-v2.md @@ -61,6 +61,16 @@ the entire card, which can be split however we like. this means that once the old embed-based cards are removed, we will be able to raise the description character limit! +### where'd the color codes go? + +one of the design choices we made for the new system/member/group cards was +to hide the hex color codes by default - this has been a near-constantly +requested feature, and the Components V2 rework gave us a good opportunity +to implement it. + +we added a configuration toggle for this - if you *do* want to see the hex +codes for colors, you can use `pk;config show color on` to re-enable them. + ### other small improvements - Components V2 allows us to use real code blocks in the card footers for From 4293f26b8a69ac3b0a56d56531fb8e6cd3cabd7e Mon Sep 17 00:00:00 2001 From: Iris System Date: Mon, 8 Sep 2025 14:24:23 +1200 Subject: [PATCH 34/40] chore: slightly reword beta test details in CV2 post --- .../content/posts/2025-09-08-components-v2.md | 20 +++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/docs/content/posts/2025-09-08-components-v2.md b/docs/content/posts/2025-09-08-components-v2.md index 70384499..db0ed8a8 100644 --- a/docs/content/posts/2025-09-08-components-v2.md +++ b/docs/content/posts/2025-09-08-components-v2.md @@ -98,18 +98,30 @@ the old cards will still show in some places in the bot (the most prominent example being when querying message info with the ❓ reaction) also, until we migrate those parts of the bot to use Components V2. -the old embed-based cards will be removed from the bot in future - although -we do not have any specific timeframe in mind for this yet. +the old embed-based cards **will be removed from the bot in future** - +although we do not have any specific timeframe in mind for this yet. +because of this, we will not be supporting a way to persistently show +the old cards (such as a config option) - the `-show-embed` flag is the +only way to pull up the old cards when using a command to query info. ### in closing we hope that this gives you a bit more context as to why we've made this change - although there are some new design choices here, this was not -a change made just for the sake of changing. +a change made just for the sake of changing. moving to Components V2 not only +gives us a lot more freedom to do things that weren't previously possible, +but means we can fix a lot of the long-standing issues with PK cards! + +we know this is a significant change for PluralKit, but we hope you can +understand that this is a change for the better. a lot of the decisions that went into the new versions of the cards were iterated on with feedback from members of the community who help beta test new PluralKit features - i want to thank those people immensely for their input! -if you have any questions, please let us know in [the support server](https://discord.gg/PczBt78). +if you'd like to help beta-test new features in future, check out the pins +in the `#beta-testing` channel in [the support server](https://discord.gg/PczBt78) +for the beta testing announcement role. + +if you have any questions, please let us know in the support server! From 8bca02032f53bd4f1d25519e285f5a850830e0d1 Mon Sep 17 00:00:00 2001 From: asleepyskye Date: Tue, 9 Sep 2025 10:43:00 -0400 Subject: [PATCH 35/40] feat(bot): add utility admin command --- PluralKit.Bot/CommandMeta/CommandTree.cs | 2 ++ PluralKit.Bot/Commands/Admin.cs | 30 ++++++++++++++++++++++++ 2 files changed, 32 insertions(+) diff --git a/PluralKit.Bot/CommandMeta/CommandTree.cs b/PluralKit.Bot/CommandMeta/CommandTree.cs index 67379fe1..d1ab6da0 100644 --- a/PluralKit.Bot/CommandMeta/CommandTree.cs +++ b/PluralKit.Bot/CommandMeta/CommandTree.cs @@ -181,6 +181,8 @@ public partial class CommandTree await ctx.Execute(Admin, a => a.SystemRecover(ctx)); else if (ctx.Match("sd", "systemdelete")) await ctx.Execute(Admin, a => a.SystemDelete(ctx)); + else if (ctx.Match("sendmsg", "sendmessage")) + await ctx.Execute(Admin, a => a.SendAdminMessage(ctx)); else if (ctx.Match("al", "abuselog")) await HandleAdminAbuseLogCommand(ctx); else diff --git a/PluralKit.Bot/Commands/Admin.cs b/PluralKit.Bot/Commands/Admin.cs index a31b0dd0..da859616 100644 --- a/PluralKit.Bot/Commands/Admin.cs +++ b/PluralKit.Bot/Commands/Admin.cs @@ -9,6 +9,7 @@ using Myriad.Extensions; using Myriad.Cache; using Myriad.Rest; using Myriad.Types; +using Myriad.Rest.Types.Requests; using PluralKit.Core; @@ -496,4 +497,33 @@ public class Admin await ctx.Repository.DeleteAbuseLog(abuseLog.Id); await ctx.Reply($"{Emojis.Success} Successfully deleted abuse log entry."); } + + public async Task SendAdminMessage(Context ctx) + { + ctx.AssertBotAdmin(); + + var account = await ctx.MatchUser(); + if (account == null) + throw new PKError("You must pass an account to send an admin message to (either ID or @mention)."); + if (!ctx.HasNext()) + throw new PKError("You must provide a message to send."); + + var content = ctx.RemainderOrNull(false).NormalizeLineEndSpacing(); + var messageContent = $"## [Admin Message]\n\n{content}\n\nWe cannot read replies sent to this DM. If you wish to contact the staff team, please join the support server () or send us an email at ."; + + try + { + var dm = await _rest.CreateDm(account.Id); + var msg = await ctx.Rest.CreateMessage(dm.Id, + new MessageRequest { Content = messageContent } + ); + } + catch (Exception) + { + await ctx.Reply( + $"{Emojis.Error} Error while sending DM."); + } + + await ctx.Reply($"{Emojis.Success} Successfully sent message."); + } } \ No newline at end of file From ebf8a403695f10a947430aa59e90fe99d708c2bd Mon Sep 17 00:00:00 2001 From: asleepyskye Date: Tue, 9 Sep 2025 11:32:13 -0400 Subject: [PATCH 36/40] fix(bot): fix utility admin command --- PluralKit.Bot/Commands/Admin.cs | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/PluralKit.Bot/Commands/Admin.cs b/PluralKit.Bot/Commands/Admin.cs index da859616..44171345 100644 --- a/PluralKit.Bot/Commands/Admin.cs +++ b/PluralKit.Bot/Commands/Admin.cs @@ -10,6 +10,7 @@ using Myriad.Cache; using Myriad.Rest; using Myriad.Types; using Myriad.Rest.Types.Requests; +using Myriad.Rest.Exceptions; using PluralKit.Core; @@ -20,12 +21,14 @@ public class Admin private readonly BotConfig _botConfig; private readonly DiscordApiClient _rest; private readonly IDiscordCache _cache; + private readonly PrivateChannelService _dmCache; - public Admin(BotConfig botConfig, DiscordApiClient rest, IDiscordCache cache) + public Admin(BotConfig botConfig, DiscordApiClient rest, IDiscordCache cache, PrivateChannelService dmCache) { _botConfig = botConfig; _rest = rest; _cache = cache; + _dmCache = dmCache; } private Task<(ulong Id, User? User)[]> GetUsers(IEnumerable ids) @@ -513,15 +516,16 @@ public class Admin try { - var dm = await _rest.CreateDm(account.Id); - var msg = await ctx.Rest.CreateMessage(dm.Id, + var dm = await _dmCache.GetOrCreateDmChannel(account.Id); + var msg = await ctx.Rest.CreateMessage(dm, new MessageRequest { Content = messageContent } ); } - catch (Exception) + catch (ForbiddenException) { await ctx.Reply( $"{Emojis.Error} Error while sending DM."); + return; } await ctx.Reply($"{Emojis.Success} Successfully sent message."); From 9c99a0bc02d5299a3ff66581eb7d1bd9fb7c1262 Mon Sep 17 00:00:00 2001 From: asleepyskye Date: Thu, 18 Sep 2025 08:06:55 -0400 Subject: [PATCH 37/40] chore: update faq for cv2 --- docs/content/faq.md | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/docs/content/faq.md b/docs/content/faq.md index 27b1ef3a..f4141956 100644 --- a/docs/content/faq.md +++ b/docs/content/faq.md @@ -99,4 +99,9 @@ It is not possible to edit messages via ID. Please use the full link, or reply t You cannot reply-@ a proxied messages due to their nature as webhooks. If you want to "reply-@" a proxied message, you must react to the message with 🔔, 🛎, or 🏓. This will send a message from PluralKit that reads "Psst, MEMBER (@User), you have been pinged by @You", which will ping the Discord account behind the proxied message. ### Why do most of PluralKit's messages look blank or empty? -A lot of PluralKit's command responses use Discord embeds. If you can't see them, it's likely you have embeds turned off. To change this, go into your discord settings and find the tab "Chat" under "App Settings". Find the setting "Show embeds and preview website links" and turn it on. If it's already on, try turning it off and then on again. \ No newline at end of file +PluralKit now uses Discord's "Components V2" for system/member/group cards - if the cards no longer show, your Discord app is too old to show the new components, and you should update it. +A temporary workaround to show the old version of the cards exists as the -show-embed (or -se) flag to pk;system / pk;member / pk;group - however, we will be removing the old embed-based cards in the future (and as such, we will not add a config option to always use the old cards). + +Please read the announcement post for more details: + +Some of PluralKit's command responses still use Discord embeds. If you can't see them, it's likely you have embeds turned off. To change this, go into your discord settings and find the tab "Chat" under "App Settings". Find the setting "Show embeds and preview website links" and turn it on. If it's already on, try turning it off and then on again. \ No newline at end of file From 24361d9d2bf6d45d924cf691fd6715fe9ec6d6b1 Mon Sep 17 00:00:00 2001 From: alyssa Date: Thu, 18 Sep 2025 23:32:00 +0000 Subject: [PATCH 38/40] fix(bot): correctly check for existence of current system in embeds --- PluralKit.Bot/Services/EmbedService.cs | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/PluralKit.Bot/Services/EmbedService.cs b/PluralKit.Bot/Services/EmbedService.cs index 7ed006e3..c8c07996 100644 --- a/PluralKit.Bot/Services/EmbedService.cs +++ b/PluralKit.Bot/Services/EmbedService.cs @@ -57,7 +57,7 @@ public class EmbedService var countctx = LookupContext.ByNonOwner; if (cctx.MatchFlag("a", "all")) { - if (system.Id == cctx.System.Id) + if (system.Id == cctx.System?.Id) countctx = LookupContext.ByOwner; else throw Errors.LookupNotAllowed; @@ -89,7 +89,7 @@ public class EmbedService if (system.MemberListPrivacy.CanAccess(ctx)) { headerText += $"\n**Members:** {memberCount}"; - if (system.Id == cctx.System.Id) + if (system.Id == cctx.System?.Id) if (memberCount > 0) headerText += $" (see `{cctx.DefaultPrefix}system list`)"; else @@ -215,7 +215,7 @@ public class EmbedService var countctx = LookupContext.ByNonOwner; if (cctx.MatchFlag("a", "all")) { - if (system.Id == cctx.System.Id) + if (system.Id == cctx.System?.Id) countctx = LookupContext.ByOwner; else throw Errors.LookupNotAllowed; @@ -570,7 +570,7 @@ public class EmbedService var countctx = LookupContext.ByNonOwner; if (ctx.MatchFlag("a", "all")) { - if (system.Id == ctx.System.Id) + if (system.Id == ctx.System?.Id) countctx = LookupContext.ByOwner; else throw Errors.LookupNotAllowed; @@ -588,7 +588,7 @@ public class EmbedService if (target.ListPrivacy.CanAccess(pctx)) { headerText += $"\n**Members:** {memberCount}"; - if (system.Id == ctx.System.Id && memberCount == 0) + if (system.Id == ctx.System?.Id && memberCount == 0) headerText += $" (add one with `{ctx.DefaultPrefix}group {target.Reference(ctx)} add `!)"; else if (memberCount > 0) headerText += $" (see `{ctx.DefaultPrefix}group {target.Reference(ctx)} list`)"; @@ -680,7 +680,7 @@ public class EmbedService var countctx = LookupContext.ByNonOwner; if (ctx.MatchFlag("a", "all")) { - if (system.Id == ctx.System.Id) + if (system.Id == ctx.System?.Id) countctx = LookupContext.ByOwner; else throw Errors.LookupNotAllowed; From 39179f8e3a60995400ffdf81ce5234c5f4737318 Mon Sep 17 00:00:00 2001 From: asleepyskye Date: Fri, 19 Sep 2025 09:30:20 -0400 Subject: [PATCH 39/40] fix(gateway): properly check for reconnect --- crates/gateway/src/discord/gateway.rs | 72 ++++++++++++++++----------- 1 file changed, 44 insertions(+), 28 deletions(-) diff --git a/crates/gateway/src/discord/gateway.rs b/crates/gateway/src/discord/gateway.rs index 215fb4cf..c4d0483e 100644 --- a/crates/gateway/src/discord/gateway.rs +++ b/crates/gateway/src/discord/gateway.rs @@ -6,7 +6,7 @@ use std::sync::Arc; use tokio::sync::mpsc::Sender; use tracing::{error, info, warn}; use twilight_gateway::{ - CloseFrame, ConfigBuilder, Event, EventTypeFlags, Message, Shard, ShardId, create_iterator, + ConfigBuilder, Event, EventTypeFlags, Message, Shard, ShardId, create_iterator, }; use twilight_model::gateway::{ Intents, @@ -118,8 +118,11 @@ pub async fn runner( Message::Close(frame) => { let mut state_event = ShardStateEvent::Closed; let close_code = if let Some(close) = frame { - if close == CloseFrame::RESUME { - state_event = ShardStateEvent::Reconnect; + match close.code { + 4000..=4003 | 4005..=4009 => { + state_event = ShardStateEvent::Reconnect; + } + _ => {} } close.code.to_string() } else { @@ -176,32 +179,45 @@ pub async fn runner( ) .increment(1); - // update shard state and discord cache - if matches!(event, Event::Ready(_)) || matches!(event, Event::Resumed) { - if let Err(error) = tx_state.try_send(( - shard.id(), - ShardStateEvent::Other, - Some(event.clone()), - None, - )) { - tracing::error!(?error, "error updating shard state"); + // check for shard status events + match event { + Event::Ready(_) | Event::Resumed => { + if let Err(error) = tx_state.try_send(( + shard.id(), + ShardStateEvent::Other, + Some(event.clone()), + None, + )) { + tracing::error!(?error, "error updating shard state"); + } } - } - // need to do heartbeat separately, to get the latency - let latency_num = shard - .latency() - .recent() - .first() - .map_or_else(|| 0, |d| d.as_millis()) as i32; - if let Event::GatewayHeartbeatAck = event - && let Err(error) = tx_state.try_send(( - shard.id(), - ShardStateEvent::Heartbeat, - Some(event.clone()), - Some(latency_num), - )) - { - tracing::error!(?error, "error updating shard state for latency"); + Event::GatewayReconnect => { + if let Err(error) = tx_state.try_send(( + shard.id(), + ShardStateEvent::Reconnect, + Some(event.clone()), + None, + )) { + tracing::error!(?error, "error updating shard state for reconnect"); + } + } + Event::GatewayHeartbeatAck => { + // need to do heartbeat separately, to get the latency + let latency_num = shard + .latency() + .recent() + .first() + .map_or_else(|| 0, |d| d.as_millis()) as i32; + if let Err(error) = tx_state.try_send(( + shard.id(), + ShardStateEvent::Heartbeat, + Some(event.clone()), + Some(latency_num), + )) { + tracing::error!(?error, "error updating shard state for latency"); + } + } + _ => {} } if let Event::Ready(_) = event { From 14f11bd1e91bff4aa30ac04c7e478c01295f1d41 Mon Sep 17 00:00:00 2001 From: Jake Fulmine Date: Sat, 20 Sep 2025 02:46:29 +0200 Subject: [PATCH 40/40] fix(bot): take member name privacy into account when viewing member groups --- PluralKit.Bot/Commands/GroupMember.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PluralKit.Bot/Commands/GroupMember.cs b/PluralKit.Bot/Commands/GroupMember.cs index 761d1e54..b30abb24 100644 --- a/PluralKit.Bot/Commands/GroupMember.cs +++ b/PluralKit.Bot/Commands/GroupMember.cs @@ -57,7 +57,7 @@ public class GroupMember var opts = ctx.ParseListOptions(ctx.DirectLookupContextFor(target.System), ctx.LookupContextFor(target.System)); opts.MemberFilter = target.Id; - var title = new StringBuilder($"Groups containing {target.Name} (`{target.DisplayHid(ctx.Config)}`) in "); + var title = new StringBuilder($"Groups containing {target.NameFor(ctx)} (`{target.DisplayHid(ctx.Config)}`) in "); if (ctx.Guild != null) { var guildSettings = await ctx.Repository.GetSystemGuild(ctx.Guild.Id, targetSystem.Id);