eightball/PluralKit
1
0
Fork 0
mirror of https://github.com/PluralKit/PluralKit.git synced 2026-02-13 01:00:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

chore: rework group displayname embed to better respect name privacy

Browse source
This commit is contained in:
rladenson 2025-01-04 05:40:41 -07:00
parent 127714066c
commit b2b9623942
1 changed files with 15 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

26
PluralKit.Bot/Commands/Groups.cs
View file

@ -125,18 +125,19 @@ public class Groups
public async Task GroupDisplayName(Context ctx, PKGroup target) public async Task GroupDisplayName(Context ctx, PKGroup target)
{ {
var noDisplayNameSetMessage = "This group does not have a display name set."; var noDisplayNameSetMessage = "This group does not have a display name set" +
if (ctx.System?.Id == target.System) (ctx.System?.Id == target.System
noDisplayNameSetMessage += ? $". To set one, type `{ctx.DefaultPrefix}group {target.Reference(ctx)} displayname <display name>`."
$" To set one, type `{ctx.DefaultPrefix}group {target.Reference(ctx)} displayname <display name>`."; : " or name is private.");
// No perms check, display name isn't covered by member privacy // Whether displayname is shown or not should depend on if group name privacy is set.
// If name privacy is on then displayname should look like name.
var format = ctx.MatchFormat(); var format = ctx.MatchFormat();
// if there's nothing next or what's next is "raw"/"plaintext" we're doing a query, so check for null // if we're doing a raw or plaintext query check for null
if (!ctx.HasNext(false) || format != ReplyFormat.Standard) if (format != ReplyFormat.Standard)
if (target.DisplayName == null) if (target.DisplayName == null || !target.NamePrivacy.CanAccess(ctx.DirectLookupContextFor(target.System)))
{ {
await ctx.Reply(noDisplayNameSetMessage); await ctx.Reply(noDisplayNameSetMessage);
return; return;
@ -157,9 +158,12 @@ public class Groups
if (!ctx.HasNext(false)) if (!ctx.HasNext(false))
{ {
var showDisplayName = target.NamePrivacy.CanAccess(ctx.LookupContextFor(target.System)) && target.DisplayName != null;
var eb = new EmbedBuilder() var eb = new EmbedBuilder()
.Field(new Embed.Field("Name", target.Name)) .Title("Group names")
.Field(new Embed.Field("Display Name", target.DisplayName)); .Field(new Embed.Field("Name", target.NameFor(ctx)))
.Field(new Embed.Field("Display Name", showDisplayName ? target.DisplayName : "*(no displayname set or name is private)*"));
var reference = target.Reference(ctx); var reference = target.Reference(ctx);
@ -169,7 +173,7 @@ public class Groups
+ $"To clear it, type `{ctx.DefaultPrefix}group {reference} displayname -clear`.\n" + $"To clear it, type `{ctx.DefaultPrefix}group {reference} displayname -clear`.\n"
+ $"To print the raw display name, type `{ctx.DefaultPrefix}group {reference} displayname -raw`."); + $"To print the raw display name, type `{ctx.DefaultPrefix}group {reference} displayname -raw`.");
if (ctx.System?.Id == target.System) if (ctx.System?.Id == target.System && showDisplayName)
eb.Footer(new Embed.EmbedFooter($"Using {target.DisplayName.Length}/{Limits.MaxGroupNameLength} characters.")); eb.Footer(new Embed.EmbedFooter($"Using {target.DisplayName.Length}/{Limits.MaxGroupNameLength} characters."));
await ctx.Reply(embed: eb.Build()); await ctx.Reply(embed: eb.Build());