eightball/PluralKit
1
0
Fork 0
mirror of https://github.com/PluralKit/PluralKit.git synced 2026-02-07 14:27:54 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(bot): silence internal errors from initial handler checks

Browse source
This commit is contained in:
alyssa 2025-01-01 22:30:52 +00:00
parent e44d2afd7e
commit 8d53021863
2 changed files with 20 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

12
PluralKit.Bot/Bot.cs
View file

@ -179,7 +179,7 @@ public class Bot
catch (Exception exc)
{
await HandleError(handler, evt, serviceScope, exc);
await HandleError(handler, evt, serviceScope, exc, false);
}
_logger.Verbose("Received gateway event: {@Event}", evt);
@ -202,13 +202,13 @@ public class Bot
}
catch (Exception exc)
{
await HandleError(handler, evt, serviceScope, exc);
await HandleError(handler, evt, serviceScope, exc, false);
}
}
}
private async Task HandleError<T>(IEventHandler<T> handler, T evt, ILifetimeScope serviceScope,
Exception exc)
public async Task HandleError<T>(IEventHandler<T> handler, T evt, ILifetimeScope serviceScope,
Exception exc, bool preChecksDone)
where T : IGatewayEvent
{
_metrics.Measure.Meter.Mark(BotMetrics.BotErrors, exc.GetType().FullName);
@ -245,6 +245,10 @@ public class Bot
if (_config.DisableErrorReporting)
return;
// don't show errors for "failed to lookup channel" and such
// interaction handler doesn't have pre-checks, so just always try to show
if (!(preChecksDone && !(evt is InteractionCreateEvent _))) return;
if (!exc.ShowToUser()) return;
// Once we've sent it to Sentry, report it to the user (if we have permission to)