eightball/PluralKit
1
0
Fork 0
mirror of https://github.com/PluralKit/PluralKit.git synced 2026-02-04 04:56:49 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

fix(bot): remove query params from image attachment URLs for now

Browse source 
Discord is adding authentication parameters to CDN URLs - these being
present in stored URLs breaks when they expire, but CDN URLs still work
without those parameters until November/December 2023
This commit is contained in:
Iris System 2023-10-02 10:48:13 +13:00
parent 1777070694
commit 8cf50a7d97
1 changed files with 5 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

7
PluralKit.Bot/CommandSystem/Context/ContextAvatarExt.cs
View file

@ -33,8 +33,11 @@ public static class ContextAvatarExt
// If we have an attachment, use that // If we have an attachment, use that
if (ctx.Message.Attachments.FirstOrDefault() is { } attachment) if (ctx.Message.Attachments.FirstOrDefault() is { } attachment)
{ {
var url = attachment.ProxyUrl; // XXX: strip query params from attachment URLs because of new Discord CDN shenanigans
return new ParsedImage { Url = url, Source = AvatarSource.Attachment }; var uriBuilder = new UriBuilder(attachment.ProxyUrl);
uriBuilder.Query = "";
return new ParsedImage { Url = uriBuilder.Uri.AbsoluteUri, Source = AvatarSource.Attachment };
} }
// We should only get here if there are no arguments (which would get parsed as URL + throw if error) // We should only get here if there are no arguments (which would get parsed as URL + throw if error)